diff --git a/package/kernel/mt76/Makefile b/package/kernel/mt76/Makefile index dd75390ee7..762f474ce9 100644 --- a/package/kernel/mt76/Makefile +++ b/package/kernel/mt76/Makefile @@ -8,9 +8,9 @@ PKG_LICENSE_FILES:= PKG_SOURCE_URL:=https://github.com/openwrt/mt76 PKG_SOURCE_PROTO:=git -PKG_SOURCE_DATE:=2023-09-18 -PKG_SOURCE_VERSION:=2afc7285f75dca5a0583fd917285bf33f1429cc6 -PKG_MIRROR_HASH:=2c9556b298246277ac2d65415e4449f98e6d5fdb99e0d0a92262f162df772bbc +PKG_SOURCE_DATE:=2023-12-08 +PKG_SOURCE_VERSION:=f559adf1849c8af91f5a5eb670f4ed2c24988898 +PKG_MIRROR_HASH:=74dde4478442d5f0edbae918636b40767b0e49181b732d4184feeccd8a8cc328 PKG_MAINTAINER:=Felix Fietkau PKG_USE_NINJA:=0 @@ -318,7 +318,7 @@ endef define KernelPackage/mt7996e $(KernelPackage/mt76-default) TITLE:=MediaTek MT7996E wireless driver - DEPENDS+=@PCI_SUPPORT +kmod-mt76-connac + DEPENDS+=@PCI_SUPPORT +kmod-mt76-connac +kmod-hwmon-core FILES:= $(PKG_BUILD_DIR)/mt7996/mt7996e.ko AUTOLOAD:=$(call AutoProbe,mt7996e) endef diff --git a/package/kernel/mt76/patches/0001-net-ethernet-mtk_wed-rename-mtk_rxbm_desc-in-mtk_wed.patch b/package/kernel/mt76/patches/0001-net-ethernet-mtk_wed-rename-mtk_rxbm_desc-in-mtk_wed.patch deleted file mode 100644 index 15241c8195..0000000000 --- a/package/kernel/mt76/patches/0001-net-ethernet-mtk_wed-rename-mtk_rxbm_desc-in-mtk_wed.patch +++ /dev/null @@ -1,24 +0,0 @@ -From 9c7b98c03173a1a201d74203a81b344a0cd637ac Mon Sep 17 00:00:00 2001 -From: Lorenzo Bianconi -Date: Mon, 18 Sep 2023 12:29:07 +0200 -Subject: [PATCH] net: ethernet: mtk_wed: rename mtk_rxbm_desc in - mtk_wed_bm_desc - -Rename mtk_rxbm_desc structure in mtk_wed_bm_desc since it will be used -even on tx side by MT7988 SoC. - -Signed-off-by: Lorenzo Bianconi -Signed-off-by: Paolo Abeni ---- - ---- a/mt7915/mmio.c -+++ b/mt7915/mmio.c -@@ -591,7 +591,7 @@ static void mt7915_mmio_wed_release_rx_b - - static u32 mt7915_mmio_wed_init_rx_buf(struct mtk_wed_device *wed, int size) - { -- struct mtk_rxbm_desc *desc = wed->rx_buf_ring.desc; -+ struct mtk_wed_bm_desc *desc = wed->rx_buf_ring.desc; - struct mt76_txwi_cache *t = NULL; - struct mt7915_dev *dev; - struct mt76_queue *q; diff --git a/package/kernel/mt76/patches/0001-wifi-mt76-mt7996-fix-shift-overflow-warning-on-32-bi.patch b/package/kernel/mt76/patches/0001-wifi-mt76-mt7996-fix-shift-overflow-warning-on-32-bi.patch new file mode 100644 index 0000000000..5acc9e88a5 --- /dev/null +++ b/package/kernel/mt76/patches/0001-wifi-mt76-mt7996-fix-shift-overflow-warning-on-32-bi.patch @@ -0,0 +1,34 @@ +From f63f87cd5b45c3779293e6062c6b26bdf57e851d Mon Sep 17 00:00:00 2001 +From: Christian Marangi +Date: Sat, 9 Dec 2023 22:44:57 +0100 +Subject: [PATCH] wifi: mt76: mt7996: fix shift overflow warning on 32 bit + systems + +Fix additional shift overflow warning on 32 bit systems for mt7996 mac.c +source. + +Fixes: 95c14207d2a9 ("wifi: mt76: mt7996: set DMA mask to 36 bits for boards with more than 4GB of RAM") +Signed-off-by: Christian Marangi +--- + mt7996/mac.c | 10 +++++++--- + 1 file changed, 7 insertions(+), 3 deletions(-) + +--- a/mt7996/mac.c ++++ b/mt7996/mac.c +@@ -942,9 +942,13 @@ int mt7996_tx_prepare_skb(struct mt76_de + + txp = (struct mt76_connac_txp_common *)(txwi + MT_TXD_SIZE); + for (i = 0; i < nbuf; i++) { +- u16 len = FIELD_PREP(MT_TXP_BUF_LEN, tx_info->buf[i + 1].len) | +- FIELD_PREP(MT_TXP_DMA_ADDR_H, +- tx_info->buf[i + 1].addr >> 32); ++ u16 len; ++ ++ len = FIELD_PREP(MT_TXP_BUF_LEN, tx_info->buf[i + 1].len); ++#ifdef CONFIG_ARCH_DMA_ADDR_T_64BIT ++ len |= FIELD_PREP(MT_TXP_DMA_ADDR_H, ++ tx_info->buf[i + 1].addr >> 32); ++#endif + + txp->fw.buf[i] = cpu_to_le32(tx_info->buf[i + 1].addr); + txp->fw.len[i] = cpu_to_le16(len); diff --git a/package/kernel/mt76/patches/0002-wifi-mt76-mt7921-fix-6GHz-disabled-by-the-missing-de.patch b/package/kernel/mt76/patches/0002-wifi-mt76-mt7921-fix-6GHz-disabled-by-the-missing-de.patch new file mode 100644 index 0000000000..3fff9caa3c --- /dev/null +++ b/package/kernel/mt76/patches/0002-wifi-mt76-mt7921-fix-6GHz-disabled-by-the-missing-de.patch @@ -0,0 +1,31 @@ +From bebd9cffc2aeb2cecb40aadbb8c6eab3bdf7971b Mon Sep 17 00:00:00 2001 +From: Ming Yen Hsieh +Date: Mon, 30 Oct 2023 15:17:34 +0800 +Subject: [PATCH] wifi: mt76: mt7921: fix 6GHz disabled by the missing default + CLC config + +No matter CLC is enabled or disabled, the driver should initialize +the default value 0xff for channel configuration of CLC. Otherwise, +the zero value would disable channels. + +Reported-and-tested-by: Ben Greear +Closes: https://lore.kernel.org/all/2fb78387-d226-3193-8ca7-90040561b9ad@candelatech.com/ +Fixes: 09382d8f8641 ("wifi: mt76: mt7921: update the channel usage when the regd domain changed") +Signed-off-by: Ming Yen Hsieh +Signed-off-by: Deren Wu +Signed-off-by: Kalle Valo +Link: https://lore.kernel.org/r/5a976ddf1f636b5cb809373501d3cfdc6d8de3e4.1698648737.git.deren.wu@mediatek.com +--- + mt7921/mcu.c | 1 + + 1 file changed, 1 insertion(+) + +--- a/mt7921/mcu.c ++++ b/mt7921/mcu.c +@@ -375,6 +375,7 @@ static int mt7921_load_clc(struct mt792x + int ret, i, len, offset = 0; + u8 *clc_base = NULL, hw_encap = 0; + ++ dev->phy.clc_chan_conf = 0xff; + if (mt7921_disable_clc || + mt76_is_usb(&dev->mt76)) + return 0; diff --git a/package/kernel/mt76/patches/0003-wifi-mt76-mt7996-fix-fortify-warning.patch b/package/kernel/mt76/patches/0003-wifi-mt76-mt7996-fix-fortify-warning.patch new file mode 100644 index 0000000000..f3cf9c10fa --- /dev/null +++ b/package/kernel/mt76/patches/0003-wifi-mt76-mt7996-fix-fortify-warning.patch @@ -0,0 +1,26 @@ +From 786a339bac36d8e53eb8b540e79221d20011ab2a Mon Sep 17 00:00:00 2001 +From: Felix Fietkau +Date: Sat, 3 Feb 2024 14:21:58 +0100 +Subject: [PATCH] wifi: mt76: mt7996: fix fortify warning + +Copy cck and ofdm separately in order to avoid __read_overflow2_field +warning. + +Fixes: f75e4779d215 ("wifi: mt76: mt7996: add txpower setting support") +Signed-off-by: Felix Fietkau +--- + mt7996/mcu.c | 3 ++- + 1 file changed, 2 insertions(+), 1 deletion(-) + +--- a/mt7996/mcu.c ++++ b/mt7996/mcu.c +@@ -4477,7 +4477,8 @@ int mt7996_mcu_set_txpower_sku(struct mt + + skb_put_data(skb, &req, sizeof(req)); + /* cck and ofdm */ +- skb_put_data(skb, &la.cck, sizeof(la.cck) + sizeof(la.ofdm)); ++ skb_put_data(skb, &la.cck, sizeof(la.cck)); ++ skb_put_data(skb, &la.ofdm, sizeof(la.ofdm)); + /* ht20 */ + skb_put_data(skb, &la.mcs[0], 8); + /* ht40 */ diff --git a/package/kernel/mt76/patches/0004-wifi-mt76-mt7996-fix-fw-loading-timeout.patch b/package/kernel/mt76/patches/0004-wifi-mt76-mt7996-fix-fw-loading-timeout.patch new file mode 100644 index 0000000000..9c2247b0c2 --- /dev/null +++ b/package/kernel/mt76/patches/0004-wifi-mt76-mt7996-fix-fw-loading-timeout.patch @@ -0,0 +1,38 @@ +From bc37a7ebc267e400fc4e9886b7197b4b866763d1 Mon Sep 17 00:00:00 2001 +From: Lorenzo Bianconi +Date: Thu, 21 Dec 2023 10:41:18 +0100 +Subject: [PATCH] wifi: mt76: mt7996: fix fw loading timeout + +Fix the following firmware loading error due to a wrong dma register +configuration if wed is disabled. + +[ 8.245881] mt7996e_hif 0001:01:00.0: assign IRQ: got 128 +[ 8.251308] mt7996e_hif 0001:01:00.0: enabling device (0000 -> 0002) +[ 8.257674] mt7996e_hif 0001:01:00.0: enabling bus mastering +[ 8.263488] mt7996e 0000:01:00.0: assign IRQ: got 126 +[ 8.268537] mt7996e 0000:01:00.0: enabling device (0000 -> 0002) +[ 8.274551] mt7996e 0000:01:00.0: enabling bus mastering +[ 28.648773] mt7996e 0000:01:00.0: Message 00000010 (seq 1) timeout +[ 28.654959] mt7996e 0000:01:00.0: Failed to get patch semaphore +[ 29.661033] mt7996e: probe of 0000:01:00.0 failed with error -11 + +Suggested-by: Sujuan Chen" +Fixes: 4920a3a1285f ("wifi: mt76: mt7996: set DMA mask to 36 bits for boards with more than 4GB of RAM") +Signed-off-by: Lorenzo Bianconi +Signed-off-by: Felix Fietkau +--- + mt7996/dma.c | 3 ++- + 1 file changed, 2 insertions(+), 1 deletion(-) + +--- a/mt7996/dma.c ++++ b/mt7996/dma.c +@@ -237,7 +237,8 @@ void mt7996_dma_start(struct mt7996_dev + MT_WFDMA0_GLO_CFG_TX_DMA_EN | + MT_WFDMA0_GLO_CFG_RX_DMA_EN | + MT_WFDMA0_GLO_CFG_OMIT_TX_INFO | +- MT_WFDMA0_GLO_CFG_OMIT_RX_INFO_PFET2); ++ MT_WFDMA0_GLO_CFG_OMIT_RX_INFO_PFET2 | ++ MT_WFDMA0_GLO_CFG_EXT_EN); + + if (dev->hif2) + mt76_set(dev, MT_WFDMA0_GLO_CFG + hif1_ofs, diff --git a/package/kernel/mt76/patches/0005-wifi-mt76-mt7996-check-txs-format-before-getting-skb.patch b/package/kernel/mt76/patches/0005-wifi-mt76-mt7996-check-txs-format-before-getting-skb.patch new file mode 100644 index 0000000000..f72c76ec66 --- /dev/null +++ b/package/kernel/mt76/patches/0005-wifi-mt76-mt7996-check-txs-format-before-getting-skb.patch @@ -0,0 +1,60 @@ +From 025d5734caba6fa1fd96b57c19c61e42e601815b Mon Sep 17 00:00:00 2001 +From: Peter Chiu +Date: Fri, 26 Jan 2024 17:09:12 +0800 +Subject: [PATCH] wifi: mt76: mt7996: check txs format before getting skb by + pid + +The PPDU TXS does not include the error bit so it cannot use to report +status to mac80211. This patch fixes issue that STA wrongly detects if AP +is still alive. + +Fixes: 2569ea5326e2 ("wifi: mt76: mt7996: enable PPDU-TxS to host") +Signed-off-by: Peter Chiu +Signed-off-by: Shayne Chen +Signed-off-by: Felix Fietkau +--- + mt7996/mac.c | 23 +++++++++++++---------- + 1 file changed, 13 insertions(+), 10 deletions(-) + +--- a/mt7996/mac.c ++++ b/mt7996/mac.c +@@ -1188,25 +1188,28 @@ mt7996_mac_add_txs_skb(struct mt7996_dev + struct ieee80211_tx_info *info; + struct sk_buff_head list; + struct rate_info rate = {}; +- struct sk_buff *skb; ++ struct sk_buff *skb = NULL; + bool cck = false; + u32 txrate, txs, mode, stbc; + + txs = le32_to_cpu(txs_data[0]); + + mt76_tx_status_lock(mdev, &list); +- skb = mt76_tx_status_skb_get(mdev, wcid, pid, &list); + +- if (skb) { +- info = IEEE80211_SKB_CB(skb); +- if (!(txs & MT_TXS0_ACK_ERROR_MASK)) +- info->flags |= IEEE80211_TX_STAT_ACK; +- +- info->status.ampdu_len = 1; +- info->status.ampdu_ack_len = +- !!(info->flags & IEEE80211_TX_STAT_ACK); ++ /* only report MPDU TXS */ ++ if (le32_get_bits(txs_data[0], MT_TXS0_TXS_FORMAT) == 0) { ++ skb = mt76_tx_status_skb_get(mdev, wcid, pid, &list); ++ if (skb) { ++ info = IEEE80211_SKB_CB(skb); ++ if (!(txs & MT_TXS0_ACK_ERROR_MASK)) ++ info->flags |= IEEE80211_TX_STAT_ACK; ++ ++ info->status.ampdu_len = 1; ++ info->status.ampdu_ack_len = ++ !!(info->flags & IEEE80211_TX_STAT_ACK); + +- info->status.rates[0].idx = -1; ++ info->status.rates[0].idx = -1; ++ } + } + + if (mtk_wed_device_active(&dev->mt76.mmio.wed) && wcid->sta) { diff --git a/package/kernel/mt76/patches/0006-wifi-mt76-mt7921-fix-incorrect-type-conversion-for-C.patch b/package/kernel/mt76/patches/0006-wifi-mt76-mt7921-fix-incorrect-type-conversion-for-C.patch new file mode 100644 index 0000000000..a85dfb7f72 --- /dev/null +++ b/package/kernel/mt76/patches/0006-wifi-mt76-mt7921-fix-incorrect-type-conversion-for-C.patch @@ -0,0 +1,38 @@ +From d75eac9f5531e484fbbabf2652922976e15a7a7a Mon Sep 17 00:00:00 2001 +From: Ming Yen Hsieh +Date: Tue, 16 Jan 2024 10:48:54 +0800 +Subject: [PATCH] wifi: mt76: mt7921: fix incorrect type conversion for CLC + command + +clc->len is defined as 32 bits in length, so it must also be +operated on with 32 bits, not 16 bits. + +Fixes: fa6ad88e023d ("wifi: mt76: mt7921: fix country count limitation for CLC") +Signed-off-by: Ming Yen Hsieh +Reported-by: kernel test robot +Closes: https://lore.kernel.org/oe-kbuild-all/202312112104.Zkc3QUHr-lkp@intel.com/ +Signed-off-by: Felix Fietkau +--- + mt7921/mcu.c | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +--- a/mt7921/mcu.c ++++ b/mt7921/mcu.c +@@ -1272,7 +1272,7 @@ int __mt7921_mcu_set_clc(struct mt792x_d + .mtcl_conf = mt792x_acpi_get_mtcl_conf(&dev->phy, alpha2), + }; + int ret, valid_cnt = 0; +- u16 buf_len = 0; ++ u32 buf_len = 0; + u8 *pos; + + if (!clc) +@@ -1283,7 +1283,7 @@ int __mt7921_mcu_set_clc(struct mt792x_d + if (mt76_find_power_limits_node(&dev->mt76)) + req.cap |= CLC_CAP_DTS_EN; + +- buf_len = le16_to_cpu(clc->len) - sizeof(*clc); ++ buf_len = le32_to_cpu(clc->len) - sizeof(*clc); + pos = clc->data; + while (buf_len > 16) { + struct mt7921_clc_rule *rule = (struct mt7921_clc_rule *)pos; diff --git a/package/kernel/mt76/patches/0007-wifi-mt76-fix-the-issue-of-missing-txpwr-settings-fr.patch b/package/kernel/mt76/patches/0007-wifi-mt76-fix-the-issue-of-missing-txpwr-settings-fr.patch new file mode 100644 index 0000000000..380bdfac38 --- /dev/null +++ b/package/kernel/mt76/patches/0007-wifi-mt76-fix-the-issue-of-missing-txpwr-settings-fr.patch @@ -0,0 +1,28 @@ +From 841bf82e99581f648325bee570de98892cad894f Mon Sep 17 00:00:00 2001 +From: Ming Yen Hsieh +Date: Wed, 7 Feb 2024 11:31:23 +0800 +Subject: [PATCH] wifi: mt76: fix the issue of missing txpwr settings from + ch153 to ch177 + +Because the number of channels to be configured is calculated using the %, +and it results in 0 when there's an exact division, this leads to some +channels not having their tx power configured. + +Fixes: 7801da338856 ("wifi: mt76: mt7921: enable set txpower for UNII-4") +Signed-off-by: Ming Yen Hsieh +Signed-off-by: Felix Fietkau +--- + mt76_connac_mcu.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +--- a/mt76_connac_mcu.c ++++ b/mt76_connac_mcu.c +@@ -2101,7 +2101,7 @@ mt76_connac_mcu_rate_txpower_band(struct + int j, msg_len, num_ch; + struct sk_buff *skb; + +- num_ch = i == batch_size - 1 ? n_chan % batch_len : batch_len; ++ num_ch = i == batch_size - 1 ? n_chan - i * batch_len : batch_len; + msg_len = sizeof(tx_power_tlv) + num_ch * sizeof(sku_tlbv); + skb = mt76_mcu_msg_alloc(dev, NULL, msg_len); + if (!skb) { diff --git a/package/kernel/mt76/patches/0008-wifi-mt76-mt7996-fix-size-of-txpower-MCU-command.patch b/package/kernel/mt76/patches/0008-wifi-mt76-mt7996-fix-size-of-txpower-MCU-command.patch new file mode 100644 index 0000000000..f1d3af80b8 --- /dev/null +++ b/package/kernel/mt76/patches/0008-wifi-mt76-mt7996-fix-size-of-txpower-MCU-command.patch @@ -0,0 +1,56 @@ +From b108dda7e201994f10c885362b07ff3b6e1e843d Mon Sep 17 00:00:00 2001 +From: Chad Monroe +Date: Tue, 5 Mar 2024 17:55:35 +0000 +Subject: [PATCH] wifi: mt76: mt7996: fix size of txpower MCU command + +Fixes issues with scanning and low power output at some rates. + +Fixes: f75e4779d215 ("wifi: mt76: mt7996: add txpower setting support") +Signed-off-by: Chad Monroe +Signed-off-by: Ryder Lee +Signed-off-by: Felix Fietkau +--- + mt7996/mcu.c | 7 +++++-- + mt7996/mt7996.h | 1 + + 2 files changed, 6 insertions(+), 2 deletions(-) + +--- a/mt7996/mcu.c ++++ b/mt7996/mcu.c +@@ -4456,7 +4456,7 @@ int mt7996_mcu_set_txpower_sku(struct mt + u8 band_idx; + } __packed req = { + .tag = cpu_to_le16(UNI_TXPOWER_POWER_LIMIT_TABLE_CTRL), +- .len = cpu_to_le16(sizeof(req) + MT7996_SKU_RATE_NUM - 4), ++ .len = cpu_to_le16(sizeof(req) + MT7996_SKU_PATH_NUM - 4), + .power_ctrl_id = UNI_TXPOWER_POWER_LIMIT_TABLE_CTRL, + .power_limit_type = TX_POWER_LIMIT_TABLE_RATE, + .band_idx = phy->mt76->band_idx, +@@ -4471,7 +4471,7 @@ int mt7996_mcu_set_txpower_sku(struct mt + mphy->txpower_cur = tx_power; + + skb = mt76_mcu_msg_alloc(&dev->mt76, NULL, +- sizeof(req) + MT7996_SKU_RATE_NUM); ++ sizeof(req) + MT7996_SKU_PATH_NUM); + if (!skb) + return -ENOMEM; + +@@ -4495,6 +4495,9 @@ int mt7996_mcu_set_txpower_sku(struct mt + /* eht */ + skb_put_data(skb, &la.eht[0], sizeof(la.eht)); + ++ /* padding */ ++ skb_put_zero(skb, MT7996_SKU_PATH_NUM - MT7996_SKU_RATE_NUM); ++ + return mt76_mcu_skb_send_msg(&dev->mt76, skb, + MCU_WM_UNI_CMD(TXPOWER), true); + } +--- a/mt7996/mt7996.h ++++ b/mt7996/mt7996.h +@@ -50,6 +50,7 @@ + #define MT7996_CFEND_RATE_11B 0x03 /* 11B LP, 11M */ + + #define MT7996_SKU_RATE_NUM 417 ++#define MT7996_SKU_PATH_NUM 494 + + #define MT7996_MAX_TWT_AGRT 16 + #define MT7996_MAX_STA_TWT_AGRT 8 diff --git a/package/kernel/mt76/patches/0009-wifi-mt76-mt7996-fix-uninitialized-variable-in-mt799.patch b/package/kernel/mt76/patches/0009-wifi-mt76-mt7996-fix-uninitialized-variable-in-mt799.patch new file mode 100644 index 0000000000..b0b7a78e3c --- /dev/null +++ b/package/kernel/mt76/patches/0009-wifi-mt76-mt7996-fix-uninitialized-variable-in-mt799.patch @@ -0,0 +1,27 @@ +From b96ab5e62010887a8abee43dbcccf6f4b3fcb269 Mon Sep 17 00:00:00 2001 +From: Lorenzo Bianconi +Date: Tue, 19 Mar 2024 13:05:36 +0100 +Subject: [PATCH] wifi: mt76: mt7996: fix uninitialized variable in + mt7996_irq_tasklet() + +Set intr1 to 0 in mt7996_irq_tasklet() in order to avoid possible +uninitialized variable usage if wed is not active for hif2. + +Fixes: 83eafc9251d6 ("wifi: mt76: mt7996: add wed tx support") +Signed-off-by: Lorenzo Bianconi +Signed-off-by: Felix Fietkau +--- + mt7996/mmio.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +--- a/mt7996/mmio.c ++++ b/mt7996/mmio.c +@@ -499,7 +499,7 @@ static void mt7996_irq_tasklet(struct ta + struct mt7996_dev *dev = from_tasklet(dev, t, mt76.irq_tasklet); + struct mtk_wed_device *wed = &dev->mt76.mmio.wed; + struct mtk_wed_device *wed_hif2 = &dev->mt76.mmio.wed_hif2; +- u32 i, intr, mask, intr1; ++ u32 i, intr, mask, intr1 = 0; + + if (dev->hif2 && mtk_wed_device_active(wed_hif2)) { + mtk_wed_device_irq_set_mask(wed_hif2, 0); diff --git a/package/kernel/mt76/patches/0010-wifi-mt76-mt7996-fix-potential-memory-leakage-when-r.patch b/package/kernel/mt76/patches/0010-wifi-mt76-mt7996-fix-potential-memory-leakage-when-r.patch new file mode 100644 index 0000000000..a0d62dc5af --- /dev/null +++ b/package/kernel/mt76/patches/0010-wifi-mt76-mt7996-fix-potential-memory-leakage-when-r.patch @@ -0,0 +1,39 @@ +From 424e9df466cea3bb39a1e92bf95f3efe65472c27 Mon Sep 17 00:00:00 2001 +From: Howard Hsu +Date: Wed, 20 Mar 2024 19:09:14 +0800 +Subject: [PATCH] wifi: mt76: mt7996: fix potential memory leakage when reading + chip temperature + +Without this commit, reading chip temperature will cause memory leakage. + +Fixes: 6879b2e94172 ("wifi: mt76: mt7996: add thermal sensor device support") +Reported-by: Ryder Lee +Signed-off-by: Howard Hsu +Signed-off-by: Shayne Chen +Signed-off-by: Felix Fietkau +--- + mt7996/mcu.c | 5 ++++- + 1 file changed, 4 insertions(+), 1 deletion(-) + +--- a/mt7996/mcu.c ++++ b/mt7996/mcu.c +@@ -3721,6 +3721,7 @@ int mt7996_mcu_get_temperature(struct mt + } __packed * res; + struct sk_buff *skb; + int ret; ++ u32 temp; + + ret = mt76_mcu_send_and_get_msg(&phy->dev->mt76, MCU_WM_UNI_CMD(THERMAL), + &req, sizeof(req), true, &skb); +@@ -3728,8 +3729,10 @@ int mt7996_mcu_get_temperature(struct mt + return ret; + + res = (void *)skb->data; ++ temp = le32_to_cpu(res->temperature); ++ dev_kfree_skb(skb); + +- return le32_to_cpu(res->temperature); ++ return temp; + } + + int mt7996_mcu_set_thermal_throttling(struct mt7996_phy *phy, u8 state)