mac80211: ath11k: replace 160MHz fix with upstream pending one
QCA has finally sent a proper fixup for the 160MHz regression upstream, so lets use the pending fix which also properly sets center frequency 2 in case 80+80 MHz is used. Signed-off-by: Robert Marko <robimarko@gmail.com>
This commit is contained in:
		
				
					committed by
					
						
						Christian Marangi
					
				
			
			
				
	
			
			
			
						parent
						
							4ab4b9ea81
						
					
				
				
					commit
					f7f47b1369
				
			@@ -0,0 +1,130 @@
 | 
			
		||||
From patchwork Mon Apr 17 20:22:27 2023
 | 
			
		||||
Content-Type: text/plain; charset="utf-8"
 | 
			
		||||
MIME-Version: 1.0
 | 
			
		||||
Content-Transfer-Encoding: 7bit
 | 
			
		||||
X-Patchwork-Submitter: Muna Sinada <quic_msinada@quicinc.com>
 | 
			
		||||
X-Patchwork-Id: 13214540
 | 
			
		||||
X-Patchwork-Delegate: kvalo@adurom.com
 | 
			
		||||
Return-Path: <linux-wireless-owner@vger.kernel.org>
 | 
			
		||||
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
 | 
			
		||||
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
 | 
			
		||||
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
 | 
			
		||||
	by smtp.lore.kernel.org (Postfix) with ESMTP id 8C359C77B76
 | 
			
		||||
	for <linux-wireless@archiver.kernel.org>;
 | 
			
		||||
 Mon, 17 Apr 2023 20:26:40 +0000 (UTC)
 | 
			
		||||
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
 | 
			
		||||
        id S230070AbjDQU0j (ORCPT
 | 
			
		||||
        <rfc822;linux-wireless@archiver.kernel.org>);
 | 
			
		||||
        Mon, 17 Apr 2023 16:26:39 -0400
 | 
			
		||||
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53306 "EHLO
 | 
			
		||||
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
 | 
			
		||||
        with ESMTP id S229914AbjDQU0h (ORCPT
 | 
			
		||||
        <rfc822;linux-wireless@vger.kernel.org>);
 | 
			
		||||
        Mon, 17 Apr 2023 16:26:37 -0400
 | 
			
		||||
Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com
 | 
			
		||||
 [205.220.180.131])
 | 
			
		||||
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 67CE24C33
 | 
			
		||||
        for <linux-wireless@vger.kernel.org>;
 | 
			
		||||
 Mon, 17 Apr 2023 13:26:24 -0700 (PDT)
 | 
			
		||||
Received: from pps.filterd (m0279873.ppops.net [127.0.0.1])
 | 
			
		||||
        by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id
 | 
			
		||||
 33HIsf5q010173;
 | 
			
		||||
        Mon, 17 Apr 2023 20:22:47 GMT
 | 
			
		||||
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com;
 | 
			
		||||
 h=from : to : cc :
 | 
			
		||||
 subject : date : message-id : mime-version : content-type; s=qcppdkim1;
 | 
			
		||||
 bh=FGtbeAR6pG0KxyEKVLIRzkq1RXlKfaVfRT1iixzMcII=;
 | 
			
		||||
 b=jSdZBeFj4RAdCiUPrL/F9n+ufnpxT1pJNfZuA0tfEnUf54SCGUuHT5LtRdojYVh31YSS
 | 
			
		||||
 aAGDRFvl7tIKqq/c6h4tm7SDdlhWF+MU3sH1YJNrwDeMAUZD+RnviJjo+GfgnEtp9+z7
 | 
			
		||||
 PA75vGkpKiuMh6M8QFYB+/XxrJmx/XJBNESfMdAjBuMXnQf4S2yJ/IMwSxPkYKMU3lC6
 | 
			
		||||
 DNnUAcgC/8wawYt8T1d8gKWq5CgWls4i1quveZghsbGUuL01i7SRXdKVianDJJsHEa0G
 | 
			
		||||
 /brUp6LMMeJUgEI8wBfFAtcknzN0ADMVEqsJr+AHvQXnb1iHZyafl6BAeupXNS+Yi+fJ sw==
 | 
			
		||||
Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com
 | 
			
		||||
 [129.46.96.20])
 | 
			
		||||
        by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3q171gh1hb-1
 | 
			
		||||
        (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256
 | 
			
		||||
 verify=NOT);
 | 
			
		||||
        Mon, 17 Apr 2023 20:22:47 +0000
 | 
			
		||||
Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com
 | 
			
		||||
 [10.47.209.196])
 | 
			
		||||
        by NALASPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id
 | 
			
		||||
 33HKMjHs007640
 | 
			
		||||
        (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256
 | 
			
		||||
 verify=NOT);
 | 
			
		||||
        Mon, 17 Apr 2023 20:22:46 GMT
 | 
			
		||||
Received: from msinada-linux.qualcomm.com (10.80.80.8) by
 | 
			
		||||
 nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server
 | 
			
		||||
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 | 
			
		||||
 15.2.986.42; Mon, 17 Apr 2023 13:22:44 -0700
 | 
			
		||||
From: Muna Sinada <quic_msinada@quicinc.com>
 | 
			
		||||
To: <ath11k@lists.infradead.org>
 | 
			
		||||
CC: <linux-wireless@vger.kernel.org>,
 | 
			
		||||
        Muna Sinada <quic_msinada@quicinc.com>,
 | 
			
		||||
        P Praneesh <quic_ppranees@quicinc.com>
 | 
			
		||||
Subject: [PATCH] wifi: ath11k: Remove disabling of 80+80 and 160 MHz
 | 
			
		||||
Date: Mon, 17 Apr 2023 13:22:27 -0700
 | 
			
		||||
Message-ID: <1681762947-13882-1-git-send-email-quic_msinada@quicinc.com>
 | 
			
		||||
X-Mailer: git-send-email 2.7.4
 | 
			
		||||
MIME-Version: 1.0
 | 
			
		||||
X-Originating-IP: [10.80.80.8]
 | 
			
		||||
X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To
 | 
			
		||||
 nalasex01a.na.qualcomm.com (10.47.209.196)
 | 
			
		||||
X-QCInternal: smtphost
 | 
			
		||||
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800
 | 
			
		||||
 signatures=585085
 | 
			
		||||
X-Proofpoint-GUID: wqGG1zw0KpXNYk_yFYb16HwLWt9V-6o4
 | 
			
		||||
X-Proofpoint-ORIG-GUID: wqGG1zw0KpXNYk_yFYb16HwLWt9V-6o4
 | 
			
		||||
X-Proofpoint-Virus-Version: vendor=baseguard
 | 
			
		||||
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 | 
			
		||||
 definitions=2023-04-17_13,2023-04-17_01,2023-02-09_01
 | 
			
		||||
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0
 | 
			
		||||
 priorityscore=1501 mlxscore=0
 | 
			
		||||
 mlxlogscore=796 suspectscore=0 impostorscore=0 bulkscore=0 spamscore=0
 | 
			
		||||
 clxscore=1015 phishscore=0 lowpriorityscore=0 malwarescore=0 adultscore=0
 | 
			
		||||
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000
 | 
			
		||||
 definitions=main-2304170181
 | 
			
		||||
Precedence: bulk
 | 
			
		||||
List-ID: <linux-wireless.vger.kernel.org>
 | 
			
		||||
X-Mailing-List: linux-wireless@vger.kernel.org
 | 
			
		||||
 | 
			
		||||
This is a regression fix for 80+80 and 160 MHz support bits being
 | 
			
		||||
cleared, therefore not adverised. Remove disable of 80+80 and 160 MHz
 | 
			
		||||
capability flags and assign valid center frequency 2 similar to
 | 
			
		||||
VHT80_80.
 | 
			
		||||
 | 
			
		||||
Fixes: 38dfe775d0ab ("wifi: ath11k: push MU-MIMO params from hostapd to hardware")
 | 
			
		||||
Reported-by: Robert Marko <robert.marko@sartura.hr>
 | 
			
		||||
Link: https://bugzilla.kernel.org/show_bug.cgi?id=217299
 | 
			
		||||
Co-developed-by: P Praneesh <quic_ppranees@quicinc.com>
 | 
			
		||||
Signed-off-by: P Praneesh <quic_ppranees@quicinc.com>
 | 
			
		||||
Signed-off-by: Muna Sinada <quic_msinada@quicinc.com>
 | 
			
		||||
---
 | 
			
		||||
 drivers/net/wireless/ath/ath11k/mac.c | 4 ----
 | 
			
		||||
 drivers/net/wireless/ath/ath11k/wmi.c | 3 ++-
 | 
			
		||||
 2 files changed, 2 insertions(+), 5 deletions(-)
 | 
			
		||||
 | 
			
		||||
--- a/drivers/net/wireless/ath/ath11k/mac.c
 | 
			
		||||
+++ b/drivers/net/wireless/ath/ath11k/mac.c
 | 
			
		||||
@@ -5585,10 +5585,6 @@ static int ath11k_mac_copy_he_cap(struct
 | 
			
		||||
 
 | 
			
		||||
 		he_cap_elem->mac_cap_info[1] &=
 | 
			
		||||
 			IEEE80211_HE_MAC_CAP1_TF_MAC_PAD_DUR_MASK;
 | 
			
		||||
-		he_cap_elem->phy_cap_info[0] &=
 | 
			
		||||
-			~IEEE80211_HE_PHY_CAP0_CHANNEL_WIDTH_SET_160MHZ_IN_5G;
 | 
			
		||||
-		he_cap_elem->phy_cap_info[0] &=
 | 
			
		||||
-			~IEEE80211_HE_PHY_CAP0_CHANNEL_WIDTH_SET_80PLUS80_MHZ_IN_5G;
 | 
			
		||||
 
 | 
			
		||||
 		he_cap_elem->phy_cap_info[5] &=
 | 
			
		||||
 			~IEEE80211_HE_PHY_CAP5_BEAMFORMEE_NUM_SND_DIM_UNDER_80MHZ_MASK;
 | 
			
		||||
--- a/drivers/net/wireless/ath/ath11k/wmi.c
 | 
			
		||||
+++ b/drivers/net/wireless/ath/ath11k/wmi.c
 | 
			
		||||
@@ -871,7 +871,8 @@ static void ath11k_wmi_put_wmi_channel(s
 | 
			
		||||
 
 | 
			
		||||
 		chan->band_center_freq2 = arg->channel.band_center_freq1;
 | 
			
		||||
 
 | 
			
		||||
-	} else if (arg->channel.mode == MODE_11AC_VHT80_80) {
 | 
			
		||||
+	} else if ((arg->channel.mode == MODE_11AC_VHT80_80) ||
 | 
			
		||||
+		   (arg->channel.mode == MODE_11AX_HE80_80)) {
 | 
			
		||||
 		chan->band_center_freq2 = arg->channel.band_center_freq2;
 | 
			
		||||
 	} else {
 | 
			
		||||
 		chan->band_center_freq2 = 0;
 | 
			
		||||
@@ -1,29 +0,0 @@
 | 
			
		||||
From e0edb3ac33694ab6a2705f7b053948a926520d81 Mon Sep 17 00:00:00 2001
 | 
			
		||||
From: Robert Marko <robimarko@gmail.com>
 | 
			
		||||
Date: Tue, 28 Mar 2023 13:30:30 +0200
 | 
			
		||||
Subject: [PATCH] wifi: ath11k: restore 160MHz support
 | 
			
		||||
 | 
			
		||||
The blamed commit started clearing 80+80 and 160MHz support flags for 5G.
 | 
			
		||||
This is preventing those modes from being advertised and thus used causing
 | 
			
		||||
a regression, so until this is properly sorted out lets remove the flag
 | 
			
		||||
clearing to restore 160MHz support.
 | 
			
		||||
 | 
			
		||||
Fixes: 38dfe775d0ab ("wifi: ath11k: push MU-MIMO params from hostapd to hardware")
 | 
			
		||||
Signed-off-by: Robert Marko <robimarko@gmail.com>
 | 
			
		||||
---
 | 
			
		||||
 drivers/net/wireless/ath/ath11k/mac.c | 4 ----
 | 
			
		||||
 1 file changed, 4 deletions(-)
 | 
			
		||||
 | 
			
		||||
--- a/drivers/net/wireless/ath/ath11k/mac.c
 | 
			
		||||
+++ b/drivers/net/wireless/ath/ath11k/mac.c
 | 
			
		||||
@@ -5585,10 +5585,6 @@ static int ath11k_mac_copy_he_cap(struct
 | 
			
		||||
 
 | 
			
		||||
 		he_cap_elem->mac_cap_info[1] &=
 | 
			
		||||
 			IEEE80211_HE_MAC_CAP1_TF_MAC_PAD_DUR_MASK;
 | 
			
		||||
-		he_cap_elem->phy_cap_info[0] &=
 | 
			
		||||
-			~IEEE80211_HE_PHY_CAP0_CHANNEL_WIDTH_SET_160MHZ_IN_5G;
 | 
			
		||||
-		he_cap_elem->phy_cap_info[0] &=
 | 
			
		||||
-			~IEEE80211_HE_PHY_CAP0_CHANNEL_WIDTH_SET_80PLUS80_MHZ_IN_5G;
 | 
			
		||||
 
 | 
			
		||||
 		he_cap_elem->phy_cap_info[5] &=
 | 
			
		||||
 			~IEEE80211_HE_PHY_CAP5_BEAMFORMEE_NUM_SND_DIM_UNDER_80MHZ_MASK;
 | 
			
		||||
@@ -271,7 +271,7 @@ Signed-off-by: Aditya Kumar Singh <quic_adisi@quicinc.com>
 | 
			
		||||
 #endif
 | 
			
		||||
--- a/drivers/net/wireless/ath/ath11k/wmi.c
 | 
			
		||||
+++ b/drivers/net/wireless/ath/ath11k/wmi.c
 | 
			
		||||
@@ -6979,24 +6979,12 @@ static void ath11k_wmi_htc_tx_complete(s
 | 
			
		||||
@@ -6980,24 +6980,12 @@ static void ath11k_wmi_htc_tx_complete(s
 | 
			
		||||
 		wake_up(&wmi->tx_ce_desc_wq);
 | 
			
		||||
 }
 | 
			
		||||
 
 | 
			
		||||
@@ -296,7 +296,7 @@ Signed-off-by: Aditya Kumar Singh <quic_adisi@quicinc.com>
 | 
			
		||||
 	int ret = 0, pdev_idx, i, j;
 | 
			
		||||
 	struct ath11k *ar;
 | 
			
		||||
 
 | 
			
		||||
@@ -7058,17 +7046,7 @@ static int ath11k_reg_chan_list_event(st
 | 
			
		||||
@@ -7059,17 +7047,7 @@ static int ath11k_reg_chan_list_event(st
 | 
			
		||||
 		    (char *)reg_info->alpha2, 2))
 | 
			
		||||
 		goto mem_free;
 | 
			
		||||
 
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user