324f234966
After booting, a "transmit queue 0 timed out" warning followed by a register dump was observed. The dump indicates that mtk_hw_init() does not initialize the EEECR during probe. This occurs because the netdev is allocated in mtk_add_mac(), which is called after mtk_hw_init(). Consequently, the EEECR register remains uninitialized until a reset is triggered, causing mtk_hw_init() to run again with a valid netdev, at which point the register is finally set. To address this, instead of modifying the probe sequence, latch the Tx LPI enable state and timer value, and move the EEECR register initialization to mtk_mac_link_up() to ensure proper setup when the interface comes up. Additionally, the splat reveals that LPI functionality is controlled by the MAC_MCR_EEE bits in the MCR register. Update mtk_set_eee() to modify these bits accordingly. Fixes:d8315d5358("kernel: backport Mediatek SoC EEE support") Fixes:edddbaf79c("kernel: Mediatek: set default EEE Tx LPI timer") Signed-off-by: Qingfang Deng <dqfext@gmail.com>
44 lines
1.3 KiB
Diff
44 lines
1.3 KiB
Diff
From: Danila Romanov <pervokur@gmail.com>
|
|
Date: Wed, 22 Jan 2025 06:48:45 +0100
|
|
Subject: [PATCH] net: ethernet: mtk_eth_soc: do not enable page pool stats by
|
|
default
|
|
|
|
There is no reason for it to be enabled by default.
|
|
Align mtk_eth_soc driver to mt76 driver.
|
|
|
|
This option incurs additional CPU cost in allocation and recycle paths
|
|
and additional memory cost to store the statistics.
|
|
|
|
Signed-off-by: Danila Romanov <pervokur@gmail.com>
|
|
Signed-off-by: Felix Fietkau <nbd@nbd.name>
|
|
---
|
|
|
|
--- a/drivers/net/ethernet/mediatek/Kconfig
|
|
+++ b/drivers/net/ethernet/mediatek/Kconfig
|
|
@@ -18,7 +18,6 @@ config NET_MEDIATEK_SOC
|
|
select PHYLINK
|
|
select DIMLIB
|
|
select PAGE_POOL
|
|
- select PAGE_POOL_STATS
|
|
select PCS_MTK_LYNXI
|
|
select REGMAP_MMIO
|
|
help
|
|
--- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
|
|
+++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
|
|
@@ -4562,6 +4562,7 @@ static int mtk_get_sset_count(struct net
|
|
|
|
static void mtk_ethtool_pp_stats(struct mtk_eth *eth, u64 *data)
|
|
{
|
|
+#ifdef CONFIG_PAGE_POOL_STATS
|
|
struct page_pool_stats stats = {};
|
|
int i;
|
|
|
|
@@ -4574,6 +4575,7 @@ static void mtk_ethtool_pp_stats(struct
|
|
page_pool_get_stats(ring->page_pool, &stats);
|
|
}
|
|
page_pool_ethtool_stats_get(data, &stats);
|
|
+#endif
|
|
}
|
|
|
|
static void mtk_get_ethtool_stats(struct net_device *dev,
|