 52a5344501
			
		
	
	52a5344501
	
	
	
		
			
			The addition of LT_INIT as well as the adjustment of the BUILD_STATIC and addition of the BUILD_SHARED conditionals and their usage to block building of shared objects and adjust the variables for building static libraries is potentially upstream-friendly. The use of a manifest file to keep a list of the objects in each library instead of calling ar is also potentially upstream-friendly. Separate these changes from the macOS-specific hacks. Signed-off-by: Michael Pratt <mcpratt@pm.me> Link: https://github.com/openwrt/openwrt/pull/15690 Signed-off-by: Robert Marko <robimarko@gmail.com>
		
			
				
	
	
		
			184 lines
		
	
	
		
			6.5 KiB
		
	
	
	
		
			Diff
		
	
	
	
	
	
			
		
		
	
	
			184 lines
		
	
	
		
			6.5 KiB
		
	
	
	
		
			Diff
		
	
	
	
	
	
| --- a/configure.ac
 | |
| +++ b/configure.ac
 | |
| @@ -102,6 +102,8 @@ m4_ifdef([AM_PROG_AR], [AM_PROG_AR])
 | |
|  AC_CHECK_TOOL([READELF], [readelf])
 | |
|  AC_CHECK_TOOL([NM], [nm])
 | |
|  
 | |
| +LT_INIT([shared disable-static])
 | |
| +
 | |
|  AC_CACHE_CHECK([whether gcc supports __attribute__((visibility()))],
 | |
|  	ac_cv_visibility, [dnl
 | |
|  save_CFLAGS="$CFLAGS"
 | |
| @@ -419,7 +421,10 @@ AS_HELP_STRING([--enable-install-elfh],[
 | |
|  AM_CONDITIONAL(INSTALL_ELFH, test "$install_elfh" = yes)
 | |
|  
 | |
|  AM_CONDITIONAL(BUILD_STATIC, [dnl
 | |
| -test "$use_gprof" = yes -o "$use_gcov" = yes])
 | |
| +test "$use_gprof" = yes -o "$use_gcov" = yes -o "$enable_static" = yes])
 | |
| +
 | |
| +AM_CONDITIONAL(BUILD_SHARED, [dnl
 | |
| +test "$enable_shared" = yes])
 | |
|  
 | |
|  AC_ARG_ENABLE([tests-rpath],
 | |
|  AS_HELP_STRING([--enable-tests-rpath],[build $ORIGIN-using rpath into tests]),
 | |
| --- a/libelf/Makefile.am
 | |
| +++ b/libelf/Makefile.am
 | |
| @@ -35,8 +35,11 @@ endif
 | |
|  VERSION = 1
 | |
|  
 | |
|  lib_LIBRARIES = libelf.a
 | |
| +if BUILD_SHARED
 | |
|  noinst_LIBRARIES = libelf_pic.a
 | |
|  noinst_DATA = $(noinst_LIBRARIES:_pic.a=.so)
 | |
| +endif
 | |
| +
 | |
|  include_HEADERS = libelf.h gelf.h nlist.h
 | |
|  
 | |
|  noinst_HEADERS = abstract.h common.h exttypes.h gelf_xlate.h libelfP.h \
 | |
| @@ -122,11 +125,15 @@ libelf.so: $(srcdir)/libelf.map $(libelf
 | |
|  	@$(textrel_check)
 | |
|  	$(AM_V_at)ln -fs $@ $@.$(VERSION)
 | |
|  
 | |
| +if BUILD_SHARED
 | |
|  install: install-am libelf.so
 | |
|  	$(mkinstalldirs) $(DESTDIR)$(libdir)
 | |
|  	$(INSTALL_PROGRAM) libelf.so $(DESTDIR)$(libdir)/libelf-$(PACKAGE_VERSION).so
 | |
|  	ln -fs libelf-$(PACKAGE_VERSION).so $(DESTDIR)$(libdir)/libelf.so.$(VERSION)
 | |
|  	ln -fs libelf.so.$(VERSION) $(DESTDIR)$(libdir)/libelf.so
 | |
| +else
 | |
| +libelf_a_LIBADD = $(foreach dep,$(libelf_so_DEPS:.so=.a) $(LIBS:.so=.a),$(if $(findstring a,$(suffix $(dep))),$(addprefix $(dir $(dep)),$(shell cat $(basename $(dep)).manifest)),$(dep)))
 | |
| +endif
 | |
|  
 | |
|  uninstall: uninstall-am
 | |
|  	rm -f $(DESTDIR)$(libdir)/libelf-$(PACKAGE_VERSION).so
 | |
| --- a/libdw/Makefile.am
 | |
| +++ b/libdw/Makefile.am
 | |
| @@ -35,8 +35,10 @@ AM_CPPFLAGS += -I$(srcdir)/../libebl -I$
 | |
|  VERSION = 1
 | |
|  
 | |
|  lib_LIBRARIES = libdw.a
 | |
| +if BUILD_SHARED
 | |
|  noinst_LIBRARIES = libdw_pic.a
 | |
|  noinst_DATA = $(noinst_LIBRARIES:_pic.a=.so)
 | |
| +endif
 | |
|  
 | |
|  include_HEADERS = dwarf.h
 | |
|  pkginclude_HEADERS = libdw.h known-dwarf.h
 | |
| @@ -121,11 +123,13 @@ libdw.so: $(srcdir)/libdw.map $(libdw_so
 | |
|  	@$(textrel_check)
 | |
|  	$(AM_V_at)ln -fs $@ $@.$(VERSION)
 | |
|  
 | |
| +if BUILD_SHARED
 | |
|  install: install-am libdw.so
 | |
|  	$(mkinstalldirs) $(DESTDIR)$(libdir)
 | |
|  	$(INSTALL_PROGRAM) libdw.so $(DESTDIR)$(libdir)/libdw-$(PACKAGE_VERSION).so
 | |
|  	ln -fs libdw-$(PACKAGE_VERSION).so $(DESTDIR)$(libdir)/libdw.so.$(VERSION)
 | |
|  	ln -fs libdw.so.$(VERSION) $(DESTDIR)$(libdir)/libdw.so
 | |
| +endif
 | |
|  
 | |
|  uninstall: uninstall-am
 | |
|  	rm -f $(DESTDIR)$(libdir)/libdw-$(PACKAGE_VERSION).so
 | |
| @@ -148,6 +152,10 @@ libdw_a_LIBADD += $(addprefix ../backend
 | |
|  libcpu_objects = $(shell $(AR) t ../libcpu/libcpu.a)
 | |
|  libdw_a_LIBADD += $(addprefix ../libcpu/,$(libcpu_objects))
 | |
|  
 | |
| +if !BUILD_SHARED
 | |
| +libdw_a_LIBADD += $(foreach dep,$(libdw_so_DEPS:.so=.a) $(LIBS:.so=.a),$(if $(findstring a,$(suffix $(dep))),$(addprefix $(dir $(dep)),$(shell cat $(basename $(dep)).manifest)),$(dep)))
 | |
| +endif
 | |
| +
 | |
|  noinst_HEADERS = libdwP.h memory-access.h dwarf_abbrev_hash.h \
 | |
|  		 dwarf_sig8_hash.h cfi.h encoded-value.h
 | |
|  
 | |
| --- a/libasm/Makefile.am
 | |
| +++ b/libasm/Makefile.am
 | |
| @@ -33,8 +33,11 @@ AM_CPPFLAGS += -I$(top_srcdir)/libelf -I
 | |
|  VERSION = 1
 | |
|  
 | |
|  lib_LIBRARIES = libasm.a
 | |
| +if BUILD_SHARED
 | |
|  noinst_LIBRARIES = libasm_pic.a
 | |
|  noinst_DATA = $(noinst_LIBRARIES:_pic.a=.so)
 | |
| +endif
 | |
| +
 | |
|  pkginclude_HEADERS = libasm.h
 | |
|  
 | |
|  libasm_a_SOURCES = asm_begin.c asm_abort.c asm_end.c asm_error.c \
 | |
| @@ -71,11 +74,15 @@ libasm.so: $(srcdir)/libasm.map $(libasm
 | |
|  	@$(textrel_check)
 | |
|  	$(AM_V_at)ln -fs $@ $@.$(VERSION)
 | |
|  
 | |
| +if BUILD_SHARED
 | |
|  install: install-am libasm.so
 | |
|  	$(mkinstalldirs) $(DESTDIR)$(libdir)
 | |
|  	$(INSTALL_PROGRAM) libasm.so $(DESTDIR)$(libdir)/libasm-$(PACKAGE_VERSION).so
 | |
|  	ln -fs libasm-$(PACKAGE_VERSION).so $(DESTDIR)$(libdir)/libasm.so.$(VERSION)
 | |
|  	ln -fs libasm.so.$(VERSION) $(DESTDIR)$(libdir)/libasm.so
 | |
| +else
 | |
| +libasm_a_LIBADD = $(foreach dep,$(libasm_so_DEPS:.so=.a) $(LIBS:.so=.a),$(if $(findstring a,$(suffix $(dep))),$(addprefix $(dir $(dep)),$(shell cat $(basename $(dep)).manifest)),$(dep)))
 | |
| +endif
 | |
|  
 | |
|  uninstall: uninstall-am
 | |
|  	rm -f $(DESTDIR)$(libdir)/libasm-$(PACKAGE_VERSION).so
 | |
| --- a/debuginfod/Makefile.am
 | |
| +++ b/debuginfod/Makefile.am
 | |
| @@ -77,8 +77,10 @@ debuginfod_find_LDADD = $(libdw) $(libel
 | |
|  
 | |
|  if LIBDEBUGINFOD
 | |
|  noinst_LIBRARIES = libdebuginfod.a
 | |
| +if BUILD_SHARED
 | |
|  noinst_LIBRARIES += libdebuginfod_pic.a
 | |
|  endif
 | |
| +endif
 | |
|  
 | |
|  libdebuginfod_a_SOURCES = debuginfod-client.c
 | |
|  libdebuginfod_pic_a_SOURCES = debuginfod-client.c
 | |
| @@ -111,12 +113,16 @@ $(LIBDEBUGINFOD_SONAME): $(srcdir)/libde
 | |
|  libdebuginfod.so: $(LIBDEBUGINFOD_SONAME)
 | |
|  	ln -fs $< $@
 | |
|  
 | |
| +if BUILD_SHARED
 | |
|  install: install-am libdebuginfod.so
 | |
|  	$(mkinstalldirs) $(DESTDIR)$(libdir)
 | |
|  	$(INSTALL_PROGRAM) $(LIBDEBUGINFOD_SONAME) \
 | |
|  		$(DESTDIR)$(libdir)/libdebuginfod-$(PACKAGE_VERSION).so
 | |
|  	ln -fs libdebuginfod-$(PACKAGE_VERSION).so $(DESTDIR)$(libdir)/$(LIBDEBUGINFOD_SONAME)
 | |
|  	ln -fs libdebuginfod-$(PACKAGE_VERSION).so $(DESTDIR)$(libdir)/libdebuginfod.so
 | |
| +else
 | |
| +libdebuginfod_a_LIBADD = $(foreach dep,$(wildcard $(libdebuginfod_so_LDLIBS:.so=.a)) $(LIBS:.so=.a),$(if $(findstring a,$(suffix $(dep))),$(addprefix $(dir $(dep)),$(shell cat $(basename $(dep)).manifest)),$(dep)))
 | |
| +endif
 | |
|  
 | |
|  uninstall: uninstall-am
 | |
|  	rm -f $(DESTDIR)$(libdir)/libdebuginfod-$(PACKAGE_VERSION).so
 | |
| --- a/tests/Makefile.am
 | |
| +++ b/tests/Makefile.am
 | |
| @@ -50,7 +50,7 @@ check_PROGRAMS = arextract arsymtest new
 | |
|  		  dwfl-report-offline-memory \
 | |
|  		  varlocs backtrace backtrace-child \
 | |
|  		  backtrace-data backtrace-dwarf debuglink debugaltlink \
 | |
| -		  buildid deleted deleted-lib.so aggregate_size peel_type \
 | |
| +		  buildid aggregate_size peel_type \
 | |
|  		  vdsosyms \
 | |
|  		  getsrc_die strptr newdata elfstrtab dwfl-proc-attach \
 | |
|  		  elfshphehdr elfstrmerge dwelfgnucompressed elfgetchdr \
 | |
| @@ -180,7 +180,7 @@ TESTS = run-arextract.sh run-arsymtest.s
 | |
|  	run-readelf-addr.sh run-readelf-str.sh \
 | |
|  	run-readelf-multi-noline.sh \
 | |
|  	run-readelf-types.sh \
 | |
| -	run-readelf-dwz-multi.sh run-allfcts-multi.sh run-deleted.sh \
 | |
| +	run-readelf-dwz-multi.sh run-allfcts-multi.sh \
 | |
|  	run-linkmap-cut.sh run-aggregate-size.sh run-peel-type.sh \
 | |
|  	vdsosyms run-readelf-A.sh \
 | |
|  	run-getsrc-die.sh run-strptr.sh newdata elfstrtab dwfl-proc-attach \
 | |
| @@ -284,6 +284,11 @@ funcretval_test__11_SOURCES = funcretval
 | |
|  TESTS += run-funcretval++11.sh
 | |
|  endif
 | |
|  
 | |
| +if BUILD_SHARED
 | |
| +check_PROGRAMS += deleted deleted-lib.so
 | |
| +TESTS += run-deleted.sh
 | |
| +endif
 | |
| +
 | |
|  EXTRA_DIST = run-arextract.sh run-arsymtest.sh run-ar.sh \
 | |
|  	     run-ar-N.sh \
 | |
|  	     run-show-die-info.sh run-get-files.sh run-get-lines.sh \
 |