27c9d80f51
Some checks failed
Build Kernel / Build all affected Kernels (push) Has been cancelled
Build all core packages / Build all core packages for selected target (push) Has been cancelled
Build and Push prebuilt tools container / Build and Push all prebuilt containers (push) Has been cancelled
Build Toolchains / Build Toolchains for each target (push) Has been cancelled
Build host tools / Build host tools for linux and macos based systems (push) Has been cancelled
Coverity scan build / Coverity x86/64 build (push) Has been cancelled
35 lines
1.2 KiB
Diff
35 lines
1.2 KiB
Diff
From 57da42b46799e865c60ade515c82189e270e5b9e Mon Sep 17 00:00:00 2001
|
|
From: Dave Stevenson <dave.stevenson@raspberrypi.com>
|
|
Date: Fri, 1 Sep 2023 12:17:38 +0100
|
|
Subject: [PATCH 0489/1085] drm/ili9486: Resolve clash in spi_device_id names
|
|
|
|
For "Really Good Reasons" [1] the SPI core requires a match
|
|
between compatible device strings and the name in spi_device_id.
|
|
|
|
The ili9486 driver uses compatible strings "waveshare,rpi-lcd-35"
|
|
and "ozzmaker,piscreen", but "rpi-lcd-35" and "piscreen" are missing,
|
|
so add them.
|
|
|
|
Compatible string "ilitek,ili9486" is already used by
|
|
staging/fbtft/fb_ili9486, therefore leaving it present in ili9486 as an
|
|
spi_device_id causes the incorrect module to be loaded, therefore remove
|
|
this id.
|
|
|
|
[1] https://elixir.bootlin.com/linux/latest/source/drivers/spi/spi.c#L487
|
|
|
|
Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
|
|
---
|
|
drivers/gpu/drm/tiny/ili9486.c | 1 -
|
|
1 file changed, 1 deletion(-)
|
|
|
|
--- a/drivers/gpu/drm/tiny/ili9486.c
|
|
+++ b/drivers/gpu/drm/tiny/ili9486.c
|
|
@@ -188,7 +188,6 @@ static const struct of_device_id ili9486
|
|
MODULE_DEVICE_TABLE(of, ili9486_of_match);
|
|
|
|
static const struct spi_device_id ili9486_id[] = {
|
|
- { "ili9486", 0 },
|
|
{ "rpi-lcd-35", 0 },
|
|
{ "piscreen", 0 },
|
|
{ }
|