27c9d80f51
Some checks failed
Build Kernel / Build all affected Kernels (push) Has been cancelled
Build all core packages / Build all core packages for selected target (push) Has been cancelled
Build and Push prebuilt tools container / Build and Push all prebuilt containers (push) Has been cancelled
Build Toolchains / Build Toolchains for each target (push) Has been cancelled
Build host tools / Build host tools for linux and macos based systems (push) Has been cancelled
Coverity scan build / Coverity x86/64 build (push) Has been cancelled
32 lines
1.1 KiB
Diff
32 lines
1.1 KiB
Diff
From e8fbcc47a8e935f36f044d85f21a99acecbd7bfb Mon Sep 17 00:00:00 2001
|
|
From: Andrew Lunn <andrew@lunn.ch>
|
|
Date: Tue, 8 Aug 2023 23:04:36 +0200
|
|
Subject: [PATCH 4/4] leds: trig-netdev: Disable offload on deactivation of
|
|
trigger
|
|
|
|
Ensure that the offloading of blinking is stopped when the trigger is
|
|
deactivated. Calling led_set_brightness() is documented as stopping
|
|
offload and setting the LED to a constant brightness.
|
|
|
|
Suggested-by: Daniel Golle <daniel@makrotopia.org>
|
|
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
|
|
Reviewed-by: Simon Horman <simon.horman@corigine.com>
|
|
Tested-by: Daniel Golle <daniel@makrotopia.org>
|
|
Link: https://lore.kernel.org/r/20230808210436.838995-5-andrew@lunn.ch
|
|
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
|
|
---
|
|
drivers/leds/trigger/ledtrig-netdev.c | 2 ++
|
|
1 file changed, 2 insertions(+)
|
|
|
|
--- a/drivers/leds/trigger/ledtrig-netdev.c
|
|
+++ b/drivers/leds/trigger/ledtrig-netdev.c
|
|
@@ -595,6 +595,8 @@ static void netdev_trig_deactivate(struc
|
|
|
|
cancel_delayed_work_sync(&trigger_data->work);
|
|
|
|
+ led_set_brightness(led_cdev, LED_OFF);
|
|
+
|
|
dev_put(trigger_data->net_dev);
|
|
|
|
kfree(trigger_data);
|