27c9d80f51
Some checks failed
Build Kernel / Build all affected Kernels (push) Has been cancelled
Build all core packages / Build all core packages for selected target (push) Has been cancelled
Build and Push prebuilt tools container / Build and Push all prebuilt containers (push) Has been cancelled
Build Toolchains / Build Toolchains for each target (push) Has been cancelled
Build host tools / Build host tools for linux and macos based systems (push) Has been cancelled
Coverity scan build / Coverity x86/64 build (push) Has been cancelled
32 lines
1.1 KiB
Diff
32 lines
1.1 KiB
Diff
From 97c5209b3d374a25ebdb4c2ea9e9c1b121768da0 Mon Sep 17 00:00:00 2001
|
|
From: Dan Carpenter <dan.carpenter@linaro.org>
|
|
Date: Wed, 14 Jun 2023 10:03:59 +0300
|
|
Subject: [PATCH] leds: trigger: netdev: uninitialized variable in
|
|
netdev_trig_activate()
|
|
|
|
The qca8k_cled_hw_control_get() function which implements ->hw_control_get
|
|
sets the appropriate bits but does not clear them. This leads to an
|
|
uninitialized variable bug. Fix this by setting mode to zero at the
|
|
start.
|
|
|
|
Fixes: e0256648c831 ("net: dsa: qca8k: implement hw_control ops")
|
|
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
|
|
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
|
|
Acked-by: Lee Jones <lee@kernel.org>
|
|
Signed-off-by: David S. Miller <davem@davemloft.net>
|
|
---
|
|
drivers/leds/trigger/ledtrig-netdev.c | 2 +-
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
|
--- a/drivers/leds/trigger/ledtrig-netdev.c
|
|
+++ b/drivers/leds/trigger/ledtrig-netdev.c
|
|
@@ -538,7 +538,7 @@ static void netdev_trig_work(struct work
|
|
static int netdev_trig_activate(struct led_classdev *led_cdev)
|
|
{
|
|
struct led_netdev_data *trigger_data;
|
|
- unsigned long mode;
|
|
+ unsigned long mode = 0;
|
|
struct device *dev;
|
|
int rc;
|
|
|