From 72e3ae508906553e7bc982bf3c0d99bb1cbe9008 Mon Sep 17 00:00:00 2001 From: Murat Sezgin Date: Wed, 20 Nov 2019 16:23:06 -0800 Subject: [qca-nss-ecm] Fix neighbour solicitation send function. dst_ops->neigh_lookup function pointer is set to the ip6_neigh_lookup function. This function returns an error pointer with the ERR_PTR() macro. So, we should check the return value of this function pointer with the IS_ERR() macro. Change-Id: I188a6e53278faaa68f1854524f612efc1f7451fe Signed-off-by: Murat Sezgin --- ecm_interface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ecm_interface.c b/ecm_interface.c index 3f8554b..36509f0 100644 --- a/ecm_interface.c +++ b/ecm_interface.c @@ -1100,7 +1100,7 @@ void ecm_interface_send_neighbour_solicitation(struct net_device *dev, ip_addr_t #else neigh = rt6i->dst.ops->neigh_lookup(&rt6i->dst, NULL, &dst_addr); #endif - if (neigh == NULL) { + if (IS_ERR(neigh)) { DEBUG_TRACE("Neighbour lookup failure for destination IPv6 address " ECM_IP_ADDR_OCTAL_FMT "\n", ECM_IP_ADDR_TO_OCTAL(addr)); dst_release(&rt6i->dst); return; -- cgit v1.1