c06fb25d1f
Some checks failed
Build Kernel / Build all affected Kernels (push) Has been cancelled
Build all core packages / Build all core packages for selected target (push) Has been cancelled
Build and Push prebuilt tools container / Build and Push all prebuilt containers (push) Has been cancelled
Build Toolchains / Build Toolchains for each target (push) Has been cancelled
Build host tools / Build host tools for linux and macos based systems (push) Has been cancelled
Coverity scan build / Coverity x86/64 build (push) Has been cancelled
46 lines
1.5 KiB
Diff
46 lines
1.5 KiB
Diff
From d6a12dd8f4e9362f7dd355969dd046adc44b1f47 Mon Sep 17 00:00:00 2001
|
|
From: Phil Elwell <phil@raspberrypi.com>
|
|
Date: Mon, 1 Mar 2021 09:12:44 +0000
|
|
Subject: [PATCH 1255/1350] Revert "Bluetooth: Always request for user
|
|
confirmation for Just Works (LE SC)"
|
|
|
|
This reverts commit ffee202a78c2980688bc5d2f7d56480e69a5e0c9.
|
|
|
|
The commit "Bluetooth: Always request for user confirmation for Just
|
|
Works" prevents BLE devices pairing in (at least) the Raspberry Pi OS
|
|
GUI. After reverting it, pairing works again. Although this companion
|
|
commit ("... (LE SC)") has not been demonstrated to be problematic,
|
|
it follows the same logic and therefore could affect some use cases.
|
|
|
|
If another solution to the problem is found then this reversion will
|
|
be removed.
|
|
|
|
See: https://github.com/raspberrypi/linux/issues/4139
|
|
|
|
Signed-off-by: Phil Elwell <phil@raspberrypi.com>
|
|
---
|
|
net/bluetooth/smp.c | 5 +----
|
|
1 file changed, 1 insertion(+), 4 deletions(-)
|
|
|
|
--- a/net/bluetooth/smp.c
|
|
+++ b/net/bluetooth/smp.c
|
|
@@ -2208,7 +2208,7 @@ mackey_and_ltk:
|
|
if (err)
|
|
return SMP_UNSPECIFIED;
|
|
|
|
- if (smp->method == REQ_OOB) {
|
|
+ if (smp->method == JUST_WORKS || smp->method == REQ_OOB) {
|
|
if (test_bit(SMP_FLAG_INITIATOR, &smp->flags)) {
|
|
sc_dhkey_check(smp);
|
|
SMP_ALLOW_CMD(smp, SMP_CMD_DHKEY_CHECK);
|
|
@@ -2223,9 +2223,6 @@ mackey_and_ltk:
|
|
confirm_hint = 0;
|
|
|
|
confirm:
|
|
- if (smp->method == JUST_WORKS)
|
|
- confirm_hint = 1;
|
|
-
|
|
err = mgmt_user_confirm_request(hcon->hdev, &hcon->dst, hcon->type,
|
|
hcon->dst_type, passkey, confirm_hint);
|
|
if (err)
|