c06fb25d1f
Some checks failed
Build Kernel / Build all affected Kernels (push) Has been cancelled
Build all core packages / Build all core packages for selected target (push) Has been cancelled
Build and Push prebuilt tools container / Build and Push all prebuilt containers (push) Has been cancelled
Build Toolchains / Build Toolchains for each target (push) Has been cancelled
Build host tools / Build host tools for linux and macos based systems (push) Has been cancelled
Coverity scan build / Coverity x86/64 build (push) Has been cancelled
42 lines
1.6 KiB
Diff
42 lines
1.6 KiB
Diff
From 127532cd0f060ebc3c4cbca81b6438728ad5896e Mon Sep 17 00:00:00 2001
|
|
From: Heiner Kallweit <hkallweit1@gmail.com>
|
|
Date: Mon, 27 Nov 2023 18:20:11 +0100
|
|
Subject: [PATCH] r8169: improve handling task scheduling
|
|
|
|
If we know that the task is going to be a no-op, don't even schedule it.
|
|
And remove the check for netif_running() in the worker function, the
|
|
check for flag RTL_FLAG_TASK_ENABLED is sufficient. Note that we can't
|
|
remove the check for flag RTL_FLAG_TASK_ENABLED in the worker function
|
|
because we have no guarantee when it will be executed.
|
|
|
|
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
|
|
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
|
|
Link: https://lore.kernel.org/r/c65873a3-7394-4107-99a7-83f20030779c@gmail.com
|
|
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
|
|
---
|
|
drivers/net/ethernet/realtek/r8169_main.c | 6 ++++--
|
|
1 file changed, 4 insertions(+), 2 deletions(-)
|
|
|
|
--- a/drivers/net/ethernet/realtek/r8169_main.c
|
|
+++ b/drivers/net/ethernet/realtek/r8169_main.c
|
|
@@ -2279,6 +2279,9 @@ u16 rtl8168h_2_get_adc_bias_ioffset(stru
|
|
|
|
static void rtl_schedule_task(struct rtl8169_private *tp, enum rtl_flag flag)
|
|
{
|
|
+ if (!test_bit(RTL_FLAG_TASK_ENABLED, tp->wk.flags))
|
|
+ return;
|
|
+
|
|
set_bit(flag, tp->wk.flags);
|
|
schedule_work(&tp->wk.work);
|
|
}
|
|
@@ -4526,8 +4529,7 @@ static void rtl_task(struct work_struct
|
|
|
|
rtnl_lock();
|
|
|
|
- if (!netif_running(tp->dev) ||
|
|
- !test_bit(RTL_FLAG_TASK_ENABLED, tp->wk.flags))
|
|
+ if (!test_bit(RTL_FLAG_TASK_ENABLED, tp->wk.flags))
|
|
goto out_unlock;
|
|
|
|
if (test_and_clear_bit(RTL_FLAG_TASK_TX_TIMEOUT, tp->wk.flags)) {
|