 c06fb25d1f
			
		
	
	c06fb25d1f
	
	
		
			
	
		
	
	
		
			Some checks failed
		
		
	
	Build Kernel / Build all affected Kernels (push) Has been cancelled
				
			Build all core packages / Build all core packages for selected target (push) Has been cancelled
				
			Build and Push prebuilt tools container / Build and Push all prebuilt containers (push) Has been cancelled
				
			Build Toolchains / Build Toolchains for each target (push) Has been cancelled
				
			Build host tools / Build host tools for linux and macos based systems (push) Has been cancelled
				
			Coverity scan build / Coverity x86/64 build (push) Has been cancelled
				
			
		
			
				
	
	
		
			52 lines
		
	
	
		
			2.1 KiB
		
	
	
	
		
			Diff
		
	
	
	
	
	
			
		
		
	
	
			52 lines
		
	
	
		
			2.1 KiB
		
	
	
	
		
			Diff
		
	
	
	
	
	
| From a7a94ca21ac0f347f683d33c72b4aab57ce5eec3 Mon Sep 17 00:00:00 2001
 | |
| From: Florian Eckert <fe@dev.tdt.de>
 | |
| Date: Mon, 20 Nov 2023 11:13:20 +0100
 | |
| Subject: [PATCH] tools/thermal/tmon: Fix compilation warning for wrong format
 | |
| 
 | |
| The following warnings are shown during compilation:
 | |
| 
 | |
| tui.c: In function 'show_cooling_device':
 | |
|  tui.c:216:40: warning: format '%d' expects argument of type 'int', but
 | |
| argument 7 has type 'long unsigned int' [-Wformat=]
 | |
|    216 |                         "%02d %12.12s%6d %6d",
 | |
|        |                                      ~~^
 | |
|        |                                        |
 | |
|        |                                        int
 | |
|        |                                      %6ld
 | |
|  ......
 | |
|    219 |                         ptdata.cdi[j].cur_state,
 | |
|        |                         ~~~~~~~~~~~~~~~~~~~~~~~
 | |
|        |                                      |
 | |
|        |                                      long unsigned int
 | |
|  tui.c:216:44: warning: format '%d' expects argument of type 'int', but
 | |
| argument 8 has type 'long unsigned int' [-Wformat=]
 | |
|    216 |                         "%02d %12.12s%6d %6d",
 | |
|        |                                          ~~^
 | |
|        |                                            |
 | |
|        |                                            int
 | |
|        |                                          %6ld
 | |
|  ......
 | |
|    220 |                         ptdata.cdi[j].max_state);
 | |
|        |                         ~~~~~~~~~~~~~~~~~~~~~~~
 | |
|        |                                      |
 | |
|        |                                      long unsigned int
 | |
| 
 | |
| To fix this, the correct string format must be used for printing.
 | |
| 
 | |
| Signed-off-by: Florian Eckert <fe@dev.tdt.de>
 | |
| ---
 | |
|  tools/thermal/tmon/tui.c | 2 +-
 | |
|  1 file changed, 1 insertion(+), 1 deletion(-)
 | |
| 
 | |
| --- a/tools/thermal/tmon/tui.c
 | |
| +++ b/tools/thermal/tmon/tui.c
 | |
| @@ -213,7 +213,7 @@ void show_cooling_device(void)
 | |
|  		 * cooling device instances. skip unused idr.
 | |
|  		 */
 | |
|  		mvwprintw(cooling_device_window, j + 2, 1,
 | |
| -			"%02d %12.12s%6d %6d",
 | |
| +			"%02d %12.12s%6lu %6lu",
 | |
|  			ptdata.cdi[j].instance,
 | |
|  			ptdata.cdi[j].type,
 | |
|  			ptdata.cdi[j].cur_state,
 |