c06fb25d1f
Some checks failed
Build Kernel / Build all affected Kernels (push) Has been cancelled
Build all core packages / Build all core packages for selected target (push) Has been cancelled
Build and Push prebuilt tools container / Build and Push all prebuilt containers (push) Has been cancelled
Build Toolchains / Build Toolchains for each target (push) Has been cancelled
Build host tools / Build host tools for linux and macos based systems (push) Has been cancelled
Coverity scan build / Coverity x86/64 build (push) Has been cancelled
28 lines
961 B
Diff
28 lines
961 B
Diff
From 3a767b482cacd9bfeac786837fcac419af315995 Mon Sep 17 00:00:00 2001
|
|
From: Heiner Kallweit <hkallweit1@gmail.com>
|
|
Date: Thu, 23 Nov 2023 10:53:26 +0100
|
|
Subject: [PATCH] r8169: remove not needed check in rtl_fw_write_firmware
|
|
|
|
This check can never be true for a firmware file with a correct format.
|
|
Existing checks in rtl_fw_data_ok() are sufficient, no problems with
|
|
invalid firmware files are known.
|
|
|
|
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
|
|
Signed-off-by: David S. Miller <davem@davemloft.net>
|
|
---
|
|
drivers/net/ethernet/realtek/r8169_firmware.c | 3 ---
|
|
1 file changed, 3 deletions(-)
|
|
|
|
--- a/drivers/net/ethernet/realtek/r8169_firmware.c
|
|
+++ b/drivers/net/ethernet/realtek/r8169_firmware.c
|
|
@@ -151,9 +151,6 @@ void rtl_fw_write_firmware(struct rtl816
|
|
u32 regno = (action & 0x0fff0000) >> 16;
|
|
enum rtl_fw_opcode opcode = action >> 28;
|
|
|
|
- if (!action)
|
|
- break;
|
|
-
|
|
switch (opcode) {
|
|
case PHY_READ:
|
|
predata = fw_read(tp, regno);
|