ramips: remove bogus ralink,mtd-eeprom with offset 0x4
Several devices in mt76x8 subtarget use the following line to set up wmac in their DTS(I) files: ralink,mtd-eeprom = <&factory 0x4> This is strange for several reasons: - They should use mediatek,mtd-eeprom on this SOC - The caldata is supposed to start at 0x0 - The parent DTSI mt7628an.dtsi specifies mediatek,mtd-eeprom anyway, starting from 0x0 - The offset coincides with the default location of the MAC address in caldata Based on the comment inb28e94d4bf("ramips: MiWiFi Nano fixes"), it looks like the author for this device wanted to actually use mtd-mac-address instead of ralink,mtd-eeprom. A check on the same device revealed that actually the MAC address start at offset 4 there, so the correct caldata offset is 0x0. Based on these findings, and the fact that the expected location on this SOC is 0x0, we remove the "ralink,mtd-eeprom = <&factory 0x4>" statement from all devices in ramips (being only mt7628an anyway). Thanks to Sungbo Eo for finding and researching this. Reported-by: Sungbo Eo <mans0n@gorani.run> Fixes:b28e94d4bf("ramips: MiWiFi Nano fixes") Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de>
This commit is contained in:
		| @@ -132,7 +132,6 @@ | |||||||
|  |  | ||||||
| &wmac { | &wmac { | ||||||
| 	status = "okay"; | 	status = "okay"; | ||||||
| 	ralink,mtd-eeprom = <&factory 0x4>; |  | ||||||
| }; | }; | ||||||
|  |  | ||||||
| ðernet { | ðernet { | ||||||
|   | |||||||
| @@ -93,5 +93,4 @@ | |||||||
|  |  | ||||||
| &wmac { | &wmac { | ||||||
| 	status = "okay"; | 	status = "okay"; | ||||||
| 	ralink,mtd-eeprom = <&factory 0x4>; |  | ||||||
| }; | }; | ||||||
|   | |||||||
| @@ -108,7 +108,6 @@ | |||||||
|  |  | ||||||
| &wmac { | &wmac { | ||||||
| 	status = "okay"; | 	status = "okay"; | ||||||
| 	ralink,mtd-eeprom = <&factory 0x4>; |  | ||||||
| }; | }; | ||||||
|  |  | ||||||
| ðernet { | ðernet { | ||||||
|   | |||||||
| @@ -21,7 +21,6 @@ | |||||||
|  |  | ||||||
| &wmac { | &wmac { | ||||||
| 	status = "okay"; | 	status = "okay"; | ||||||
| 	ralink,mtd-eeprom = <&factory 0x4>; |  | ||||||
| }; | }; | ||||||
|  |  | ||||||
| ðernet { | ðernet { | ||||||
|   | |||||||
| @@ -68,7 +68,6 @@ | |||||||
|  |  | ||||||
| &wmac { | &wmac { | ||||||
| 	status = "okay"; | 	status = "okay"; | ||||||
| 	ralink,mtd-eeprom = <&factory 0x4>; |  | ||||||
| }; | }; | ||||||
|  |  | ||||||
| ðernet { | ðernet { | ||||||
|   | |||||||
| @@ -103,7 +103,6 @@ | |||||||
|  |  | ||||||
| &wmac { | &wmac { | ||||||
| 	status = "okay"; | 	status = "okay"; | ||||||
| 	ralink,mtd-eeprom = <&factory 0x4>; |  | ||||||
| }; | }; | ||||||
|  |  | ||||||
| ðernet { | ðernet { | ||||||
|   | |||||||
| @@ -134,7 +134,7 @@ ramips_setup_macs() | |||||||
| 		;; | 		;; | ||||||
| 	cudy,wr1000) | 	cudy,wr1000) | ||||||
| 		wan_mac=$(mtd_get_mac_binary factory 0x2e) | 		wan_mac=$(mtd_get_mac_binary factory 0x2e) | ||||||
| 		label_mac=$(mtd_get_mac_binary factory 0x8) | 		label_mac=$(mtd_get_mac_binary factory 0x4) | ||||||
| 		;; | 		;; | ||||||
| 	duzun,dm06|\ | 	duzun,dm06|\ | ||||||
| 	netgear,r6120|\ | 	netgear,r6120|\ | ||||||
| @@ -193,7 +193,7 @@ ramips_setup_macs() | |||||||
| 		;; | 		;; | ||||||
| 	vocore,vocore2|\ | 	vocore,vocore2|\ | ||||||
| 	vocore,vocore2-lite) | 	vocore,vocore2-lite) | ||||||
| 		label_mac=$(mtd_get_mac_binary factory 0x8) | 		label_mac=$(mtd_get_mac_binary factory 0x4) | ||||||
| 		;; | 		;; | ||||||
| 	wavlink,wl-wn570ha1|\ | 	wavlink,wl-wn570ha1|\ | ||||||
| 	zbtlink,zbt-we1226) | 	zbtlink,zbt-we1226) | ||||||
|   | |||||||
		Reference in New Issue
	
	Block a user
	 Adrian Schmutzler
					Adrian Schmutzler