kernel: backport mtd patch adding of_platform_populate() calls
This is required for non-parser drivers handling MTD devices. Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
This commit is contained in:
		| @@ -10,7 +10,7 @@ Signed-off-by: Abhimanyu Vishwakarma <Abhimanyu.Vishwakarma@imgtec.com> | ||||
|  | ||||
| --- a/drivers/mtd/spi-nor/core.c | ||||
| +++ b/drivers/mtd/spi-nor/core.c | ||||
| @@ -3156,6 +3156,7 @@ int spi_nor_scan(struct spi_nor *nor, co | ||||
| @@ -3141,6 +3141,7 @@ int spi_nor_scan(struct spi_nor *nor, co | ||||
|  	struct device *dev = nor->dev; | ||||
|  	struct mtd_info *mtd = &nor->mtd; | ||||
|  	struct device_node *np = spi_nor_get_flash_node(nor); | ||||
| @@ -18,7 +18,7 @@ Signed-off-by: Abhimanyu Vishwakarma <Abhimanyu.Vishwakarma@imgtec.com> | ||||
|  	int ret; | ||||
|  	int i; | ||||
|   | ||||
| @@ -3210,7 +3211,12 @@ int spi_nor_scan(struct spi_nor *nor, co | ||||
| @@ -3195,7 +3196,12 @@ int spi_nor_scan(struct spi_nor *nor, co | ||||
|  	if (ret) | ||||
|  		return ret; | ||||
|   | ||||
| @@ -34,7 +34,7 @@ Signed-off-by: Abhimanyu Vishwakarma <Abhimanyu.Vishwakarma@imgtec.com> | ||||
|  	mtd->type = MTD_NORFLASH; | ||||
| --- a/drivers/mtd/mtdcore.c | ||||
| +++ b/drivers/mtd/mtdcore.c | ||||
| @@ -778,6 +778,17 @@ out_error: | ||||
| @@ -788,6 +788,17 @@ out_error: | ||||
|   */ | ||||
|  static void mtd_set_dev_defaults(struct mtd_info *mtd) | ||||
|  { | ||||
|   | ||||
| @@ -10,7 +10,7 @@ Signed-off-by: Abhimanyu Vishwakarma <Abhimanyu.Vishwakarma@imgtec.com> | ||||
|  | ||||
| --- a/drivers/mtd/spi-nor/core.c | ||||
| +++ b/drivers/mtd/spi-nor/core.c | ||||
| @@ -3110,6 +3110,7 @@ int spi_nor_scan(struct spi_nor *nor, co | ||||
| @@ -3095,6 +3095,7 @@ int spi_nor_scan(struct spi_nor *nor, co | ||||
|  	struct device *dev = nor->dev; | ||||
|  	struct mtd_info *mtd = &nor->mtd; | ||||
|  	struct device_node *np = spi_nor_get_flash_node(nor); | ||||
| @@ -18,7 +18,7 @@ Signed-off-by: Abhimanyu Vishwakarma <Abhimanyu.Vishwakarma@imgtec.com> | ||||
|  	int ret; | ||||
|  	int i; | ||||
|   | ||||
| @@ -3164,7 +3165,12 @@ int spi_nor_scan(struct spi_nor *nor, co | ||||
| @@ -3149,7 +3150,12 @@ int spi_nor_scan(struct spi_nor *nor, co | ||||
|  	if (ret) | ||||
|  		return ret; | ||||
|   | ||||
| @@ -34,7 +34,7 @@ Signed-off-by: Abhimanyu Vishwakarma <Abhimanyu.Vishwakarma@imgtec.com> | ||||
|  	mtd->type = MTD_NORFLASH; | ||||
| --- a/drivers/mtd/mtdcore.c | ||||
| +++ b/drivers/mtd/mtdcore.c | ||||
| @@ -778,6 +778,17 @@ out_error: | ||||
| @@ -788,6 +788,17 @@ out_error: | ||||
|   */ | ||||
|  static void mtd_set_dev_defaults(struct mtd_info *mtd) | ||||
|  { | ||||
|   | ||||
| @@ -0,0 +1,72 @@ | ||||
| From bcdf0315a61a29eb753a607d3a85a4032de72d94 Mon Sep 17 00:00:00 2001 | ||||
| From: =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= <rafal@milecki.pl> | ||||
| Date: Tue, 10 May 2022 15:12:59 +0200 | ||||
| Subject: [PATCH] mtd: call of_platform_populate() for MTD partitions | ||||
| MIME-Version: 1.0 | ||||
| Content-Type: text/plain; charset=UTF-8 | ||||
| Content-Transfer-Encoding: 8bit | ||||
|  | ||||
| Until this change MTD subsystem supported handling partitions only with | ||||
| MTD partitions parsers. That's a specific / limited API designed around | ||||
| partitions. | ||||
|  | ||||
| Some MTD partitions may however require different handling. They may | ||||
| contain specific data that needs to be parsed and somehow extracted. For | ||||
| that purpose MTD subsystem should allow binding of standard platform | ||||
| drivers. | ||||
|  | ||||
| An example can be U-Boot (sub)partition with environment variables. | ||||
| There exist a "u-boot,env" DT binding for MTD (sub)partition that | ||||
| requires an NVMEM driver. | ||||
|  | ||||
| Ref: 5db1c2dbc04c ("dt-bindings: nvmem: add U-Boot environment variables binding") | ||||
| Signed-off-by: Rafał Miłecki <rafal@milecki.pl> | ||||
| Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> | ||||
| Link: https://lore.kernel.org/linux-mtd/20220510131259.555-1-zajec5@gmail.com | ||||
| --- | ||||
|  drivers/mtd/mtdpart.c | 9 +++++++++ | ||||
|  1 file changed, 9 insertions(+) | ||||
|  | ||||
| --- a/drivers/mtd/mtdpart.c | ||||
| +++ b/drivers/mtd/mtdpart.c | ||||
| @@ -17,6 +17,7 @@ | ||||
|  #include <linux/mtd/partitions.h> | ||||
|  #include <linux/err.h> | ||||
|  #include <linux/of.h> | ||||
| +#include <linux/of_platform.h> | ||||
|   | ||||
|  #include "mtdcore.h" | ||||
|   | ||||
| @@ -578,10 +579,16 @@ static int mtd_part_of_parse(struct mtd_ | ||||
|  	struct mtd_part_parser *parser; | ||||
|  	struct device_node *np; | ||||
|  	struct property *prop; | ||||
| +	struct device *dev; | ||||
|  	const char *compat; | ||||
|  	const char *fixed = "fixed-partitions"; | ||||
|  	int ret, err = 0; | ||||
|   | ||||
| +	dev = &master->dev; | ||||
| +	/* Use parent device (controller) if the top level MTD is not registered */ | ||||
| +	if (!IS_ENABLED(CONFIG_MTD_PARTITIONED_MASTER) && !mtd_is_partition(master)) | ||||
| +		dev = master->dev.parent; | ||||
| + | ||||
|  	np = mtd_get_of_node(master); | ||||
|  	if (mtd_is_partition(master)) | ||||
|  		of_node_get(np); | ||||
| @@ -594,6 +601,7 @@ static int mtd_part_of_parse(struct mtd_ | ||||
|  			continue; | ||||
|  		ret = mtd_part_do_parse(parser, master, pparts, NULL); | ||||
|  		if (ret > 0) { | ||||
| +			of_platform_populate(np, NULL, NULL, dev); | ||||
|  			of_node_put(np); | ||||
|  			return ret; | ||||
|  		} | ||||
| @@ -601,6 +609,7 @@ static int mtd_part_of_parse(struct mtd_ | ||||
|  		if (ret < 0 && !err) | ||||
|  			err = ret; | ||||
|  	} | ||||
| +	of_platform_populate(np, NULL, NULL, dev); | ||||
|  	of_node_put(np); | ||||
|   | ||||
|  	/* | ||||
| @@ -0,0 +1,72 @@ | ||||
| From bcdf0315a61a29eb753a607d3a85a4032de72d94 Mon Sep 17 00:00:00 2001 | ||||
| From: =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= <rafal@milecki.pl> | ||||
| Date: Tue, 10 May 2022 15:12:59 +0200 | ||||
| Subject: [PATCH] mtd: call of_platform_populate() for MTD partitions | ||||
| MIME-Version: 1.0 | ||||
| Content-Type: text/plain; charset=UTF-8 | ||||
| Content-Transfer-Encoding: 8bit | ||||
|  | ||||
| Until this change MTD subsystem supported handling partitions only with | ||||
| MTD partitions parsers. That's a specific / limited API designed around | ||||
| partitions. | ||||
|  | ||||
| Some MTD partitions may however require different handling. They may | ||||
| contain specific data that needs to be parsed and somehow extracted. For | ||||
| that purpose MTD subsystem should allow binding of standard platform | ||||
| drivers. | ||||
|  | ||||
| An example can be U-Boot (sub)partition with environment variables. | ||||
| There exist a "u-boot,env" DT binding for MTD (sub)partition that | ||||
| requires an NVMEM driver. | ||||
|  | ||||
| Ref: 5db1c2dbc04c ("dt-bindings: nvmem: add U-Boot environment variables binding") | ||||
| Signed-off-by: Rafał Miłecki <rafal@milecki.pl> | ||||
| Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> | ||||
| Link: https://lore.kernel.org/linux-mtd/20220510131259.555-1-zajec5@gmail.com | ||||
| --- | ||||
|  drivers/mtd/mtdpart.c | 9 +++++++++ | ||||
|  1 file changed, 9 insertions(+) | ||||
|  | ||||
| --- a/drivers/mtd/mtdpart.c | ||||
| +++ b/drivers/mtd/mtdpart.c | ||||
| @@ -17,6 +17,7 @@ | ||||
|  #include <linux/mtd/partitions.h> | ||||
|  #include <linux/err.h> | ||||
|  #include <linux/of.h> | ||||
| +#include <linux/of_platform.h> | ||||
|   | ||||
|  #include "mtdcore.h" | ||||
|   | ||||
| @@ -577,10 +578,16 @@ static int mtd_part_of_parse(struct mtd_ | ||||
|  	struct mtd_part_parser *parser; | ||||
|  	struct device_node *np; | ||||
|  	struct property *prop; | ||||
| +	struct device *dev; | ||||
|  	const char *compat; | ||||
|  	const char *fixed = "fixed-partitions"; | ||||
|  	int ret, err = 0; | ||||
|   | ||||
| +	dev = &master->dev; | ||||
| +	/* Use parent device (controller) if the top level MTD is not registered */ | ||||
| +	if (!IS_ENABLED(CONFIG_MTD_PARTITIONED_MASTER) && !mtd_is_partition(master)) | ||||
| +		dev = master->dev.parent; | ||||
| + | ||||
|  	np = mtd_get_of_node(master); | ||||
|  	if (mtd_is_partition(master)) | ||||
|  		of_node_get(np); | ||||
| @@ -593,6 +600,7 @@ static int mtd_part_of_parse(struct mtd_ | ||||
|  			continue; | ||||
|  		ret = mtd_part_do_parse(parser, master, pparts, NULL); | ||||
|  		if (ret > 0) { | ||||
| +			of_platform_populate(np, NULL, NULL, dev); | ||||
|  			of_node_put(np); | ||||
|  			return ret; | ||||
|  		} | ||||
| @@ -600,6 +608,7 @@ static int mtd_part_of_parse(struct mtd_ | ||||
|  		if (ret < 0 && !err) | ||||
|  			err = ret; | ||||
|  	} | ||||
| +	of_platform_populate(np, NULL, NULL, dev); | ||||
|  	of_node_put(np); | ||||
|   | ||||
|  	/* | ||||
| @@ -77,7 +77,7 @@ Signed-off-by: Daniel Golle <daniel@makrotopia.org> | ||||
|   | ||||
|  #include "mtdcore.h" | ||||
|   | ||||
| @@ -851,6 +852,8 @@ int mtd_device_parse_register(struct mtd | ||||
| @@ -861,6 +862,8 @@ int mtd_device_parse_register(struct mtd | ||||
|  		register_reboot_notifier(&mtd->reboot_notifier); | ||||
|  	} | ||||
|   | ||||
|   | ||||
| @@ -20,7 +20,7 @@ Signed-off-by: Gabor Juhos <juhosg@openwrt.org> | ||||
|  #include <linux/nvmem-provider.h> | ||||
|   | ||||
|  #include <linux/mtd/mtd.h> | ||||
| @@ -694,6 +695,19 @@ int add_mtd_device(struct mtd_info *mtd) | ||||
| @@ -704,6 +705,19 @@ int add_mtd_device(struct mtd_info *mtd) | ||||
|  	   of this try_ nonsense, and no bitching about it | ||||
|  	   either. :) */ | ||||
|  	__module_get(THIS_MODULE); | ||||
|   | ||||
| @@ -28,20 +28,21 @@ | ||||
|  	depends on m | ||||
| --- a/drivers/mtd/mtdpart.c | ||||
| +++ b/drivers/mtd/mtdpart.c | ||||
| @@ -15,10 +15,12 @@ | ||||
| @@ -15,11 +15,13 @@ | ||||
|  #include <linux/kmod.h> | ||||
|  #include <linux/mtd/mtd.h> | ||||
|  #include <linux/mtd/partitions.h> | ||||
| +#include <linux/magic.h> | ||||
|  #include <linux/err.h> | ||||
|  #include <linux/of.h> | ||||
|  #include <linux/of_platform.h> | ||||
|   | ||||
|  #include "mtdcore.h" | ||||
| +#include "mtdsplit/mtdsplit.h" | ||||
|   | ||||
|  /* | ||||
|   * MTD methods which simply translate the effective address and pass through | ||||
| @@ -236,6 +238,146 @@ static int mtd_add_partition_attrs(struc | ||||
| @@ -237,6 +239,146 @@ static int mtd_add_partition_attrs(struc | ||||
|  	return ret; | ||||
|  } | ||||
|   | ||||
| @@ -188,7 +189,7 @@ | ||||
|  int mtd_add_partition(struct mtd_info *parent, const char *name, | ||||
|  		      long long offset, long long length) | ||||
|  { | ||||
| @@ -274,6 +416,7 @@ int mtd_add_partition(struct mtd_info *p | ||||
| @@ -275,6 +417,7 @@ int mtd_add_partition(struct mtd_info *p | ||||
|  	if (ret) | ||||
|  		goto err_remove_part; | ||||
|   | ||||
| @@ -196,7 +197,7 @@ | ||||
|  	mtd_add_partition_attrs(child); | ||||
|   | ||||
|  	return 0; | ||||
| @@ -422,6 +565,7 @@ int add_mtd_partitions(struct mtd_info * | ||||
| @@ -423,6 +566,7 @@ int add_mtd_partitions(struct mtd_info * | ||||
|  			goto err_del_partitions; | ||||
|  		} | ||||
|   | ||||
| @@ -204,7 +205,7 @@ | ||||
|  		mtd_add_partition_attrs(child); | ||||
|   | ||||
|  		/* Look for subpartitions */ | ||||
| @@ -438,31 +582,6 @@ err_del_partitions: | ||||
| @@ -439,31 +583,6 @@ err_del_partitions: | ||||
|  	return ret; | ||||
|  } | ||||
|   | ||||
|   | ||||
| @@ -106,7 +106,7 @@ Reported-by: Dan Carpenter <dan.carpenter@oracle.com> | ||||
|  	&dev_attr_oobsize.attr, | ||||
| --- a/drivers/mtd/mtdpart.c | ||||
| +++ b/drivers/mtd/mtdpart.c | ||||
| @@ -40,6 +40,7 @@ static struct mtd_info *allocate_partiti | ||||
| @@ -41,6 +41,7 @@ static struct mtd_info *allocate_partiti | ||||
|  	struct mtd_info *master = mtd_get_master(parent); | ||||
|  	int wr_alignment = (parent->flags & MTD_NO_ERASE) ? | ||||
|  			   master->writesize : master->erasesize; | ||||
| @@ -114,7 +114,7 @@ Reported-by: Dan Carpenter <dan.carpenter@oracle.com> | ||||
|  	u64 parent_size = mtd_is_partition(parent) ? | ||||
|  			  parent->part.size : parent->size; | ||||
|  	struct mtd_info *child; | ||||
| @@ -164,6 +165,7 @@ static struct mtd_info *allocate_partiti | ||||
| @@ -165,6 +166,7 @@ static struct mtd_info *allocate_partiti | ||||
|  	} else { | ||||
|  		/* Single erase size */ | ||||
|  		child->erasesize = master->erasesize; | ||||
| @@ -122,7 +122,7 @@ Reported-by: Dan Carpenter <dan.carpenter@oracle.com> | ||||
|  	} | ||||
|   | ||||
|  	/* | ||||
| @@ -171,26 +173,39 @@ static struct mtd_info *allocate_partiti | ||||
| @@ -172,26 +174,39 @@ static struct mtd_info *allocate_partiti | ||||
|  	 * exposes several regions with different erasesize. Adjust | ||||
|  	 * wr_alignment accordingly. | ||||
|  	 */ | ||||
|   | ||||
| @@ -17,7 +17,7 @@ Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com> | ||||
|  | ||||
| --- a/drivers/mtd/mtdcore.c | ||||
| +++ b/drivers/mtd/mtdcore.c | ||||
| @@ -1046,6 +1046,44 @@ out_unlock: | ||||
| @@ -1056,6 +1056,44 @@ out_unlock: | ||||
|  } | ||||
|  EXPORT_SYMBOL_GPL(get_mtd_device_nm); | ||||
|   | ||||
|   | ||||
| @@ -28,20 +28,21 @@ | ||||
|  	depends on m | ||||
| --- a/drivers/mtd/mtdpart.c | ||||
| +++ b/drivers/mtd/mtdpart.c | ||||
| @@ -15,10 +15,12 @@ | ||||
| @@ -15,11 +15,13 @@ | ||||
|  #include <linux/kmod.h> | ||||
|  #include <linux/mtd/mtd.h> | ||||
|  #include <linux/mtd/partitions.h> | ||||
| +#include <linux/magic.h> | ||||
|  #include <linux/err.h> | ||||
|  #include <linux/of.h> | ||||
|  #include <linux/of_platform.h> | ||||
|   | ||||
|  #include "mtdcore.h" | ||||
| +#include "mtdsplit/mtdsplit.h" | ||||
|   | ||||
|  /* | ||||
|   * MTD methods which simply translate the effective address and pass through | ||||
| @@ -235,6 +237,146 @@ static int mtd_add_partition_attrs(struc | ||||
| @@ -236,6 +238,146 @@ static int mtd_add_partition_attrs(struc | ||||
|  	return ret; | ||||
|  } | ||||
|   | ||||
| @@ -188,7 +189,7 @@ | ||||
|  int mtd_add_partition(struct mtd_info *parent, const char *name, | ||||
|  		      long long offset, long long length) | ||||
|  { | ||||
| @@ -273,6 +415,7 @@ int mtd_add_partition(struct mtd_info *p | ||||
| @@ -274,6 +416,7 @@ int mtd_add_partition(struct mtd_info *p | ||||
|  	if (ret) | ||||
|  		goto err_remove_part; | ||||
|   | ||||
| @@ -196,7 +197,7 @@ | ||||
|  	mtd_add_partition_attrs(child); | ||||
|   | ||||
|  	return 0; | ||||
| @@ -421,6 +564,7 @@ int add_mtd_partitions(struct mtd_info * | ||||
| @@ -422,6 +565,7 @@ int add_mtd_partitions(struct mtd_info * | ||||
|  			goto err_del_partitions; | ||||
|  		} | ||||
|   | ||||
| @@ -204,7 +205,7 @@ | ||||
|  		mtd_add_partition_attrs(child); | ||||
|   | ||||
|  		/* Look for subpartitions */ | ||||
| @@ -437,31 +581,6 @@ err_del_partitions: | ||||
| @@ -438,31 +582,6 @@ err_del_partitions: | ||||
|  	return ret; | ||||
|  } | ||||
|   | ||||
|   | ||||
| @@ -106,7 +106,7 @@ Reported-by: Dan Carpenter <dan.carpenter@oracle.com> | ||||
|  	&dev_attr_oobsize.attr, | ||||
| --- a/drivers/mtd/mtdpart.c | ||||
| +++ b/drivers/mtd/mtdpart.c | ||||
| @@ -40,6 +40,7 @@ static struct mtd_info *allocate_partiti | ||||
| @@ -41,6 +41,7 @@ static struct mtd_info *allocate_partiti | ||||
|  	struct mtd_info *master = mtd_get_master(parent); | ||||
|  	int wr_alignment = (parent->flags & MTD_NO_ERASE) ? | ||||
|  			   master->writesize : master->erasesize; | ||||
| @@ -114,7 +114,7 @@ Reported-by: Dan Carpenter <dan.carpenter@oracle.com> | ||||
|  	u64 parent_size = mtd_is_partition(parent) ? | ||||
|  			  parent->part.size : parent->size; | ||||
|  	struct mtd_info *child; | ||||
| @@ -164,6 +165,7 @@ static struct mtd_info *allocate_partiti | ||||
| @@ -165,6 +166,7 @@ static struct mtd_info *allocate_partiti | ||||
|  	} else { | ||||
|  		/* Single erase size */ | ||||
|  		child->erasesize = master->erasesize; | ||||
| @@ -122,7 +122,7 @@ Reported-by: Dan Carpenter <dan.carpenter@oracle.com> | ||||
|  	} | ||||
|   | ||||
|  	/* | ||||
| @@ -171,26 +173,39 @@ static struct mtd_info *allocate_partiti | ||||
| @@ -172,26 +174,39 @@ static struct mtd_info *allocate_partiti | ||||
|  	 * exposes several regions with different erasesize. Adjust | ||||
|  	 * wr_alignment accordingly. | ||||
|  	 */ | ||||
|   | ||||
| @@ -10,7 +10,7 @@ Signed-off-by: Abhimanyu Vishwakarma <Abhimanyu.Vishwakarma@imgtec.com> | ||||
|  | ||||
| --- a/drivers/mtd/spi-nor/core.c | ||||
| +++ b/drivers/mtd/spi-nor/core.c | ||||
| @@ -3156,6 +3156,7 @@ int spi_nor_scan(struct spi_nor *nor, co | ||||
| @@ -3141,6 +3141,7 @@ int spi_nor_scan(struct spi_nor *nor, co | ||||
|  	struct device *dev = nor->dev; | ||||
|  	struct mtd_info *mtd = &nor->mtd; | ||||
|  	struct device_node *np = spi_nor_get_flash_node(nor); | ||||
| @@ -18,7 +18,7 @@ Signed-off-by: Abhimanyu Vishwakarma <Abhimanyu.Vishwakarma@imgtec.com> | ||||
|  	int ret; | ||||
|  	int i; | ||||
|   | ||||
| @@ -3210,7 +3211,12 @@ int spi_nor_scan(struct spi_nor *nor, co | ||||
| @@ -3195,7 +3196,12 @@ int spi_nor_scan(struct spi_nor *nor, co | ||||
|  	if (ret) | ||||
|  		return ret; | ||||
|   | ||||
| @@ -34,7 +34,7 @@ Signed-off-by: Abhimanyu Vishwakarma <Abhimanyu.Vishwakarma@imgtec.com> | ||||
|  	mtd->type = MTD_NORFLASH; | ||||
| --- a/drivers/mtd/mtdcore.c | ||||
| +++ b/drivers/mtd/mtdcore.c | ||||
| @@ -778,6 +778,17 @@ out_error: | ||||
| @@ -788,6 +788,17 @@ out_error: | ||||
|   */ | ||||
|  static void mtd_set_dev_defaults(struct mtd_info *mtd) | ||||
|  { | ||||
|   | ||||
		Reference in New Issue
	
	Block a user
	 Rafał Miłecki
					Rafał Miłecki