domenico/openwrt_NSS_ACW
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

kernel: ltq-ptm: do not write directly to dev->addr

Browse Source 
One is never to write to dev->addr directly. In 6.1 it will be a const and
with the newly enabled WERROR, we get a failing grade.

Lets fix this ahead of time.

Ref: adeef3e321
Signed-off-by: Aleksander Jan Bajkowski <olek2@wp.pl>
This commit is contained in:
Aleksander Jan Bajkowski
2023-05-06 23:14:16 +02:00
committed by Christian Marangi
parent f6485c7ce6
commit 598e058080
1 changed files with 9 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
package/kernel/lantiq/ltq-ptm/src/ifxmips_ptm_vdsl.c
View File

@@ -146,6 +146,8 @@ unsigned int ifx_ptm_dbg_enable = DBG_ENABLE_MASK_ERR;
static void ptm_setup(struct net_device *dev, int ndev) static void ptm_setup(struct net_device *dev, int ndev)
{ {
u8 addr[ETH_ALEN];
netif_carrier_off(dev); netif_carrier_off(dev);
dev->netdev_ops = &g_ptm_netdev_ops; dev->netdev_ops = &g_ptm_netdev_ops;
@@ -154,12 +156,13 @@ static void ptm_setup(struct net_device *dev, int ndev)
netif_napi_add(dev, &g_ptm_priv_data.itf[ndev].napi, ptm_napi_poll, 16); netif_napi_add(dev, &g_ptm_priv_data.itf[ndev].napi, ptm_napi_poll, 16);
dev->watchdog_timeo = ETH_WATCHDOG_TIMEOUT; dev->watchdog_timeo = ETH_WATCHDOG_TIMEOUT;
dev->dev_addr[0] = 0x00; addr[0] = 0x00;
dev->dev_addr[1] = 0x20; addr[1] = 0x20;
dev->dev_addr[2] = 0xda; addr[2] = 0xda;
dev->dev_addr[3] = 0x86; addr[3] = 0x86;
dev->dev_addr[4] = 0x23; addr[4] = 0x23;
dev->dev_addr[5] = 0x75 + ndev; addr[5] = 0x75 + ndev;
eth_hw_addr_set(dev, addr);
} }
static struct net_device_stats *ptm_get_stats(struct net_device *dev) static struct net_device_stats *ptm_get_stats(struct net_device *dev)