domenico/openwrt_NSS_ACW
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ramips: tidy up MAC address setup for Linkit Smart and Omega2

Browse Source 
Linkit Smart 7688 and Onion Omega 2(+) are one-port devices, and
have their port set to LAN by default. Setting up a WAN MAC address
for them doesn't make any sense, as no wan interface will be created
in uci config. Despite, these devices also set lan_mac in 02_network,
although mtd-mac-address sets a different address for the ethernet
interface in DTS.

Clean this up by moving the lan_mac value into DTS and dropping the
entries in 02_network completely. That way, the effective address
on the LAN interface should stay the same, but we get rid of the
extra (re)assignments.

As I don't have access to the devices, this does not tell anything
about whether 0x2e is actually a good choice, it just preserves
the existing assignment.

Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de>
This commit is contained in:
Adrian Schmutzler
2020-08-06 13:26:19 +02:00
parent 633ea0db0f
commit 77e850fe76
3 changed files with 2 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
target/linux/ramips/dts/mt7628an_mediatek_linkit-smart-7688.dts
View File

@@ -149,7 +149,7 @@
}; };
&ethernet { &ethernet {
mtd-mac-address = <&factory 0x28>; mtd-mac-address = <&factory 0x2e>;
}; };
&sdhci { &sdhci {

2
target/linux/ramips/dts/mt7628an_onion_omega2.dtsi
View File

@@ -151,7 +151,7 @@
}; };
&ethernet { &ethernet {
mtd-mac-address = <&factory 0x28>; mtd-mac-address = <&factory 0x2e>;
}; };
&sdhci { &sdhci {

6
target/linux/ramips/mt76x8/base-files/etc/board.d/02_network
View File

@@ -188,12 +188,6 @@ ramips_setup_macs()
totolink,lr1200) totolink,lr1200)
wan_mac=$(mtd_get_mac_binary factory 0x2e) wan_mac=$(mtd_get_mac_binary factory 0x2e)
;; ;;
mediatek,linkit-smart-7688|\
onion,omega2|\
onion,omega2p)
wan_mac=$(mtd_get_mac_binary factory 0x4)
lan_mac=$(mtd_get_mac_binary factory 0x2e)
;;
mercury,mac1200r-v2) mercury,mac1200r-v2)
wan_mac=$(macaddr_add "$(mtd_get_mac_binary factory_info 0xd)" 1) wan_mac=$(macaddr_add "$(mtd_get_mac_binary factory_info 0xd)" 1)
;; ;;