ipq40xx: net: phy: qca807x: fix GPIO driver
While rebasing into setting bits instead of magic values,
I accidentally forgot to actually set the force bit.
Without it using the pins as GPIO-s did not actually work.
Fixes: b5c93ed ("ipq40xx: add Qualcomm QCA807x driver")
Signed-off-by: Robert Marko <robert.marko@sartura.hr>
			
			
This commit is contained in:
		 Robert Marko
					Robert Marko
				
			
				
					committed by
					
						 Christian Lamparter
						Christian Lamparter
					
				
			
			
				
	
			
			
			 Christian Lamparter
						Christian Lamparter
					
				
			
						parent
						
							18a9eff0f6
						
					
				
				
					commit
					7f2d9ccd09
				
			| @@ -356,6 +356,7 @@ static void qca807x_gpio_set(struct gpio_chip *gc, unsigned int offset, int valu | |||||||
|  |  | ||||||
| 	val = phy_read_mmd(priv->phy, MDIO_MMD_AN, qca807x_gpio_get_reg(offset)); | 	val = phy_read_mmd(priv->phy, MDIO_MMD_AN, qca807x_gpio_get_reg(offset)); | ||||||
| 	val &= ~QCA807X_GPIO_FORCE_MODE_MASK; | 	val &= ~QCA807X_GPIO_FORCE_MODE_MASK; | ||||||
|  | 	val |= QCA807X_GPIO_FORCE_EN; | ||||||
| 	val |= FIELD_PREP(QCA807X_GPIO_FORCE_MODE_MASK, value); | 	val |= FIELD_PREP(QCA807X_GPIO_FORCE_MODE_MASK, value); | ||||||
|  |  | ||||||
| 	phy_write_mmd(priv->phy, MDIO_MMD_AN, qca807x_gpio_get_reg(offset), val); | 	phy_write_mmd(priv->phy, MDIO_MMD_AN, qca807x_gpio_get_reg(offset), val); | ||||||
|   | |||||||
		Reference in New Issue
	
	Block a user