generic: mt7530: backport support for the MT7988 built-in switch
Backport commits adding support for the MT7988 built-in switch to the mt7530 driver. This change results in the Kconfig symbol NET_DSA_MT7530 to be extended by NET_DSA_MT7530_MDIO (everything formally covered by NET_DSA_MT7530) and NET_DSA_MT7530_MMIO (a new driver for the MMIO-connected built-in switch of the MT7988 SoC). Select NET_DSA_MT7530_MDIO for all targets previously selecting NET_DSA_MT7530, with the exception of mediatek/filogic which also selects NET_DSA_MT7530_MMIO. Signed-off-by: Daniel Golle <daniel@makrotopia.org>
This commit is contained in:
		| @@ -0,0 +1,32 @@ | ||||
| From b6f56cddb5f57a0b8da0ce582232a2f1933558c6 Mon Sep 17 00:00:00 2001 | ||||
| From: Daniel Golle <daniel@makrotopia.org> | ||||
| Date: Mon, 3 Apr 2023 02:17:19 +0100 | ||||
| Subject: [PATCH 04/16] net: dsa: mt7530: make some noise if register read | ||||
|  fails | ||||
|  | ||||
| Simply returning the negative error value instead of the read value | ||||
| doesn't seem like a good idea. Return 0 instead and add WARN_ON_ONCE(1) | ||||
| so this kind of error will not go unnoticed. | ||||
|  | ||||
| Suggested-by: Andrew Lunn <andrew@lunn.ch> | ||||
| Signed-off-by: Daniel Golle <daniel@makrotopia.org> | ||||
| Reviewed-by: Andrew Lunn <andrew@lunn.ch> | ||||
| Signed-off-by: David S. Miller <davem@davemloft.net> | ||||
| --- | ||||
|  drivers/net/dsa/mt7530.c | 3 ++- | ||||
|  1 file changed, 2 insertions(+), 1 deletion(-) | ||||
|  | ||||
| --- a/drivers/net/dsa/mt7530.c | ||||
| +++ b/drivers/net/dsa/mt7530.c | ||||
| @@ -224,9 +224,10 @@ mt7530_mii_read(struct mt7530_priv *priv | ||||
|  	/* MT7530 uses 31 as the pseudo port */ | ||||
|  	ret = bus->write(bus, 0x1f, 0x1f, page); | ||||
|  	if (ret < 0) { | ||||
| +		WARN_ON_ONCE(1); | ||||
|  		dev_err(&bus->dev, | ||||
|  			"failed to read mt7530 register\n"); | ||||
| -		return ret; | ||||
| +		return 0; | ||||
|  	} | ||||
|   | ||||
|  	lo = bus->read(bus, 0x1f, r); | ||||
| @@ -0,0 +1,111 @@ | ||||
| From 9ecc00164dc2300dfcd40afe549a8ee951dfea9f Mon Sep 17 00:00:00 2001 | ||||
| From: Daniel Golle <daniel@makrotopia.org> | ||||
| Date: Mon, 3 Apr 2023 02:17:30 +0100 | ||||
| Subject: [PATCH 05/16] net: dsa: mt7530: refactor SGMII PCS creation | ||||
|  | ||||
| Instead of macro templates use a dedidated function and allocated | ||||
| regmap_config when creating the regmaps for the pcs-mtk-lynxi | ||||
| instances. | ||||
| This is in preparation to switching to use unlocked regmap accessors | ||||
| and have regmap's locking API handle locking for us. | ||||
|  | ||||
| Signed-off-by: Daniel Golle <daniel@makrotopia.org> | ||||
| Reviewed-by: Andrew Lunn <andrew@lunn.ch> | ||||
| Signed-off-by: David S. Miller <davem@davemloft.net> | ||||
| --- | ||||
|  drivers/net/dsa/mt7530.c | 74 +++++++++++++++++++++++++++------------- | ||||
|  1 file changed, 50 insertions(+), 24 deletions(-) | ||||
|  | ||||
| --- a/drivers/net/dsa/mt7530.c | ||||
| +++ b/drivers/net/dsa/mt7530.c | ||||
| @@ -2926,26 +2926,56 @@ static const struct regmap_bus mt7531_re | ||||
|  	.reg_update_bits = mt7530_regmap_update_bits, | ||||
|  }; | ||||
|   | ||||
| -#define MT7531_PCS_REGMAP_CONFIG(_name, _reg_base) \ | ||||
| -	{				\ | ||||
| -		.name = _name,		\ | ||||
| -		.reg_bits = 16,		\ | ||||
| -		.val_bits = 32,		\ | ||||
| -		.reg_stride = 4,	\ | ||||
| -		.reg_base = _reg_base,	\ | ||||
| -		.max_register = 0x17c,	\ | ||||
| +static int | ||||
| +mt7531_create_sgmii(struct mt7530_priv *priv) | ||||
| +{ | ||||
| +	struct regmap_config *mt7531_pcs_config[2]; | ||||
| +	struct phylink_pcs *pcs; | ||||
| +	struct regmap *regmap; | ||||
| +	int i, ret = 0; | ||||
| + | ||||
| +	for (i = 0; i < 2; i++) { | ||||
| +		mt7531_pcs_config[i] = devm_kzalloc(priv->dev, | ||||
| +						    sizeof(struct regmap_config), | ||||
| +						    GFP_KERNEL); | ||||
| +		if (!mt7531_pcs_config[i]) { | ||||
| +			ret = -ENOMEM; | ||||
| +			break; | ||||
| +		} | ||||
| + | ||||
| +		mt7531_pcs_config[i]->name = i ? "port6" : "port5"; | ||||
| +		mt7531_pcs_config[i]->reg_bits = 16; | ||||
| +		mt7531_pcs_config[i]->val_bits = 32; | ||||
| +		mt7531_pcs_config[i]->reg_stride = 4; | ||||
| +		mt7531_pcs_config[i]->reg_base = MT7531_SGMII_REG_BASE(5 + i); | ||||
| +		mt7531_pcs_config[i]->max_register = 0x17c; | ||||
| + | ||||
| +		regmap = devm_regmap_init(priv->dev, | ||||
| +					  &mt7531_regmap_bus, priv, | ||||
| +					  mt7531_pcs_config[i]); | ||||
| +		if (IS_ERR(regmap)) { | ||||
| +			ret = PTR_ERR(regmap); | ||||
| +			break; | ||||
| +		} | ||||
| +		pcs = mtk_pcs_lynxi_create(priv->dev, regmap, | ||||
| +					   MT7531_PHYA_CTRL_SIGNAL3, 0); | ||||
| +		if (!pcs) { | ||||
| +			ret = -ENXIO; | ||||
| +			break; | ||||
| +		} | ||||
| +		priv->ports[5 + i].sgmii_pcs = pcs; | ||||
|  	} | ||||
|   | ||||
| -static const struct regmap_config mt7531_pcs_config[] = { | ||||
| -	MT7531_PCS_REGMAP_CONFIG("port5", MT7531_SGMII_REG_BASE(5)), | ||||
| -	MT7531_PCS_REGMAP_CONFIG("port6", MT7531_SGMII_REG_BASE(6)), | ||||
| -}; | ||||
| +	if (ret && i) | ||||
| +		mtk_pcs_lynxi_destroy(priv->ports[5].sgmii_pcs); | ||||
| + | ||||
| +	return ret; | ||||
| +} | ||||
|   | ||||
|  static int | ||||
|  mt753x_setup(struct dsa_switch *ds) | ||||
|  { | ||||
|  	struct mt7530_priv *priv = ds->priv; | ||||
| -	struct regmap *regmap; | ||||
|  	int i, ret; | ||||
|   | ||||
|  	/* Initialise the PCS devices */ | ||||
| @@ -2967,15 +2997,11 @@ mt753x_setup(struct dsa_switch *ds) | ||||
|  	if (ret && priv->irq) | ||||
|  		mt7530_free_irq_common(priv); | ||||
|   | ||||
| -	if (priv->id == ID_MT7531) | ||||
| -		for (i = 0; i < 2; i++) { | ||||
| -			regmap = devm_regmap_init(ds->dev, | ||||
| -						  &mt7531_regmap_bus, priv, | ||||
| -						  &mt7531_pcs_config[i]); | ||||
| -			priv->ports[5 + i].sgmii_pcs = | ||||
| -				mtk_pcs_lynxi_create(ds->dev, regmap, | ||||
| -						     MT7531_PHYA_CTRL_SIGNAL3, 0); | ||||
| -		} | ||||
| +	if (priv->id == ID_MT7531) { | ||||
| +		ret = mt7531_create_sgmii(priv); | ||||
| +		if (ret && priv->irq) | ||||
| +			mt7530_free_irq_common(priv); | ||||
| +	} | ||||
|   | ||||
|  	return ret; | ||||
|  } | ||||
| @@ -0,0 +1,74 @@ | ||||
| From 1bd099c49f65ed923b9f19b8c4b3cd1ff0024091 Mon Sep 17 00:00:00 2001 | ||||
| From: Daniel Golle <daniel@makrotopia.org> | ||||
| Date: Mon, 3 Apr 2023 02:17:40 +0100 | ||||
| Subject: [PATCH 06/16] net: dsa: mt7530: use unlocked regmap accessors | ||||
|  | ||||
| Instead of wrapping the locked register accessor functions, use the | ||||
| unlocked variants and add locking wrapper functions to let regmap | ||||
| handle the locking. | ||||
|  | ||||
| This is a preparation towards being able to always use regmap to | ||||
| access switch registers instead of open-coded accessor functions. | ||||
|  | ||||
| Signed-off-by: Daniel Golle <daniel@makrotopia.org> | ||||
| Reviewed-by: Andrew Lunn <andrew@lunn.ch> | ||||
| Signed-off-by: David S. Miller <davem@davemloft.net> | ||||
| --- | ||||
|  drivers/net/dsa/mt7530.c | 23 ++++++++++++++--------- | ||||
|  1 file changed, 14 insertions(+), 9 deletions(-) | ||||
|  | ||||
| --- a/drivers/net/dsa/mt7530.c | ||||
| +++ b/drivers/net/dsa/mt7530.c | ||||
| @@ -2899,7 +2899,7 @@ static int mt7530_regmap_read(void *cont | ||||
|  { | ||||
|  	struct mt7530_priv *priv = context; | ||||
|   | ||||
| -	*val = mt7530_read(priv, reg); | ||||
| +	*val = mt7530_mii_read(priv, reg); | ||||
|  	return 0; | ||||
|  }; | ||||
|   | ||||
| @@ -2907,23 +2907,25 @@ static int mt7530_regmap_write(void *con | ||||
|  { | ||||
|  	struct mt7530_priv *priv = context; | ||||
|   | ||||
| -	mt7530_write(priv, reg, val); | ||||
| +	mt7530_mii_write(priv, reg, val); | ||||
|  	return 0; | ||||
|  }; | ||||
|   | ||||
| -static int mt7530_regmap_update_bits(void *context, unsigned int reg, | ||||
| -				     unsigned int mask, unsigned int val) | ||||
| +static void | ||||
| +mt7530_mdio_regmap_lock(void *mdio_lock) | ||||
|  { | ||||
| -	struct mt7530_priv *priv = context; | ||||
| +	mutex_lock_nested(mdio_lock, MDIO_MUTEX_NESTED); | ||||
| +} | ||||
|   | ||||
| -	mt7530_rmw(priv, reg, mask, val); | ||||
| -	return 0; | ||||
| -}; | ||||
| +static void | ||||
| +mt7530_mdio_regmap_unlock(void *mdio_lock) | ||||
| +{ | ||||
| +	mutex_unlock(mdio_lock); | ||||
| +} | ||||
|   | ||||
|  static const struct regmap_bus mt7531_regmap_bus = { | ||||
|  	.reg_write = mt7530_regmap_write, | ||||
|  	.reg_read = mt7530_regmap_read, | ||||
| -	.reg_update_bits = mt7530_regmap_update_bits, | ||||
|  }; | ||||
|   | ||||
|  static int | ||||
| @@ -2949,6 +2951,9 @@ mt7531_create_sgmii(struct mt7530_priv * | ||||
|  		mt7531_pcs_config[i]->reg_stride = 4; | ||||
|  		mt7531_pcs_config[i]->reg_base = MT7531_SGMII_REG_BASE(5 + i); | ||||
|  		mt7531_pcs_config[i]->max_register = 0x17c; | ||||
| +		mt7531_pcs_config[i]->lock = mt7530_mdio_regmap_lock; | ||||
| +		mt7531_pcs_config[i]->unlock = mt7530_mdio_regmap_unlock; | ||||
| +		mt7531_pcs_config[i]->lock_arg = &priv->bus->mdio_lock; | ||||
|   | ||||
|  		regmap = devm_regmap_init(priv->dev, | ||||
|  					  &mt7531_regmap_bus, priv, | ||||
| @@ -0,0 +1,224 @@ | ||||
| From a08c045580e060a6886bbb656c50ae20b0c780b5 Mon Sep 17 00:00:00 2001 | ||||
| From: Daniel Golle <daniel@makrotopia.org> | ||||
| Date: Mon, 3 Apr 2023 02:17:52 +0100 | ||||
| Subject: [PATCH 07/16] net: dsa: mt7530: use regmap to access switch register | ||||
|  space | ||||
|  | ||||
| Use regmap API to access the switch register space. | ||||
|  | ||||
| Signed-off-by: Daniel Golle <daniel@makrotopia.org> | ||||
| Signed-off-by: David S. Miller <davem@davemloft.net> | ||||
| --- | ||||
|  drivers/net/dsa/mt7530.c | 99 ++++++++++++++++++++++++---------------- | ||||
|  drivers/net/dsa/mt7530.h |  2 + | ||||
|  2 files changed, 62 insertions(+), 39 deletions(-) | ||||
|  | ||||
| --- a/drivers/net/dsa/mt7530.c | ||||
| +++ b/drivers/net/dsa/mt7530.c | ||||
| @@ -183,9 +183,9 @@ core_clear(struct mt7530_priv *priv, u32 | ||||
|  } | ||||
|   | ||||
|  static int | ||||
| -mt7530_mii_write(struct mt7530_priv *priv, u32 reg, u32 val) | ||||
| +mt7530_regmap_write(void *context, unsigned int reg, unsigned int val) | ||||
|  { | ||||
| -	struct mii_bus *bus = priv->bus; | ||||
| +	struct mii_bus *bus = context; | ||||
|  	u16 page, r, lo, hi; | ||||
|  	int ret; | ||||
|   | ||||
| @@ -197,24 +197,34 @@ mt7530_mii_write(struct mt7530_priv *pri | ||||
|  	/* MT7530 uses 31 as the pseudo port */ | ||||
|  	ret = bus->write(bus, 0x1f, 0x1f, page); | ||||
|  	if (ret < 0) | ||||
| -		goto err; | ||||
| +		return ret; | ||||
|   | ||||
|  	ret = bus->write(bus, 0x1f, r,  lo); | ||||
|  	if (ret < 0) | ||||
| -		goto err; | ||||
| +		return ret; | ||||
|   | ||||
|  	ret = bus->write(bus, 0x1f, 0x10, hi); | ||||
| -err: | ||||
| +	return ret; | ||||
| +} | ||||
| + | ||||
| +static int | ||||
| +mt7530_mii_write(struct mt7530_priv *priv, u32 reg, u32 val) | ||||
| +{ | ||||
| +	int ret; | ||||
| + | ||||
| +	ret = regmap_write(priv->regmap, reg, val); | ||||
| + | ||||
|  	if (ret < 0) | ||||
| -		dev_err(&bus->dev, | ||||
| +		dev_err(priv->dev, | ||||
|  			"failed to write mt7530 register\n"); | ||||
| + | ||||
|  	return ret; | ||||
|  } | ||||
|   | ||||
| -static u32 | ||||
| -mt7530_mii_read(struct mt7530_priv *priv, u32 reg) | ||||
| +static int | ||||
| +mt7530_regmap_read(void *context, unsigned int reg, unsigned int *val) | ||||
|  { | ||||
| -	struct mii_bus *bus = priv->bus; | ||||
| +	struct mii_bus *bus = context; | ||||
|  	u16 page, r, lo, hi; | ||||
|  	int ret; | ||||
|   | ||||
| @@ -223,17 +233,32 @@ mt7530_mii_read(struct mt7530_priv *priv | ||||
|   | ||||
|  	/* MT7530 uses 31 as the pseudo port */ | ||||
|  	ret = bus->write(bus, 0x1f, 0x1f, page); | ||||
| -	if (ret < 0) { | ||||
| +	if (ret < 0) | ||||
| +		return ret; | ||||
| + | ||||
| +	lo = bus->read(bus, 0x1f, r); | ||||
| +	hi = bus->read(bus, 0x1f, 0x10); | ||||
| + | ||||
| +	*val = (hi << 16) | (lo & 0xffff); | ||||
| + | ||||
| +	return 0; | ||||
| +} | ||||
| + | ||||
| +static u32 | ||||
| +mt7530_mii_read(struct mt7530_priv *priv, u32 reg) | ||||
| +{ | ||||
| +	int ret; | ||||
| +	u32 val; | ||||
| + | ||||
| +	ret = regmap_read(priv->regmap, reg, &val); | ||||
| +	if (ret) { | ||||
|  		WARN_ON_ONCE(1); | ||||
| -		dev_err(&bus->dev, | ||||
| +		dev_err(priv->dev, | ||||
|  			"failed to read mt7530 register\n"); | ||||
|  		return 0; | ||||
|  	} | ||||
|   | ||||
| -	lo = bus->read(bus, 0x1f, r); | ||||
| -	hi = bus->read(bus, 0x1f, 0x10); | ||||
| - | ||||
| -	return (hi << 16) | (lo & 0xffff); | ||||
| +	return val; | ||||
|  } | ||||
|   | ||||
|  static void | ||||
| @@ -283,14 +308,10 @@ mt7530_rmw(struct mt7530_priv *priv, u32 | ||||
|  	   u32 mask, u32 set) | ||||
|  { | ||||
|  	struct mii_bus *bus = priv->bus; | ||||
| -	u32 val; | ||||
|   | ||||
|  	mutex_lock_nested(&bus->mdio_lock, MDIO_MUTEX_NESTED); | ||||
|   | ||||
| -	val = mt7530_mii_read(priv, reg); | ||||
| -	val &= ~mask; | ||||
| -	val |= set; | ||||
| -	mt7530_mii_write(priv, reg, val); | ||||
| +	regmap_update_bits(priv->regmap, reg, mask, set); | ||||
|   | ||||
|  	mutex_unlock(&bus->mdio_lock); | ||||
|  } | ||||
| @@ -298,7 +319,7 @@ mt7530_rmw(struct mt7530_priv *priv, u32 | ||||
|  static void | ||||
|  mt7530_set(struct mt7530_priv *priv, u32 reg, u32 val) | ||||
|  { | ||||
| -	mt7530_rmw(priv, reg, 0, val); | ||||
| +	mt7530_rmw(priv, reg, val, val); | ||||
|  } | ||||
|   | ||||
|  static void | ||||
| @@ -2895,22 +2916,6 @@ static const struct phylink_pcs_ops mt75 | ||||
|  	.pcs_an_restart = mt7530_pcs_an_restart, | ||||
|  }; | ||||
|   | ||||
| -static int mt7530_regmap_read(void *context, unsigned int reg, unsigned int *val) | ||||
| -{ | ||||
| -	struct mt7530_priv *priv = context; | ||||
| - | ||||
| -	*val = mt7530_mii_read(priv, reg); | ||||
| -	return 0; | ||||
| -}; | ||||
| - | ||||
| -static int mt7530_regmap_write(void *context, unsigned int reg, unsigned int val) | ||||
| -{ | ||||
| -	struct mt7530_priv *priv = context; | ||||
| - | ||||
| -	mt7530_mii_write(priv, reg, val); | ||||
| -	return 0; | ||||
| -}; | ||||
| - | ||||
|  static void | ||||
|  mt7530_mdio_regmap_lock(void *mdio_lock) | ||||
|  { | ||||
| @@ -2923,7 +2928,7 @@ mt7530_mdio_regmap_unlock(void *mdio_loc | ||||
|  	mutex_unlock(mdio_lock); | ||||
|  } | ||||
|   | ||||
| -static const struct regmap_bus mt7531_regmap_bus = { | ||||
| +static const struct regmap_bus mt7530_regmap_bus = { | ||||
|  	.reg_write = mt7530_regmap_write, | ||||
|  	.reg_read = mt7530_regmap_read, | ||||
|  }; | ||||
| @@ -2956,7 +2961,7 @@ mt7531_create_sgmii(struct mt7530_priv * | ||||
|  		mt7531_pcs_config[i]->lock_arg = &priv->bus->mdio_lock; | ||||
|   | ||||
|  		regmap = devm_regmap_init(priv->dev, | ||||
| -					  &mt7531_regmap_bus, priv, | ||||
| +					  &mt7530_regmap_bus, priv->bus, | ||||
|  					  mt7531_pcs_config[i]); | ||||
|  		if (IS_ERR(regmap)) { | ||||
|  			ret = PTR_ERR(regmap); | ||||
| @@ -3121,6 +3126,7 @@ MODULE_DEVICE_TABLE(of, mt7530_of_match) | ||||
|  static int | ||||
|  mt7530_probe(struct mdio_device *mdiodev) | ||||
|  { | ||||
| +	static struct regmap_config *regmap_config; | ||||
|  	struct mt7530_priv *priv; | ||||
|  	struct device_node *dn; | ||||
|   | ||||
| @@ -3200,6 +3206,21 @@ mt7530_probe(struct mdio_device *mdiodev | ||||
|  	mutex_init(&priv->reg_mutex); | ||||
|  	dev_set_drvdata(&mdiodev->dev, priv); | ||||
|   | ||||
| +	regmap_config = devm_kzalloc(&mdiodev->dev, sizeof(*regmap_config), | ||||
| +				     GFP_KERNEL); | ||||
| +	if (!regmap_config) | ||||
| +		return -ENOMEM; | ||||
| + | ||||
| +	regmap_config->reg_bits = 16; | ||||
| +	regmap_config->val_bits = 32; | ||||
| +	regmap_config->reg_stride = 4; | ||||
| +	regmap_config->max_register = MT7530_CREV; | ||||
| +	regmap_config->disable_locking = true; | ||||
| +	priv->regmap = devm_regmap_init(priv->dev, &mt7530_regmap_bus, | ||||
| +					priv->bus, regmap_config); | ||||
| +	if (IS_ERR(priv->regmap)) | ||||
| +		return PTR_ERR(priv->regmap); | ||||
| + | ||||
|  	return dsa_register_switch(priv->ds); | ||||
|  } | ||||
|   | ||||
| --- a/drivers/net/dsa/mt7530.h | ||||
| +++ b/drivers/net/dsa/mt7530.h | ||||
| @@ -747,6 +747,7 @@ struct mt753x_info { | ||||
|   * @dev:		The device pointer | ||||
|   * @ds:			The pointer to the dsa core structure | ||||
|   * @bus:		The bus used for the device and built-in PHY | ||||
| + * @regmap:		The regmap instance representing all switch registers | ||||
|   * @rstc:		The pointer to reset control used by MCM | ||||
|   * @core_pwr:		The power supplied into the core | ||||
|   * @io_pwr:		The power supplied into the I/O | ||||
| @@ -767,6 +768,7 @@ struct mt7530_priv { | ||||
|  	struct device		*dev; | ||||
|  	struct dsa_switch	*ds; | ||||
|  	struct mii_bus		*bus; | ||||
| +	struct regmap		*regmap; | ||||
|  	struct reset_control	*rstc; | ||||
|  	struct regulator	*core_pwr; | ||||
|  	struct regulator	*io_pwr; | ||||
| @@ -0,0 +1,54 @@ | ||||
| From 6de2852297737171ba96b91e89bf302ca1fda869 Mon Sep 17 00:00:00 2001 | ||||
| From: Daniel Golle <daniel@makrotopia.org> | ||||
| Date: Mon, 3 Apr 2023 02:18:04 +0100 | ||||
| Subject: [PATCH 08/16] net: dsa: mt7530: move SGMII PCS creation to | ||||
|  mt7530_probe function | ||||
|  | ||||
| Move creating the SGMII PCS from mt753x_setup() to the more appropriate | ||||
| mt7530_probe() function. | ||||
| This is done also in preparation of moving all functions related to | ||||
| MDIO-connected MT753x switches to a separate module. | ||||
|  | ||||
| Signed-off-by: Daniel Golle <daniel@makrotopia.org> | ||||
| Reviewed-by: Andrew Lunn <andrew@lunn.ch> | ||||
| Signed-off-by: David S. Miller <davem@davemloft.net> | ||||
| --- | ||||
|  drivers/net/dsa/mt7530.c | 13 +++++++------ | ||||
|  1 file changed, 7 insertions(+), 6 deletions(-) | ||||
|  | ||||
| --- a/drivers/net/dsa/mt7530.c | ||||
| +++ b/drivers/net/dsa/mt7530.c | ||||
| @@ -3007,12 +3007,6 @@ mt753x_setup(struct dsa_switch *ds) | ||||
|  	if (ret && priv->irq) | ||||
|  		mt7530_free_irq_common(priv); | ||||
|   | ||||
| -	if (priv->id == ID_MT7531) { | ||||
| -		ret = mt7531_create_sgmii(priv); | ||||
| -		if (ret && priv->irq) | ||||
| -			mt7530_free_irq_common(priv); | ||||
| -	} | ||||
| - | ||||
|  	return ret; | ||||
|  } | ||||
|   | ||||
| @@ -3129,6 +3123,7 @@ mt7530_probe(struct mdio_device *mdiodev | ||||
|  	static struct regmap_config *regmap_config; | ||||
|  	struct mt7530_priv *priv; | ||||
|  	struct device_node *dn; | ||||
| +	int ret; | ||||
|   | ||||
|  	dn = mdiodev->dev.of_node; | ||||
|   | ||||
| @@ -3221,6 +3216,12 @@ mt7530_probe(struct mdio_device *mdiodev | ||||
|  	if (IS_ERR(priv->regmap)) | ||||
|  		return PTR_ERR(priv->regmap); | ||||
|   | ||||
| +	if (priv->id == ID_MT7531) { | ||||
| +		ret = mt7531_create_sgmii(priv); | ||||
| +		if (ret) | ||||
| +			return ret; | ||||
| +	} | ||||
| + | ||||
|  	return dsa_register_switch(priv->ds); | ||||
|  } | ||||
|   | ||||
| @@ -0,0 +1,273 @@ | ||||
| From 1557c679f71c82a994eae0baadbaeb62b71e15bf Mon Sep 17 00:00:00 2001 | ||||
| From: Daniel Golle <daniel@makrotopia.org> | ||||
| Date: Mon, 3 Apr 2023 02:18:16 +0100 | ||||
| Subject: [PATCH 09/16] net: dsa: mt7530: introduce mutex helpers | ||||
|  | ||||
| As the MDIO bus lock only needs to be involved if actually operating | ||||
| on an MDIO-connected switch we will need to skip locking for built-in | ||||
| switches which are accessed via MMIO. | ||||
| Create helper functions which simplify that upcoming change. | ||||
|  | ||||
| Signed-off-by: Daniel Golle <daniel@makrotopia.org> | ||||
| Reviewed-by: Andrew Lunn <andrew@lunn.ch> | ||||
| Signed-off-by: David S. Miller <davem@davemloft.net> | ||||
| --- | ||||
|  drivers/net/dsa/mt7530.c | 73 ++++++++++++++++++++-------------------- | ||||
|  1 file changed, 36 insertions(+), 37 deletions(-) | ||||
|  | ||||
| --- a/drivers/net/dsa/mt7530.c | ||||
| +++ b/drivers/net/dsa/mt7530.c | ||||
| @@ -143,31 +143,40 @@ err: | ||||
|  } | ||||
|   | ||||
|  static void | ||||
| -core_write(struct mt7530_priv *priv, u32 reg, u32 val) | ||||
| +mt7530_mutex_lock(struct mt7530_priv *priv) | ||||
|  { | ||||
| -	struct mii_bus *bus = priv->bus; | ||||
| +	mutex_lock_nested(&priv->bus->mdio_lock, MDIO_MUTEX_NESTED); | ||||
| +} | ||||
|   | ||||
| -	mutex_lock_nested(&bus->mdio_lock, MDIO_MUTEX_NESTED); | ||||
| +static void | ||||
| +mt7530_mutex_unlock(struct mt7530_priv *priv) | ||||
| +{ | ||||
| +	mutex_unlock(&priv->bus->mdio_lock); | ||||
| +} | ||||
| + | ||||
| +static void | ||||
| +core_write(struct mt7530_priv *priv, u32 reg, u32 val) | ||||
| +{ | ||||
| +	mt7530_mutex_lock(priv); | ||||
|   | ||||
|  	core_write_mmd_indirect(priv, reg, MDIO_MMD_VEND2, val); | ||||
|   | ||||
| -	mutex_unlock(&bus->mdio_lock); | ||||
| +	mt7530_mutex_unlock(priv); | ||||
|  } | ||||
|   | ||||
|  static void | ||||
|  core_rmw(struct mt7530_priv *priv, u32 reg, u32 mask, u32 set) | ||||
|  { | ||||
| -	struct mii_bus *bus = priv->bus; | ||||
|  	u32 val; | ||||
|   | ||||
| -	mutex_lock_nested(&bus->mdio_lock, MDIO_MUTEX_NESTED); | ||||
| +	mt7530_mutex_lock(priv); | ||||
|   | ||||
|  	val = core_read_mmd_indirect(priv, reg, MDIO_MMD_VEND2); | ||||
|  	val &= ~mask; | ||||
|  	val |= set; | ||||
|  	core_write_mmd_indirect(priv, reg, MDIO_MMD_VEND2, val); | ||||
|   | ||||
| -	mutex_unlock(&bus->mdio_lock); | ||||
| +	mt7530_mutex_unlock(priv); | ||||
|  } | ||||
|   | ||||
|  static void | ||||
| @@ -264,13 +273,11 @@ mt7530_mii_read(struct mt7530_priv *priv | ||||
|  static void | ||||
|  mt7530_write(struct mt7530_priv *priv, u32 reg, u32 val) | ||||
|  { | ||||
| -	struct mii_bus *bus = priv->bus; | ||||
| - | ||||
| -	mutex_lock_nested(&bus->mdio_lock, MDIO_MUTEX_NESTED); | ||||
| +	mt7530_mutex_lock(priv); | ||||
|   | ||||
|  	mt7530_mii_write(priv, reg, val); | ||||
|   | ||||
| -	mutex_unlock(&bus->mdio_lock); | ||||
| +	mt7530_mutex_unlock(priv); | ||||
|  } | ||||
|   | ||||
|  static u32 | ||||
| @@ -282,14 +289,13 @@ _mt7530_unlocked_read(struct mt7530_dumm | ||||
|  static u32 | ||||
|  _mt7530_read(struct mt7530_dummy_poll *p) | ||||
|  { | ||||
| -	struct mii_bus		*bus = p->priv->bus; | ||||
|  	u32 val; | ||||
|   | ||||
| -	mutex_lock_nested(&bus->mdio_lock, MDIO_MUTEX_NESTED); | ||||
| +	mt7530_mutex_lock(p->priv); | ||||
|   | ||||
|  	val = mt7530_mii_read(p->priv, p->reg); | ||||
|   | ||||
| -	mutex_unlock(&bus->mdio_lock); | ||||
| +	mt7530_mutex_unlock(p->priv); | ||||
|   | ||||
|  	return val; | ||||
|  } | ||||
| @@ -307,13 +313,11 @@ static void | ||||
|  mt7530_rmw(struct mt7530_priv *priv, u32 reg, | ||||
|  	   u32 mask, u32 set) | ||||
|  { | ||||
| -	struct mii_bus *bus = priv->bus; | ||||
| - | ||||
| -	mutex_lock_nested(&bus->mdio_lock, MDIO_MUTEX_NESTED); | ||||
| +	mt7530_mutex_lock(priv); | ||||
|   | ||||
|  	regmap_update_bits(priv->regmap, reg, mask, set); | ||||
|   | ||||
| -	mutex_unlock(&bus->mdio_lock); | ||||
| +	mt7530_mutex_unlock(priv); | ||||
|  } | ||||
|   | ||||
|  static void | ||||
| @@ -645,14 +649,13 @@ static int | ||||
|  mt7531_ind_c45_phy_read(struct mt7530_priv *priv, int port, int devad, | ||||
|  			int regnum) | ||||
|  { | ||||
| -	struct mii_bus *bus = priv->bus; | ||||
|  	struct mt7530_dummy_poll p; | ||||
|  	u32 reg, val; | ||||
|  	int ret; | ||||
|   | ||||
|  	INIT_MT7530_DUMMY_POLL(&p, priv, MT7531_PHY_IAC); | ||||
|   | ||||
| -	mutex_lock_nested(&bus->mdio_lock, MDIO_MUTEX_NESTED); | ||||
| +	mt7530_mutex_lock(priv); | ||||
|   | ||||
|  	ret = readx_poll_timeout(_mt7530_unlocked_read, &p, val, | ||||
|  				 !(val & MT7531_PHY_ACS_ST), 20, 100000); | ||||
| @@ -685,7 +688,7 @@ mt7531_ind_c45_phy_read(struct mt7530_pr | ||||
|   | ||||
|  	ret = val & MT7531_MDIO_RW_DATA_MASK; | ||||
|  out: | ||||
| -	mutex_unlock(&bus->mdio_lock); | ||||
| +	mt7530_mutex_unlock(priv); | ||||
|   | ||||
|  	return ret; | ||||
|  } | ||||
| @@ -694,14 +697,13 @@ static int | ||||
|  mt7531_ind_c45_phy_write(struct mt7530_priv *priv, int port, int devad, | ||||
|  			 int regnum, u32 data) | ||||
|  { | ||||
| -	struct mii_bus *bus = priv->bus; | ||||
|  	struct mt7530_dummy_poll p; | ||||
|  	u32 val, reg; | ||||
|  	int ret; | ||||
|   | ||||
|  	INIT_MT7530_DUMMY_POLL(&p, priv, MT7531_PHY_IAC); | ||||
|   | ||||
| -	mutex_lock_nested(&bus->mdio_lock, MDIO_MUTEX_NESTED); | ||||
| +	mt7530_mutex_lock(priv); | ||||
|   | ||||
|  	ret = readx_poll_timeout(_mt7530_unlocked_read, &p, val, | ||||
|  				 !(val & MT7531_PHY_ACS_ST), 20, 100000); | ||||
| @@ -733,7 +735,7 @@ mt7531_ind_c45_phy_write(struct mt7530_p | ||||
|  	} | ||||
|   | ||||
|  out: | ||||
| -	mutex_unlock(&bus->mdio_lock); | ||||
| +	mt7530_mutex_unlock(priv); | ||||
|   | ||||
|  	return ret; | ||||
|  } | ||||
| @@ -741,14 +743,13 @@ out: | ||||
|  static int | ||||
|  mt7531_ind_c22_phy_read(struct mt7530_priv *priv, int port, int regnum) | ||||
|  { | ||||
| -	struct mii_bus *bus = priv->bus; | ||||
|  	struct mt7530_dummy_poll p; | ||||
|  	int ret; | ||||
|  	u32 val; | ||||
|   | ||||
|  	INIT_MT7530_DUMMY_POLL(&p, priv, MT7531_PHY_IAC); | ||||
|   | ||||
| -	mutex_lock_nested(&bus->mdio_lock, MDIO_MUTEX_NESTED); | ||||
| +	mt7530_mutex_lock(priv); | ||||
|   | ||||
|  	ret = readx_poll_timeout(_mt7530_unlocked_read, &p, val, | ||||
|  				 !(val & MT7531_PHY_ACS_ST), 20, 100000); | ||||
| @@ -771,7 +772,7 @@ mt7531_ind_c22_phy_read(struct mt7530_pr | ||||
|   | ||||
|  	ret = val & MT7531_MDIO_RW_DATA_MASK; | ||||
|  out: | ||||
| -	mutex_unlock(&bus->mdio_lock); | ||||
| +	mt7530_mutex_unlock(priv); | ||||
|   | ||||
|  	return ret; | ||||
|  } | ||||
| @@ -780,14 +781,13 @@ static int | ||||
|  mt7531_ind_c22_phy_write(struct mt7530_priv *priv, int port, int regnum, | ||||
|  			 u16 data) | ||||
|  { | ||||
| -	struct mii_bus *bus = priv->bus; | ||||
|  	struct mt7530_dummy_poll p; | ||||
|  	int ret; | ||||
|  	u32 reg; | ||||
|   | ||||
|  	INIT_MT7530_DUMMY_POLL(&p, priv, MT7531_PHY_IAC); | ||||
|   | ||||
| -	mutex_lock_nested(&bus->mdio_lock, MDIO_MUTEX_NESTED); | ||||
| +	mt7530_mutex_lock(priv); | ||||
|   | ||||
|  	ret = readx_poll_timeout(_mt7530_unlocked_read, &p, reg, | ||||
|  				 !(reg & MT7531_PHY_ACS_ST), 20, 100000); | ||||
| @@ -809,7 +809,7 @@ mt7531_ind_c22_phy_write(struct mt7530_p | ||||
|  	} | ||||
|   | ||||
|  out: | ||||
| -	mutex_unlock(&bus->mdio_lock); | ||||
| +	mt7530_mutex_unlock(priv); | ||||
|   | ||||
|  	return ret; | ||||
|  } | ||||
| @@ -1109,7 +1109,6 @@ static int | ||||
|  mt7530_port_change_mtu(struct dsa_switch *ds, int port, int new_mtu) | ||||
|  { | ||||
|  	struct mt7530_priv *priv = ds->priv; | ||||
| -	struct mii_bus *bus = priv->bus; | ||||
|  	int length; | ||||
|  	u32 val; | ||||
|   | ||||
| @@ -1120,7 +1119,7 @@ mt7530_port_change_mtu(struct dsa_switch | ||||
|  	if (!dsa_is_cpu_port(ds, port)) | ||||
|  		return 0; | ||||
|   | ||||
| -	mutex_lock_nested(&bus->mdio_lock, MDIO_MUTEX_NESTED); | ||||
| +	mt7530_mutex_lock(priv); | ||||
|   | ||||
|  	val = mt7530_mii_read(priv, MT7530_GMACCR); | ||||
|  	val &= ~MAX_RX_PKT_LEN_MASK; | ||||
| @@ -1141,7 +1140,7 @@ mt7530_port_change_mtu(struct dsa_switch | ||||
|   | ||||
|  	mt7530_mii_write(priv, MT7530_GMACCR, val); | ||||
|   | ||||
| -	mutex_unlock(&bus->mdio_lock); | ||||
| +	mt7530_mutex_unlock(priv); | ||||
|   | ||||
|  	return 0; | ||||
|  } | ||||
| @@ -1937,10 +1936,10 @@ mt7530_irq_thread_fn(int irq, void *dev_ | ||||
|  	u32 val; | ||||
|  	int p; | ||||
|   | ||||
| -	mutex_lock_nested(&priv->bus->mdio_lock, MDIO_MUTEX_NESTED); | ||||
| +	mt7530_mutex_lock(priv); | ||||
|  	val = mt7530_mii_read(priv, MT7530_SYS_INT_STS); | ||||
|  	mt7530_mii_write(priv, MT7530_SYS_INT_STS, val); | ||||
| -	mutex_unlock(&priv->bus->mdio_lock); | ||||
| +	mt7530_mutex_unlock(priv); | ||||
|   | ||||
|  	for (p = 0; p < MT7530_NUM_PHYS; p++) { | ||||
|  		if (BIT(p) & val) { | ||||
| @@ -1976,7 +1975,7 @@ mt7530_irq_bus_lock(struct irq_data *d) | ||||
|  { | ||||
|  	struct mt7530_priv *priv = irq_data_get_irq_chip_data(d); | ||||
|   | ||||
| -	mutex_lock_nested(&priv->bus->mdio_lock, MDIO_MUTEX_NESTED); | ||||
| +	mt7530_mutex_lock(priv); | ||||
|  } | ||||
|   | ||||
|  static void | ||||
| @@ -1985,7 +1984,7 @@ mt7530_irq_bus_sync_unlock(struct irq_da | ||||
|  	struct mt7530_priv *priv = irq_data_get_irq_chip_data(d); | ||||
|   | ||||
|  	mt7530_mii_write(priv, MT7530_SYS_INT_EN, priv->irq_enable); | ||||
| -	mutex_unlock(&priv->bus->mdio_lock); | ||||
| +	mt7530_mutex_unlock(priv); | ||||
|  } | ||||
|   | ||||
|  static struct irq_chip mt7530_irq_chip = { | ||||
| @@ -0,0 +1,75 @@ | ||||
| From 25d15dee34a1a40d5fd71636a205e3211f09fd1d Mon Sep 17 00:00:00 2001 | ||||
| From: Daniel Golle <daniel@makrotopia.org> | ||||
| Date: Mon, 3 Apr 2023 02:18:28 +0100 | ||||
| Subject: [PATCH 10/16] net: dsa: mt7530: move p5_intf_modes() function to | ||||
|  mt7530.c | ||||
|  | ||||
| In preparation of splitting mt7530.c into a driver for MDIO-connected | ||||
| as well as MDIO-accessed built-in switches on one hand and MMIO-accessed | ||||
| built-in switches move the p5_inft_modes() function from mt7530.h to | ||||
| mt7530.c. The function is only needed there and will trigger a compiler | ||||
| warning about a defined but unused function otherwise when including | ||||
| mt7530.h in the to-be-introduced bus-specific drivers. | ||||
|  | ||||
| Signed-off-by: Daniel Golle <daniel@makrotopia.org> | ||||
| Reviewed-by: Andrew Lunn <andrew@lunn.ch> | ||||
| Signed-off-by: David S. Miller <davem@davemloft.net> | ||||
| --- | ||||
|  drivers/net/dsa/mt7530.c | 18 ++++++++++++++++++ | ||||
|  drivers/net/dsa/mt7530.h | 18 ------------------ | ||||
|  2 files changed, 18 insertions(+), 18 deletions(-) | ||||
|  | ||||
| --- a/drivers/net/dsa/mt7530.c | ||||
| +++ b/drivers/net/dsa/mt7530.c | ||||
| @@ -950,6 +950,24 @@ mt7530_set_ageing_time(struct dsa_switch | ||||
|  	return 0; | ||||
|  } | ||||
|   | ||||
| +static const char *p5_intf_modes(unsigned int p5_interface) | ||||
| +{ | ||||
| +	switch (p5_interface) { | ||||
| +	case P5_DISABLED: | ||||
| +		return "DISABLED"; | ||||
| +	case P5_INTF_SEL_PHY_P0: | ||||
| +		return "PHY P0"; | ||||
| +	case P5_INTF_SEL_PHY_P4: | ||||
| +		return "PHY P4"; | ||||
| +	case P5_INTF_SEL_GMAC5: | ||||
| +		return "GMAC5"; | ||||
| +	case P5_INTF_SEL_GMAC5_SGMII: | ||||
| +		return "GMAC5_SGMII"; | ||||
| +	default: | ||||
| +		return "unknown"; | ||||
| +	} | ||||
| +} | ||||
| + | ||||
|  static void mt7530_setup_port5(struct dsa_switch *ds, phy_interface_t interface) | ||||
|  { | ||||
|  	struct mt7530_priv *priv = ds->priv; | ||||
| --- a/drivers/net/dsa/mt7530.h | ||||
| +++ b/drivers/net/dsa/mt7530.h | ||||
| @@ -682,24 +682,6 @@ enum p5_interface_select { | ||||
|  	P5_INTF_SEL_GMAC5_SGMII, | ||||
|  }; | ||||
|   | ||||
| -static const char *p5_intf_modes(unsigned int p5_interface) | ||||
| -{ | ||||
| -	switch (p5_interface) { | ||||
| -	case P5_DISABLED: | ||||
| -		return "DISABLED"; | ||||
| -	case P5_INTF_SEL_PHY_P0: | ||||
| -		return "PHY P0"; | ||||
| -	case P5_INTF_SEL_PHY_P4: | ||||
| -		return "PHY P4"; | ||||
| -	case P5_INTF_SEL_GMAC5: | ||||
| -		return "GMAC5"; | ||||
| -	case P5_INTF_SEL_GMAC5_SGMII: | ||||
| -		return "GMAC5_SGMII"; | ||||
| -	default: | ||||
| -		return "unknown"; | ||||
| -	} | ||||
| -} | ||||
| - | ||||
|  struct mt7530_priv; | ||||
|   | ||||
|  struct mt753x_pcs { | ||||
| @@ -0,0 +1,155 @@ | ||||
| From 37c9c0d8d0b2e24f8c9af72ecd4edd31537284d3 Mon Sep 17 00:00:00 2001 | ||||
| From: Daniel Golle <daniel@makrotopia.org> | ||||
| Date: Mon, 3 Apr 2023 02:18:39 +0100 | ||||
| Subject: [PATCH 11/16] net: dsa: mt7530: introduce mt7530_probe_common helper | ||||
|  function | ||||
|  | ||||
| Move commonly used parts from mt7530_probe into new mt7530_probe_common | ||||
| helper function which will be used by both, mt7530_probe and the | ||||
| to-be-introduced mt7988_probe. | ||||
|  | ||||
| Signed-off-by: Daniel Golle <daniel@makrotopia.org> | ||||
| Reviewed-by: Andrew Lunn <andrew@lunn.ch> | ||||
| Signed-off-by: David S. Miller <davem@davemloft.net> | ||||
| --- | ||||
|  drivers/net/dsa/mt7530.c | 98 ++++++++++++++++++++++------------------ | ||||
|  1 file changed, 54 insertions(+), 44 deletions(-) | ||||
|  | ||||
| --- a/drivers/net/dsa/mt7530.c | ||||
| +++ b/drivers/net/dsa/mt7530.c | ||||
| @@ -3135,44 +3135,21 @@ static const struct of_device_id mt7530_ | ||||
|  MODULE_DEVICE_TABLE(of, mt7530_of_match); | ||||
|   | ||||
|  static int | ||||
| -mt7530_probe(struct mdio_device *mdiodev) | ||||
| +mt7530_probe_common(struct mt7530_priv *priv) | ||||
|  { | ||||
| -	static struct regmap_config *regmap_config; | ||||
| -	struct mt7530_priv *priv; | ||||
| -	struct device_node *dn; | ||||
| -	int ret; | ||||
| +	struct device *dev = priv->dev; | ||||
|   | ||||
| -	dn = mdiodev->dev.of_node; | ||||
| - | ||||
| -	priv = devm_kzalloc(&mdiodev->dev, sizeof(*priv), GFP_KERNEL); | ||||
| -	if (!priv) | ||||
| -		return -ENOMEM; | ||||
| - | ||||
| -	priv->ds = devm_kzalloc(&mdiodev->dev, sizeof(*priv->ds), GFP_KERNEL); | ||||
| +	priv->ds = devm_kzalloc(dev, sizeof(*priv->ds), GFP_KERNEL); | ||||
|  	if (!priv->ds) | ||||
|  		return -ENOMEM; | ||||
|   | ||||
| -	priv->ds->dev = &mdiodev->dev; | ||||
| +	priv->ds->dev = dev; | ||||
|  	priv->ds->num_ports = MT7530_NUM_PORTS; | ||||
|   | ||||
| -	/* Use medatek,mcm property to distinguish hardware type that would | ||||
| -	 * casues a little bit differences on power-on sequence. | ||||
| -	 */ | ||||
| -	priv->mcm = of_property_read_bool(dn, "mediatek,mcm"); | ||||
| -	if (priv->mcm) { | ||||
| -		dev_info(&mdiodev->dev, "MT7530 adapts as multi-chip module\n"); | ||||
| - | ||||
| -		priv->rstc = devm_reset_control_get(&mdiodev->dev, "mcm"); | ||||
| -		if (IS_ERR(priv->rstc)) { | ||||
| -			dev_err(&mdiodev->dev, "Couldn't get our reset line\n"); | ||||
| -			return PTR_ERR(priv->rstc); | ||||
| -		} | ||||
| -	} | ||||
| - | ||||
|  	/* Get the hardware identifier from the devicetree node. | ||||
|  	 * We will need it for some of the clock and regulator setup. | ||||
|  	 */ | ||||
| -	priv->info = of_device_get_match_data(&mdiodev->dev); | ||||
| +	priv->info = of_device_get_match_data(dev); | ||||
|  	if (!priv->info) | ||||
|  		return -EINVAL; | ||||
|   | ||||
| @@ -3186,23 +3163,53 @@ mt7530_probe(struct mdio_device *mdiodev | ||||
|  		return -EINVAL; | ||||
|   | ||||
|  	priv->id = priv->info->id; | ||||
| +	priv->dev = dev; | ||||
| +	priv->ds->priv = priv; | ||||
| +	priv->ds->ops = &mt7530_switch_ops; | ||||
| +	mutex_init(&priv->reg_mutex); | ||||
| +	dev_set_drvdata(dev, priv); | ||||
|   | ||||
| -	if (priv->id == ID_MT7530) { | ||||
| -		priv->core_pwr = devm_regulator_get(&mdiodev->dev, "core"); | ||||
| -		if (IS_ERR(priv->core_pwr)) | ||||
| -			return PTR_ERR(priv->core_pwr); | ||||
| +	return 0; | ||||
| +} | ||||
|   | ||||
| -		priv->io_pwr = devm_regulator_get(&mdiodev->dev, "io"); | ||||
| -		if (IS_ERR(priv->io_pwr)) | ||||
| -			return PTR_ERR(priv->io_pwr); | ||||
| -	} | ||||
| +static int | ||||
| +mt7530_probe(struct mdio_device *mdiodev) | ||||
| +{ | ||||
| +	static struct regmap_config *regmap_config; | ||||
| +	struct mt7530_priv *priv; | ||||
| +	struct device_node *dn; | ||||
| +	int ret; | ||||
| + | ||||
| +	dn = mdiodev->dev.of_node; | ||||
| + | ||||
| +	priv = devm_kzalloc(&mdiodev->dev, sizeof(*priv), GFP_KERNEL); | ||||
| +	if (!priv) | ||||
| +		return -ENOMEM; | ||||
|   | ||||
| -	/* Not MCM that indicates switch works as the remote standalone | ||||
| +	priv->bus = mdiodev->bus; | ||||
| +	priv->dev = &mdiodev->dev; | ||||
| + | ||||
| +	ret = mt7530_probe_common(priv); | ||||
| +	if (ret) | ||||
| +		return ret; | ||||
| + | ||||
| +	/* Use medatek,mcm property to distinguish hardware type that would | ||||
| +	 * cause a little bit differences on power-on sequence. | ||||
| +	 * Not MCM that indicates switch works as the remote standalone | ||||
|  	 * integrated circuit so the GPIO pin would be used to complete | ||||
|  	 * the reset, otherwise memory-mapped register accessing used | ||||
|  	 * through syscon provides in the case of MCM. | ||||
|  	 */ | ||||
| -	if (!priv->mcm) { | ||||
| +	priv->mcm = of_property_read_bool(dn, "mediatek,mcm"); | ||||
| +	if (priv->mcm) { | ||||
| +		dev_info(&mdiodev->dev, "MT7530 adapts as multi-chip module\n"); | ||||
| + | ||||
| +		priv->rstc = devm_reset_control_get(&mdiodev->dev, "mcm"); | ||||
| +		if (IS_ERR(priv->rstc)) { | ||||
| +			dev_err(&mdiodev->dev, "Couldn't get our reset line\n"); | ||||
| +			return PTR_ERR(priv->rstc); | ||||
| +		} | ||||
| +	} else { | ||||
|  		priv->reset = devm_gpiod_get_optional(&mdiodev->dev, "reset", | ||||
|  						      GPIOD_OUT_LOW); | ||||
|  		if (IS_ERR(priv->reset)) { | ||||
| @@ -3211,12 +3218,15 @@ mt7530_probe(struct mdio_device *mdiodev | ||||
|  		} | ||||
|  	} | ||||
|   | ||||
| -	priv->bus = mdiodev->bus; | ||||
| -	priv->dev = &mdiodev->dev; | ||||
| -	priv->ds->priv = priv; | ||||
| -	priv->ds->ops = &mt7530_switch_ops; | ||||
| -	mutex_init(&priv->reg_mutex); | ||||
| -	dev_set_drvdata(&mdiodev->dev, priv); | ||||
| +	if (priv->id == ID_MT7530) { | ||||
| +		priv->core_pwr = devm_regulator_get(&mdiodev->dev, "core"); | ||||
| +		if (IS_ERR(priv->core_pwr)) | ||||
| +			return PTR_ERR(priv->core_pwr); | ||||
| + | ||||
| +		priv->io_pwr = devm_regulator_get(&mdiodev->dev, "io"); | ||||
| +		if (IS_ERR(priv->io_pwr)) | ||||
| +			return PTR_ERR(priv->io_pwr); | ||||
| +	} | ||||
|   | ||||
|  	regmap_config = devm_kzalloc(&mdiodev->dev, sizeof(*regmap_config), | ||||
|  				     GFP_KERNEL); | ||||
| @@ -0,0 +1,55 @@ | ||||
| From 720d736351761574af02ed093658ab60de60576c Mon Sep 17 00:00:00 2001 | ||||
| From: Daniel Golle <daniel@makrotopia.org> | ||||
| Date: Mon, 3 Apr 2023 02:18:50 +0100 | ||||
| Subject: [PATCH 12/16] net: dsa: mt7530: introduce mt7530_remove_common helper | ||||
|  function | ||||
|  | ||||
| Move commonly used parts from mt7530_remove into new | ||||
| mt7530_remove_common helper function which will be used by both, | ||||
| mt7530_remove and the to-be-introduced mt7988_remove. | ||||
|  | ||||
| Signed-off-by: Daniel Golle <daniel@makrotopia.org> | ||||
| Reviewed-by: Andrew Lunn <andrew@lunn.ch> | ||||
| Signed-off-by: David S. Miller <davem@davemloft.net> | ||||
| --- | ||||
|  drivers/net/dsa/mt7530.c | 18 ++++++++++++------ | ||||
|  1 file changed, 12 insertions(+), 6 deletions(-) | ||||
|  | ||||
| --- a/drivers/net/dsa/mt7530.c | ||||
| +++ b/drivers/net/dsa/mt7530.c | ||||
| @@ -3253,6 +3253,17 @@ mt7530_probe(struct mdio_device *mdiodev | ||||
|  } | ||||
|   | ||||
|  static void | ||||
| +mt7530_remove_common(struct mt7530_priv *priv) | ||||
| +{ | ||||
| +	if (priv->irq) | ||||
| +		mt7530_free_irq(priv); | ||||
| + | ||||
| +	dsa_unregister_switch(priv->ds); | ||||
| + | ||||
| +	mutex_destroy(&priv->reg_mutex); | ||||
| +} | ||||
| + | ||||
| +static void | ||||
|  mt7530_remove(struct mdio_device *mdiodev) | ||||
|  { | ||||
|  	struct mt7530_priv *priv = dev_get_drvdata(&mdiodev->dev); | ||||
| @@ -3271,16 +3282,11 @@ mt7530_remove(struct mdio_device *mdiode | ||||
|  		dev_err(priv->dev, "Failed to disable io pwr: %d\n", | ||||
|  			ret); | ||||
|   | ||||
| -	if (priv->irq) | ||||
| -		mt7530_free_irq(priv); | ||||
| - | ||||
| -	dsa_unregister_switch(priv->ds); | ||||
| +	mt7530_remove_common(priv); | ||||
|   | ||||
|  	for (i = 0; i < 2; ++i) | ||||
|  		mtk_pcs_lynxi_destroy(priv->ports[5 + i].sgmii_pcs); | ||||
|   | ||||
| -	mutex_destroy(&priv->reg_mutex); | ||||
| - | ||||
|  	dev_set_drvdata(&mdiodev->dev, NULL); | ||||
|  } | ||||
|   | ||||
| @@ -0,0 +1,143 @@ | ||||
| From 7f54cc9772ced2d76ac11832f0ada43798443ac9 Mon Sep 17 00:00:00 2001 | ||||
| From: Daniel Golle <daniel@makrotopia.org> | ||||
| Date: Mon, 3 Apr 2023 02:19:02 +0100 | ||||
| Subject: [PATCH 13/16] net: dsa: mt7530: split-off common parts from | ||||
|  mt7531_setup | ||||
|  | ||||
| MT7988 shares a significant part of the setup function with MT7531. | ||||
| Split-off those parts into a shared function which is going to be used | ||||
| also by mt7988_setup. | ||||
|  | ||||
| Signed-off-by: Daniel Golle <daniel@makrotopia.org> | ||||
| Reviewed-by: Andrew Lunn <andrew@lunn.ch> | ||||
| Signed-off-by: David S. Miller <davem@davemloft.net> | ||||
| --- | ||||
|  drivers/net/dsa/mt7530.c | 99 ++++++++++++++++++++++------------------ | ||||
|  1 file changed, 55 insertions(+), 44 deletions(-) | ||||
|  | ||||
| --- a/drivers/net/dsa/mt7530.c | ||||
| +++ b/drivers/net/dsa/mt7530.c | ||||
| @@ -2348,11 +2348,64 @@ mt7530_setup(struct dsa_switch *ds) | ||||
|  } | ||||
|   | ||||
|  static int | ||||
| +mt7531_setup_common(struct dsa_switch *ds) | ||||
| +{ | ||||
| +	struct mt7530_priv *priv = ds->priv; | ||||
| +	struct dsa_port *cpu_dp; | ||||
| +	int ret, i; | ||||
| + | ||||
| +	/* BPDU to CPU port */ | ||||
| +	dsa_switch_for_each_cpu_port(cpu_dp, ds) { | ||||
| +		mt7530_rmw(priv, MT7531_CFC, MT7531_CPU_PMAP_MASK, | ||||
| +			   BIT(cpu_dp->index)); | ||||
| +		break; | ||||
| +	} | ||||
| +	mt7530_rmw(priv, MT753X_BPC, MT753X_BPDU_PORT_FW_MASK, | ||||
| +		   MT753X_BPDU_CPU_ONLY); | ||||
| + | ||||
| +	/* Enable and reset MIB counters */ | ||||
| +	mt7530_mib_reset(ds); | ||||
| + | ||||
| +	for (i = 0; i < MT7530_NUM_PORTS; i++) { | ||||
| +		/* Disable forwarding by default on all ports */ | ||||
| +		mt7530_rmw(priv, MT7530_PCR_P(i), PCR_MATRIX_MASK, | ||||
| +			   PCR_MATRIX_CLR); | ||||
| + | ||||
| +		/* Disable learning by default on all ports */ | ||||
| +		mt7530_set(priv, MT7530_PSC_P(i), SA_DIS); | ||||
| + | ||||
| +		mt7530_set(priv, MT7531_DBG_CNT(i), MT7531_DIS_CLR); | ||||
| + | ||||
| +		if (dsa_is_cpu_port(ds, i)) { | ||||
| +			ret = mt753x_cpu_port_enable(ds, i); | ||||
| +			if (ret) | ||||
| +				return ret; | ||||
| +		} else { | ||||
| +			mt7530_port_disable(ds, i); | ||||
| + | ||||
| +			/* Set default PVID to 0 on all user ports */ | ||||
| +			mt7530_rmw(priv, MT7530_PPBV1_P(i), G0_PORT_VID_MASK, | ||||
| +				   G0_PORT_VID_DEF); | ||||
| +		} | ||||
| + | ||||
| +		/* Enable consistent egress tag */ | ||||
| +		mt7530_rmw(priv, MT7530_PVC_P(i), PVC_EG_TAG_MASK, | ||||
| +			   PVC_EG_TAG(MT7530_VLAN_EG_CONSISTENT)); | ||||
| +	} | ||||
| + | ||||
| +	/* Flush the FDB table */ | ||||
| +	ret = mt7530_fdb_cmd(priv, MT7530_FDB_FLUSH, NULL); | ||||
| +	if (ret < 0) | ||||
| +		return ret; | ||||
| + | ||||
| +	return 0; | ||||
| +} | ||||
| + | ||||
| +static int | ||||
|  mt7531_setup(struct dsa_switch *ds) | ||||
|  { | ||||
|  	struct mt7530_priv *priv = ds->priv; | ||||
|  	struct mt7530_dummy_poll p; | ||||
| -	struct dsa_port *cpu_dp; | ||||
|  	u32 val, id; | ||||
|  	int ret, i; | ||||
|   | ||||
| @@ -2426,44 +2479,7 @@ mt7531_setup(struct dsa_switch *ds) | ||||
|  	mt7531_ind_c45_phy_write(priv, MT753X_CTRL_PHY_ADDR, MDIO_MMD_VEND2, | ||||
|  				 CORE_PLL_GROUP4, val); | ||||
|   | ||||
| -	/* BPDU to CPU port */ | ||||
| -	dsa_switch_for_each_cpu_port(cpu_dp, ds) { | ||||
| -		mt7530_rmw(priv, MT7531_CFC, MT7531_CPU_PMAP_MASK, | ||||
| -			   BIT(cpu_dp->index)); | ||||
| -		break; | ||||
| -	} | ||||
| -	mt7530_rmw(priv, MT753X_BPC, MT753X_BPDU_PORT_FW_MASK, | ||||
| -		   MT753X_BPDU_CPU_ONLY); | ||||
| - | ||||
| -	/* Enable and reset MIB counters */ | ||||
| -	mt7530_mib_reset(ds); | ||||
| - | ||||
| -	for (i = 0; i < MT7530_NUM_PORTS; i++) { | ||||
| -		/* Disable forwarding by default on all ports */ | ||||
| -		mt7530_rmw(priv, MT7530_PCR_P(i), PCR_MATRIX_MASK, | ||||
| -			   PCR_MATRIX_CLR); | ||||
| - | ||||
| -		/* Disable learning by default on all ports */ | ||||
| -		mt7530_set(priv, MT7530_PSC_P(i), SA_DIS); | ||||
| - | ||||
| -		mt7530_set(priv, MT7531_DBG_CNT(i), MT7531_DIS_CLR); | ||||
| - | ||||
| -		if (dsa_is_cpu_port(ds, i)) { | ||||
| -			ret = mt753x_cpu_port_enable(ds, i); | ||||
| -			if (ret) | ||||
| -				return ret; | ||||
| -		} else { | ||||
| -			mt7530_port_disable(ds, i); | ||||
| - | ||||
| -			/* Set default PVID to 0 on all user ports */ | ||||
| -			mt7530_rmw(priv, MT7530_PPBV1_P(i), G0_PORT_VID_MASK, | ||||
| -				   G0_PORT_VID_DEF); | ||||
| -		} | ||||
| - | ||||
| -		/* Enable consistent egress tag */ | ||||
| -		mt7530_rmw(priv, MT7530_PVC_P(i), PVC_EG_TAG_MASK, | ||||
| -			   PVC_EG_TAG(MT7530_VLAN_EG_CONSISTENT)); | ||||
| -	} | ||||
| +	mt7531_setup_common(ds); | ||||
|   | ||||
|  	/* Setup VLAN ID 0 for VLAN-unaware bridges */ | ||||
|  	ret = mt7530_setup_vlan0(priv); | ||||
| @@ -2473,11 +2489,6 @@ mt7531_setup(struct dsa_switch *ds) | ||||
|  	ds->assisted_learning_on_cpu_port = true; | ||||
|  	ds->mtu_enforcement_ingress = true; | ||||
|   | ||||
| -	/* Flush the FDB table */ | ||||
| -	ret = mt7530_fdb_cmd(priv, MT7530_FDB_FLUSH, NULL); | ||||
| -	if (ret < 0) | ||||
| -		return ret; | ||||
| - | ||||
|  	return 0; | ||||
|  } | ||||
|   | ||||
| @@ -0,0 +1,692 @@ | ||||
| From cb675afcddbbeb2bfa6596e3bc236bc026cd425f Mon Sep 17 00:00:00 2001 | ||||
| From: Daniel Golle <daniel@makrotopia.org> | ||||
| Date: Mon, 3 Apr 2023 02:19:13 +0100 | ||||
| Subject: [PATCH 14/16] net: dsa: mt7530: introduce separate MDIO driver | ||||
|  | ||||
| Split MT7530 switch driver into a common part and a part specific | ||||
| for MDIO connected switches and multi-chip modules. | ||||
| Move MDIO-specific functions to newly introduced mt7530-mdio.c while | ||||
| keeping the common parts in mt7530.c. | ||||
| Introduce new Kconfig symbol CONFIG_NET_DSA_MT7530_MDIO which is | ||||
| implied by CONFIG_NET_DSA_MT7530. | ||||
|  | ||||
| Signed-off-by: Daniel Golle <daniel@makrotopia.org> | ||||
| Reviewed-by: Andrew Lunn <andrew@lunn.ch> | ||||
| Signed-off-by: David S. Miller <davem@davemloft.net> | ||||
| --- | ||||
|  MAINTAINERS                   |   1 + | ||||
|  drivers/net/dsa/Kconfig       |  15 +- | ||||
|  drivers/net/dsa/Makefile      |   1 + | ||||
|  drivers/net/dsa/mt7530-mdio.c | 271 ++++++++++++++++++++++++++++++++++ | ||||
|  drivers/net/dsa/mt7530.c      | 264 +-------------------------------- | ||||
|  drivers/net/dsa/mt7530.h      |   6 + | ||||
|  6 files changed, 300 insertions(+), 258 deletions(-) | ||||
|  create mode 100644 drivers/net/dsa/mt7530-mdio.c | ||||
|  | ||||
| --- a/MAINTAINERS | ||||
| +++ b/MAINTAINERS | ||||
| @@ -11901,6 +11901,7 @@ M:	Landen Chao <Landen.Chao@mediatek.com | ||||
|  M:	DENG Qingfang <dqfext@gmail.com> | ||||
|  L:	netdev@vger.kernel.org | ||||
|  S:	Maintained | ||||
| +F:	drivers/net/dsa/mt7530-mdio.c | ||||
|  F:	drivers/net/dsa/mt7530.* | ||||
|  F:	net/dsa/tag_mtk.c | ||||
|   | ||||
| --- a/drivers/net/dsa/Kconfig | ||||
| +++ b/drivers/net/dsa/Kconfig | ||||
| @@ -37,10 +37,22 @@ config NET_DSA_MT7530 | ||||
|  	tristate "MediaTek MT753x and MT7621 Ethernet switch support" | ||||
|  	select NET_DSA_TAG_MTK | ||||
|  	select MEDIATEK_GE_PHY | ||||
| +	imply NET_DSA_MT7530_MDIO | ||||
| +	help | ||||
| +	  This enables support for the MediaTek MT7530 and MT7531 Ethernet | ||||
| +	  switch chips. Multi-chip module MT7530 in MT7621AT, MT7621DAT, | ||||
| +	  MT7621ST and MT7623AI SoCs, and built-in switch in MT7988 SoC are | ||||
| +	  supported as well. | ||||
| + | ||||
| +config NET_DSA_MT7530_MDIO | ||||
| +	tristate "MediaTek MT7530 MDIO interface driver" | ||||
| +	depends on NET_DSA_MT7530 | ||||
|  	select PCS_MTK_LYNXI | ||||
|  	help | ||||
| -	  This enables support for the MediaTek MT7530, MT7531, and MT7621 | ||||
| -	  Ethernet switch chips. | ||||
| +	  This enables support for the MediaTek MT7530 and MT7531 switch | ||||
| +	  chips which are connected via MDIO, as well as multi-chip | ||||
| +	  module MT7530 which can be found in the MT7621AT, MT7621DAT, | ||||
| +	  MT7621ST and MT7623AI SoCs. | ||||
|   | ||||
|  config NET_DSA_MV88E6060 | ||||
|  	tristate "Marvell 88E6060 ethernet switch chip support" | ||||
| --- a/drivers/net/dsa/Makefile | ||||
| +++ b/drivers/net/dsa/Makefile | ||||
| @@ -7,6 +7,7 @@ obj-$(CONFIG_FIXED_PHY)		+= dsa_loop_bdi | ||||
|  endif | ||||
|  obj-$(CONFIG_NET_DSA_LANTIQ_GSWIP) += lantiq_gswip.o | ||||
|  obj-$(CONFIG_NET_DSA_MT7530)	+= mt7530.o | ||||
| +obj-$(CONFIG_NET_DSA_MT7530_MDIO) += mt7530-mdio.o | ||||
|  obj-$(CONFIG_NET_DSA_MV88E6060) += mv88e6060.o | ||||
|  obj-$(CONFIG_NET_DSA_REALTEK_SMI) += realtek-smi.o | ||||
|  realtek-smi-objs		:= realtek-smi-core.o rtl8366.o rtl8366rb.o | ||||
| --- /dev/null | ||||
| +++ b/drivers/net/dsa/mt7530-mdio.c | ||||
| @@ -0,0 +1,271 @@ | ||||
| +// SPDX-License-Identifier: GPL-2.0-only | ||||
| + | ||||
| +#include <linux/gpio/consumer.h> | ||||
| +#include <linux/mdio.h> | ||||
| +#include <linux/module.h> | ||||
| +#include <linux/pcs/pcs-mtk-lynxi.h> | ||||
| +#include <linux/of_irq.h> | ||||
| +#include <linux/of_mdio.h> | ||||
| +#include <linux/of_net.h> | ||||
| +#include <linux/of_platform.h> | ||||
| +#include <linux/regmap.h> | ||||
| +#include <linux/reset.h> | ||||
| +#include <linux/regulator/consumer.h> | ||||
| +#include <net/dsa.h> | ||||
| + | ||||
| +#include "mt7530.h" | ||||
| + | ||||
| +static int | ||||
| +mt7530_regmap_write(void *context, unsigned int reg, unsigned int val) | ||||
| +{ | ||||
| +	struct mii_bus *bus = context; | ||||
| +	u16 page, r, lo, hi; | ||||
| +	int ret; | ||||
| + | ||||
| +	page = (reg >> 6) & 0x3ff; | ||||
| +	r  = (reg >> 2) & 0xf; | ||||
| +	lo = val & 0xffff; | ||||
| +	hi = val >> 16; | ||||
| + | ||||
| +	/* MT7530 uses 31 as the pseudo port */ | ||||
| +	ret = bus->write(bus, 0x1f, 0x1f, page); | ||||
| +	if (ret < 0) | ||||
| +		return ret; | ||||
| + | ||||
| +	ret = bus->write(bus, 0x1f, r,  lo); | ||||
| +	if (ret < 0) | ||||
| +		return ret; | ||||
| + | ||||
| +	ret = bus->write(bus, 0x1f, 0x10, hi); | ||||
| +	return ret; | ||||
| +} | ||||
| + | ||||
| +static int | ||||
| +mt7530_regmap_read(void *context, unsigned int reg, unsigned int *val) | ||||
| +{ | ||||
| +	struct mii_bus *bus = context; | ||||
| +	u16 page, r, lo, hi; | ||||
| +	int ret; | ||||
| + | ||||
| +	page = (reg >> 6) & 0x3ff; | ||||
| +	r = (reg >> 2) & 0xf; | ||||
| + | ||||
| +	/* MT7530 uses 31 as the pseudo port */ | ||||
| +	ret = bus->write(bus, 0x1f, 0x1f, page); | ||||
| +	if (ret < 0) | ||||
| +		return ret; | ||||
| + | ||||
| +	lo = bus->read(bus, 0x1f, r); | ||||
| +	hi = bus->read(bus, 0x1f, 0x10); | ||||
| + | ||||
| +	*val = (hi << 16) | (lo & 0xffff); | ||||
| + | ||||
| +	return 0; | ||||
| +} | ||||
| + | ||||
| +static void | ||||
| +mt7530_mdio_regmap_lock(void *mdio_lock) | ||||
| +{ | ||||
| +	mutex_lock_nested(mdio_lock, MDIO_MUTEX_NESTED); | ||||
| +} | ||||
| + | ||||
| +static void | ||||
| +mt7530_mdio_regmap_unlock(void *mdio_lock) | ||||
| +{ | ||||
| +	mutex_unlock(mdio_lock); | ||||
| +} | ||||
| + | ||||
| +static const struct regmap_bus mt7530_regmap_bus = { | ||||
| +	.reg_write = mt7530_regmap_write, | ||||
| +	.reg_read = mt7530_regmap_read, | ||||
| +}; | ||||
| + | ||||
| +static int | ||||
| +mt7531_create_sgmii(struct mt7530_priv *priv) | ||||
| +{ | ||||
| +	struct regmap_config *mt7531_pcs_config[2]; | ||||
| +	struct phylink_pcs *pcs; | ||||
| +	struct regmap *regmap; | ||||
| +	int i, ret = 0; | ||||
| + | ||||
| +	for (i = 0; i < 2; i++) { | ||||
| +		mt7531_pcs_config[i] = devm_kzalloc(priv->dev, | ||||
| +						    sizeof(struct regmap_config), | ||||
| +						    GFP_KERNEL); | ||||
| +		if (!mt7531_pcs_config[i]) { | ||||
| +			ret = -ENOMEM; | ||||
| +			break; | ||||
| +		} | ||||
| + | ||||
| +		mt7531_pcs_config[i]->name = i ? "port6" : "port5"; | ||||
| +		mt7531_pcs_config[i]->reg_bits = 16; | ||||
| +		mt7531_pcs_config[i]->val_bits = 32; | ||||
| +		mt7531_pcs_config[i]->reg_stride = 4; | ||||
| +		mt7531_pcs_config[i]->reg_base = MT7531_SGMII_REG_BASE(5 + i); | ||||
| +		mt7531_pcs_config[i]->max_register = 0x17c; | ||||
| +		mt7531_pcs_config[i]->lock = mt7530_mdio_regmap_lock; | ||||
| +		mt7531_pcs_config[i]->unlock = mt7530_mdio_regmap_unlock; | ||||
| +		mt7531_pcs_config[i]->lock_arg = &priv->bus->mdio_lock; | ||||
| + | ||||
| +		regmap = devm_regmap_init(priv->dev, | ||||
| +					  &mt7530_regmap_bus, priv->bus, | ||||
| +					  mt7531_pcs_config[i]); | ||||
| +		if (IS_ERR(regmap)) { | ||||
| +			ret = PTR_ERR(regmap); | ||||
| +			break; | ||||
| +		} | ||||
| +		pcs = mtk_pcs_lynxi_create(priv->dev, regmap, | ||||
| +					   MT7531_PHYA_CTRL_SIGNAL3, 0); | ||||
| +		if (!pcs) { | ||||
| +			ret = -ENXIO; | ||||
| +			break; | ||||
| +		} | ||||
| +		priv->ports[5 + i].sgmii_pcs = pcs; | ||||
| +	} | ||||
| + | ||||
| +	if (ret && i) | ||||
| +		mtk_pcs_lynxi_destroy(priv->ports[5].sgmii_pcs); | ||||
| + | ||||
| +	return ret; | ||||
| +} | ||||
| + | ||||
| +static const struct of_device_id mt7530_of_match[] = { | ||||
| +	{ .compatible = "mediatek,mt7621", .data = &mt753x_table[ID_MT7621], }, | ||||
| +	{ .compatible = "mediatek,mt7530", .data = &mt753x_table[ID_MT7530], }, | ||||
| +	{ .compatible = "mediatek,mt7531", .data = &mt753x_table[ID_MT7531], }, | ||||
| +	{ /* sentinel */ }, | ||||
| +}; | ||||
| +MODULE_DEVICE_TABLE(of, mt7530_of_match); | ||||
| + | ||||
| +static int | ||||
| +mt7530_probe(struct mdio_device *mdiodev) | ||||
| +{ | ||||
| +	static struct regmap_config *regmap_config; | ||||
| +	struct mt7530_priv *priv; | ||||
| +	struct device_node *dn; | ||||
| +	int ret; | ||||
| + | ||||
| +	dn = mdiodev->dev.of_node; | ||||
| + | ||||
| +	priv = devm_kzalloc(&mdiodev->dev, sizeof(*priv), GFP_KERNEL); | ||||
| +	if (!priv) | ||||
| +		return -ENOMEM; | ||||
| + | ||||
| +	priv->bus = mdiodev->bus; | ||||
| +	priv->dev = &mdiodev->dev; | ||||
| + | ||||
| +	ret = mt7530_probe_common(priv); | ||||
| +	if (ret) | ||||
| +		return ret; | ||||
| + | ||||
| +	/* Use medatek,mcm property to distinguish hardware type that would | ||||
| +	 * cause a little bit differences on power-on sequence. | ||||
| +	 * Not MCM that indicates switch works as the remote standalone | ||||
| +	 * integrated circuit so the GPIO pin would be used to complete | ||||
| +	 * the reset, otherwise memory-mapped register accessing used | ||||
| +	 * through syscon provides in the case of MCM. | ||||
| +	 */ | ||||
| +	priv->mcm = of_property_read_bool(dn, "mediatek,mcm"); | ||||
| +	if (priv->mcm) { | ||||
| +		dev_info(&mdiodev->dev, "MT7530 adapts as multi-chip module\n"); | ||||
| + | ||||
| +		priv->rstc = devm_reset_control_get(&mdiodev->dev, "mcm"); | ||||
| +		if (IS_ERR(priv->rstc)) { | ||||
| +			dev_err(&mdiodev->dev, "Couldn't get our reset line\n"); | ||||
| +			return PTR_ERR(priv->rstc); | ||||
| +		} | ||||
| +	} else { | ||||
| +		priv->reset = devm_gpiod_get_optional(&mdiodev->dev, "reset", | ||||
| +						      GPIOD_OUT_LOW); | ||||
| +		if (IS_ERR(priv->reset)) { | ||||
| +			dev_err(&mdiodev->dev, "Couldn't get our reset line\n"); | ||||
| +			return PTR_ERR(priv->reset); | ||||
| +		} | ||||
| +	} | ||||
| + | ||||
| +	if (priv->id == ID_MT7530) { | ||||
| +		priv->core_pwr = devm_regulator_get(&mdiodev->dev, "core"); | ||||
| +		if (IS_ERR(priv->core_pwr)) | ||||
| +			return PTR_ERR(priv->core_pwr); | ||||
| + | ||||
| +		priv->io_pwr = devm_regulator_get(&mdiodev->dev, "io"); | ||||
| +		if (IS_ERR(priv->io_pwr)) | ||||
| +			return PTR_ERR(priv->io_pwr); | ||||
| +	} | ||||
| + | ||||
| +	regmap_config = devm_kzalloc(&mdiodev->dev, sizeof(*regmap_config), | ||||
| +				     GFP_KERNEL); | ||||
| +	if (!regmap_config) | ||||
| +		return -ENOMEM; | ||||
| + | ||||
| +	regmap_config->reg_bits = 16; | ||||
| +	regmap_config->val_bits = 32; | ||||
| +	regmap_config->reg_stride = 4; | ||||
| +	regmap_config->max_register = MT7530_CREV; | ||||
| +	regmap_config->disable_locking = true; | ||||
| +	priv->regmap = devm_regmap_init(priv->dev, &mt7530_regmap_bus, | ||||
| +					priv->bus, regmap_config); | ||||
| +	if (IS_ERR(priv->regmap)) | ||||
| +		return PTR_ERR(priv->regmap); | ||||
| + | ||||
| +	if (priv->id == ID_MT7531) { | ||||
| +		ret = mt7531_create_sgmii(priv); | ||||
| +		if (ret) | ||||
| +			return ret; | ||||
| +	} | ||||
| + | ||||
| +	return dsa_register_switch(priv->ds); | ||||
| +} | ||||
| + | ||||
| +static void | ||||
| +mt7530_remove(struct mdio_device *mdiodev) | ||||
| +{ | ||||
| +	struct mt7530_priv *priv = dev_get_drvdata(&mdiodev->dev); | ||||
| +	int ret = 0, i; | ||||
| + | ||||
| +	if (!priv) | ||||
| +		return; | ||||
| + | ||||
| +	ret = regulator_disable(priv->core_pwr); | ||||
| +	if (ret < 0) | ||||
| +		dev_err(priv->dev, | ||||
| +			"Failed to disable core power: %d\n", ret); | ||||
| + | ||||
| +	ret = regulator_disable(priv->io_pwr); | ||||
| +	if (ret < 0) | ||||
| +		dev_err(priv->dev, "Failed to disable io pwr: %d\n", | ||||
| +			ret); | ||||
| + | ||||
| +	mt7530_remove_common(priv); | ||||
| + | ||||
| +	for (i = 0; i < 2; ++i) | ||||
| +		mtk_pcs_lynxi_destroy(priv->ports[5 + i].sgmii_pcs); | ||||
| +} | ||||
| + | ||||
| +static void mt7530_shutdown(struct mdio_device *mdiodev) | ||||
| +{ | ||||
| +	struct mt7530_priv *priv = dev_get_drvdata(&mdiodev->dev); | ||||
| + | ||||
| +	if (!priv) | ||||
| +		return; | ||||
| + | ||||
| +	dsa_switch_shutdown(priv->ds); | ||||
| + | ||||
| +	dev_set_drvdata(&mdiodev->dev, NULL); | ||||
| +} | ||||
| + | ||||
| +static struct mdio_driver mt7530_mdio_driver = { | ||||
| +	.probe  = mt7530_probe, | ||||
| +	.remove = mt7530_remove, | ||||
| +	.shutdown = mt7530_shutdown, | ||||
| +	.mdiodrv.driver = { | ||||
| +		.name = "mt7530-mdio", | ||||
| +		.of_match_table = mt7530_of_match, | ||||
| +	}, | ||||
| +}; | ||||
| + | ||||
| +mdio_module_driver(mt7530_mdio_driver); | ||||
| + | ||||
| +MODULE_AUTHOR("Sean Wang <sean.wang@mediatek.com>"); | ||||
| +MODULE_DESCRIPTION("Driver for Mediatek MT7530 Switch (MDIO)"); | ||||
| +MODULE_LICENSE("GPL"); | ||||
| --- a/drivers/net/dsa/mt7530.c | ||||
| +++ b/drivers/net/dsa/mt7530.c | ||||
| @@ -14,7 +14,6 @@ | ||||
|  #include <linux/of_mdio.h> | ||||
|  #include <linux/of_net.h> | ||||
|  #include <linux/of_platform.h> | ||||
| -#include <linux/pcs/pcs-mtk-lynxi.h> | ||||
|  #include <linux/phylink.h> | ||||
|  #include <linux/regmap.h> | ||||
|  #include <linux/regulator/consumer.h> | ||||
| @@ -192,31 +191,6 @@ core_clear(struct mt7530_priv *priv, u32 | ||||
|  } | ||||
|   | ||||
|  static int | ||||
| -mt7530_regmap_write(void *context, unsigned int reg, unsigned int val) | ||||
| -{ | ||||
| -	struct mii_bus *bus = context; | ||||
| -	u16 page, r, lo, hi; | ||||
| -	int ret; | ||||
| - | ||||
| -	page = (reg >> 6) & 0x3ff; | ||||
| -	r  = (reg >> 2) & 0xf; | ||||
| -	lo = val & 0xffff; | ||||
| -	hi = val >> 16; | ||||
| - | ||||
| -	/* MT7530 uses 31 as the pseudo port */ | ||||
| -	ret = bus->write(bus, 0x1f, 0x1f, page); | ||||
| -	if (ret < 0) | ||||
| -		return ret; | ||||
| - | ||||
| -	ret = bus->write(bus, 0x1f, r,  lo); | ||||
| -	if (ret < 0) | ||||
| -		return ret; | ||||
| - | ||||
| -	ret = bus->write(bus, 0x1f, 0x10, hi); | ||||
| -	return ret; | ||||
| -} | ||||
| - | ||||
| -static int | ||||
|  mt7530_mii_write(struct mt7530_priv *priv, u32 reg, u32 val) | ||||
|  { | ||||
|  	int ret; | ||||
| @@ -230,29 +204,6 @@ mt7530_mii_write(struct mt7530_priv *pri | ||||
|  	return ret; | ||||
|  } | ||||
|   | ||||
| -static int | ||||
| -mt7530_regmap_read(void *context, unsigned int reg, unsigned int *val) | ||||
| -{ | ||||
| -	struct mii_bus *bus = context; | ||||
| -	u16 page, r, lo, hi; | ||||
| -	int ret; | ||||
| - | ||||
| -	page = (reg >> 6) & 0x3ff; | ||||
| -	r = (reg >> 2) & 0xf; | ||||
| - | ||||
| -	/* MT7530 uses 31 as the pseudo port */ | ||||
| -	ret = bus->write(bus, 0x1f, 0x1f, page); | ||||
| -	if (ret < 0) | ||||
| -		return ret; | ||||
| - | ||||
| -	lo = bus->read(bus, 0x1f, r); | ||||
| -	hi = bus->read(bus, 0x1f, 0x10); | ||||
| - | ||||
| -	*val = (hi << 16) | (lo & 0xffff); | ||||
| - | ||||
| -	return 0; | ||||
| -} | ||||
| - | ||||
|  static u32 | ||||
|  mt7530_mii_read(struct mt7530_priv *priv, u32 reg) | ||||
|  { | ||||
| @@ -2944,72 +2895,6 @@ static const struct phylink_pcs_ops mt75 | ||||
|  	.pcs_an_restart = mt7530_pcs_an_restart, | ||||
|  }; | ||||
|   | ||||
| -static void | ||||
| -mt7530_mdio_regmap_lock(void *mdio_lock) | ||||
| -{ | ||||
| -	mutex_lock_nested(mdio_lock, MDIO_MUTEX_NESTED); | ||||
| -} | ||||
| - | ||||
| -static void | ||||
| -mt7530_mdio_regmap_unlock(void *mdio_lock) | ||||
| -{ | ||||
| -	mutex_unlock(mdio_lock); | ||||
| -} | ||||
| - | ||||
| -static const struct regmap_bus mt7530_regmap_bus = { | ||||
| -	.reg_write = mt7530_regmap_write, | ||||
| -	.reg_read = mt7530_regmap_read, | ||||
| -}; | ||||
| - | ||||
| -static int | ||||
| -mt7531_create_sgmii(struct mt7530_priv *priv) | ||||
| -{ | ||||
| -	struct regmap_config *mt7531_pcs_config[2]; | ||||
| -	struct phylink_pcs *pcs; | ||||
| -	struct regmap *regmap; | ||||
| -	int i, ret = 0; | ||||
| - | ||||
| -	for (i = 0; i < 2; i++) { | ||||
| -		mt7531_pcs_config[i] = devm_kzalloc(priv->dev, | ||||
| -						    sizeof(struct regmap_config), | ||||
| -						    GFP_KERNEL); | ||||
| -		if (!mt7531_pcs_config[i]) { | ||||
| -			ret = -ENOMEM; | ||||
| -			break; | ||||
| -		} | ||||
| - | ||||
| -		mt7531_pcs_config[i]->name = i ? "port6" : "port5"; | ||||
| -		mt7531_pcs_config[i]->reg_bits = 16; | ||||
| -		mt7531_pcs_config[i]->val_bits = 32; | ||||
| -		mt7531_pcs_config[i]->reg_stride = 4; | ||||
| -		mt7531_pcs_config[i]->reg_base = MT7531_SGMII_REG_BASE(5 + i); | ||||
| -		mt7531_pcs_config[i]->max_register = 0x17c; | ||||
| -		mt7531_pcs_config[i]->lock = mt7530_mdio_regmap_lock; | ||||
| -		mt7531_pcs_config[i]->unlock = mt7530_mdio_regmap_unlock; | ||||
| -		mt7531_pcs_config[i]->lock_arg = &priv->bus->mdio_lock; | ||||
| - | ||||
| -		regmap = devm_regmap_init(priv->dev, | ||||
| -					  &mt7530_regmap_bus, priv->bus, | ||||
| -					  mt7531_pcs_config[i]); | ||||
| -		if (IS_ERR(regmap)) { | ||||
| -			ret = PTR_ERR(regmap); | ||||
| -			break; | ||||
| -		} | ||||
| -		pcs = mtk_pcs_lynxi_create(priv->dev, regmap, | ||||
| -					   MT7531_PHYA_CTRL_SIGNAL3, 0); | ||||
| -		if (!pcs) { | ||||
| -			ret = -ENXIO; | ||||
| -			break; | ||||
| -		} | ||||
| -		priv->ports[5 + i].sgmii_pcs = pcs; | ||||
| -	} | ||||
| - | ||||
| -	if (ret && i) | ||||
| -		mtk_pcs_lynxi_destroy(priv->ports[5].sgmii_pcs); | ||||
| - | ||||
| -	return ret; | ||||
| -} | ||||
| - | ||||
|  static int | ||||
|  mt753x_setup(struct dsa_switch *ds) | ||||
|  { | ||||
| @@ -3068,7 +2953,7 @@ static int mt753x_set_mac_eee(struct dsa | ||||
|  	return 0; | ||||
|  } | ||||
|   | ||||
| -static const struct dsa_switch_ops mt7530_switch_ops = { | ||||
| +const struct dsa_switch_ops mt7530_switch_ops = { | ||||
|  	.get_tag_protocol	= mtk_get_tag_protocol, | ||||
|  	.setup			= mt753x_setup, | ||||
|  	.get_strings		= mt7530_get_strings, | ||||
| @@ -3102,8 +2987,9 @@ static const struct dsa_switch_ops mt753 | ||||
|  	.get_mac_eee		= mt753x_get_mac_eee, | ||||
|  	.set_mac_eee		= mt753x_set_mac_eee, | ||||
|  }; | ||||
| +EXPORT_SYMBOL_GPL(mt7530_switch_ops); | ||||
|   | ||||
| -static const struct mt753x_info mt753x_table[] = { | ||||
| +const struct mt753x_info mt753x_table[] = { | ||||
|  	[ID_MT7621] = { | ||||
|  		.id = ID_MT7621, | ||||
|  		.pcs_ops = &mt7530_pcs_ops, | ||||
| @@ -3136,16 +3022,9 @@ static const struct mt753x_info mt753x_t | ||||
|  		.mac_port_config = mt7531_mac_config, | ||||
|  	}, | ||||
|  }; | ||||
| +EXPORT_SYMBOL_GPL(mt753x_table); | ||||
|   | ||||
| -static const struct of_device_id mt7530_of_match[] = { | ||||
| -	{ .compatible = "mediatek,mt7621", .data = &mt753x_table[ID_MT7621], }, | ||||
| -	{ .compatible = "mediatek,mt7530", .data = &mt753x_table[ID_MT7530], }, | ||||
| -	{ .compatible = "mediatek,mt7531", .data = &mt753x_table[ID_MT7531], }, | ||||
| -	{ /* sentinel */ }, | ||||
| -}; | ||||
| -MODULE_DEVICE_TABLE(of, mt7530_of_match); | ||||
| - | ||||
| -static int | ||||
| +int | ||||
|  mt7530_probe_common(struct mt7530_priv *priv) | ||||
|  { | ||||
|  	struct device *dev = priv->dev; | ||||
| @@ -3182,88 +3061,9 @@ mt7530_probe_common(struct mt7530_priv * | ||||
|   | ||||
|  	return 0; | ||||
|  } | ||||
| +EXPORT_SYMBOL_GPL(mt7530_probe_common); | ||||
|   | ||||
| -static int | ||||
| -mt7530_probe(struct mdio_device *mdiodev) | ||||
| -{ | ||||
| -	static struct regmap_config *regmap_config; | ||||
| -	struct mt7530_priv *priv; | ||||
| -	struct device_node *dn; | ||||
| -	int ret; | ||||
| - | ||||
| -	dn = mdiodev->dev.of_node; | ||||
| - | ||||
| -	priv = devm_kzalloc(&mdiodev->dev, sizeof(*priv), GFP_KERNEL); | ||||
| -	if (!priv) | ||||
| -		return -ENOMEM; | ||||
| - | ||||
| -	priv->bus = mdiodev->bus; | ||||
| -	priv->dev = &mdiodev->dev; | ||||
| - | ||||
| -	ret = mt7530_probe_common(priv); | ||||
| -	if (ret) | ||||
| -		return ret; | ||||
| - | ||||
| -	/* Use medatek,mcm property to distinguish hardware type that would | ||||
| -	 * cause a little bit differences on power-on sequence. | ||||
| -	 * Not MCM that indicates switch works as the remote standalone | ||||
| -	 * integrated circuit so the GPIO pin would be used to complete | ||||
| -	 * the reset, otherwise memory-mapped register accessing used | ||||
| -	 * through syscon provides in the case of MCM. | ||||
| -	 */ | ||||
| -	priv->mcm = of_property_read_bool(dn, "mediatek,mcm"); | ||||
| -	if (priv->mcm) { | ||||
| -		dev_info(&mdiodev->dev, "MT7530 adapts as multi-chip module\n"); | ||||
| - | ||||
| -		priv->rstc = devm_reset_control_get(&mdiodev->dev, "mcm"); | ||||
| -		if (IS_ERR(priv->rstc)) { | ||||
| -			dev_err(&mdiodev->dev, "Couldn't get our reset line\n"); | ||||
| -			return PTR_ERR(priv->rstc); | ||||
| -		} | ||||
| -	} else { | ||||
| -		priv->reset = devm_gpiod_get_optional(&mdiodev->dev, "reset", | ||||
| -						      GPIOD_OUT_LOW); | ||||
| -		if (IS_ERR(priv->reset)) { | ||||
| -			dev_err(&mdiodev->dev, "Couldn't get our reset line\n"); | ||||
| -			return PTR_ERR(priv->reset); | ||||
| -		} | ||||
| -	} | ||||
| - | ||||
| -	if (priv->id == ID_MT7530) { | ||||
| -		priv->core_pwr = devm_regulator_get(&mdiodev->dev, "core"); | ||||
| -		if (IS_ERR(priv->core_pwr)) | ||||
| -			return PTR_ERR(priv->core_pwr); | ||||
| - | ||||
| -		priv->io_pwr = devm_regulator_get(&mdiodev->dev, "io"); | ||||
| -		if (IS_ERR(priv->io_pwr)) | ||||
| -			return PTR_ERR(priv->io_pwr); | ||||
| -	} | ||||
| - | ||||
| -	regmap_config = devm_kzalloc(&mdiodev->dev, sizeof(*regmap_config), | ||||
| -				     GFP_KERNEL); | ||||
| -	if (!regmap_config) | ||||
| -		return -ENOMEM; | ||||
| - | ||||
| -	regmap_config->reg_bits = 16; | ||||
| -	regmap_config->val_bits = 32; | ||||
| -	regmap_config->reg_stride = 4; | ||||
| -	regmap_config->max_register = MT7530_CREV; | ||||
| -	regmap_config->disable_locking = true; | ||||
| -	priv->regmap = devm_regmap_init(priv->dev, &mt7530_regmap_bus, | ||||
| -					priv->bus, regmap_config); | ||||
| -	if (IS_ERR(priv->regmap)) | ||||
| -		return PTR_ERR(priv->regmap); | ||||
| - | ||||
| -	if (priv->id == ID_MT7531) { | ||||
| -		ret = mt7531_create_sgmii(priv); | ||||
| -		if (ret) | ||||
| -			return ret; | ||||
| -	} | ||||
| - | ||||
| -	return dsa_register_switch(priv->ds); | ||||
| -} | ||||
| - | ||||
| -static void | ||||
| +void | ||||
|  mt7530_remove_common(struct mt7530_priv *priv) | ||||
|  { | ||||
|  	if (priv->irq) | ||||
| @@ -3274,57 +3074,6 @@ mt7530_remove_common(struct mt7530_priv | ||||
|  	mutex_destroy(&priv->reg_mutex); | ||||
|  } | ||||
|   | ||||
| -static void | ||||
| -mt7530_remove(struct mdio_device *mdiodev) | ||||
| -{ | ||||
| -	struct mt7530_priv *priv = dev_get_drvdata(&mdiodev->dev); | ||||
| -	int ret = 0, i; | ||||
| - | ||||
| -	if (!priv) | ||||
| -		return; | ||||
| - | ||||
| -	ret = regulator_disable(priv->core_pwr); | ||||
| -	if (ret < 0) | ||||
| -		dev_err(priv->dev, | ||||
| -			"Failed to disable core power: %d\n", ret); | ||||
| - | ||||
| -	ret = regulator_disable(priv->io_pwr); | ||||
| -	if (ret < 0) | ||||
| -		dev_err(priv->dev, "Failed to disable io pwr: %d\n", | ||||
| -			ret); | ||||
| - | ||||
| -	mt7530_remove_common(priv); | ||||
| - | ||||
| -	for (i = 0; i < 2; ++i) | ||||
| -		mtk_pcs_lynxi_destroy(priv->ports[5 + i].sgmii_pcs); | ||||
| - | ||||
| -	dev_set_drvdata(&mdiodev->dev, NULL); | ||||
| -} | ||||
| - | ||||
| -static void mt7530_shutdown(struct mdio_device *mdiodev) | ||||
| -{ | ||||
| -	struct mt7530_priv *priv = dev_get_drvdata(&mdiodev->dev); | ||||
| - | ||||
| -	if (!priv) | ||||
| -		return; | ||||
| - | ||||
| -	dsa_switch_shutdown(priv->ds); | ||||
| - | ||||
| -	dev_set_drvdata(&mdiodev->dev, NULL); | ||||
| -} | ||||
| - | ||||
| -static struct mdio_driver mt7530_mdio_driver = { | ||||
| -	.probe  = mt7530_probe, | ||||
| -	.remove = mt7530_remove, | ||||
| -	.shutdown = mt7530_shutdown, | ||||
| -	.mdiodrv.driver = { | ||||
| -		.name = "mt7530", | ||||
| -		.of_match_table = mt7530_of_match, | ||||
| -	}, | ||||
| -}; | ||||
| - | ||||
| -mdio_module_driver(mt7530_mdio_driver); | ||||
| - | ||||
|  MODULE_AUTHOR("Sean Wang <sean.wang@mediatek.com>"); | ||||
|  MODULE_DESCRIPTION("Driver for Mediatek MT7530 Switch"); | ||||
|  MODULE_LICENSE("GPL"); | ||||
| --- a/drivers/net/dsa/mt7530.h | ||||
| +++ b/drivers/net/dsa/mt7530.h | ||||
| @@ -807,4 +807,10 @@ static inline void INIT_MT7530_DUMMY_POL | ||||
|  	p->reg = reg; | ||||
|  } | ||||
|   | ||||
| +int mt7530_probe_common(struct mt7530_priv *priv); | ||||
| +void mt7530_remove_common(struct mt7530_priv *priv); | ||||
| + | ||||
| +extern const struct dsa_switch_ops mt7530_switch_ops; | ||||
| +extern const struct mt753x_info mt753x_table[]; | ||||
| + | ||||
|  #endif /* __MT7530_H */ | ||||
| @@ -0,0 +1,47 @@ | ||||
| From 54d4147a121cec5004a673a58572da346e4458f8 Mon Sep 17 00:00:00 2001 | ||||
| From: Daniel Golle <daniel@makrotopia.org> | ||||
| Date: Mon, 3 Apr 2023 02:19:28 +0100 | ||||
| Subject: [PATCH 15/16] net: dsa: mt7530: skip locking if MDIO bus isn't | ||||
|  present | ||||
|  | ||||
| As MT7530 and MT7531 internally use 32-bit wide registers, each access | ||||
| to any register of the switch requires several operations on the MDIO | ||||
| bus. Hence if there is congruent access, e.g. due to PCS or PHY | ||||
| polling, this can mess up and interfere with another ongoing register | ||||
| access sequence. | ||||
|  | ||||
| However, the MDIO bus mutex is only relevant for MDIO-connected | ||||
| switches. Prepare switches which have there registers directly mapped | ||||
| into the SoCs register space via MMIO which do not require such | ||||
| locking. There we can simply use regmap's default locking mechanism. | ||||
|  | ||||
| Hence guard mutex operations to only be performed in case of MDIO | ||||
| connected switches. | ||||
|  | ||||
| Signed-off-by: Daniel Golle <daniel@makrotopia.org> | ||||
| Reviewed-by: Andrew Lunn <andrew@lunn.ch> | ||||
| Signed-off-by: David S. Miller <davem@davemloft.net> | ||||
| --- | ||||
|  drivers/net/dsa/mt7530.c | 6 ++++-- | ||||
|  1 file changed, 4 insertions(+), 2 deletions(-) | ||||
|  | ||||
| --- a/drivers/net/dsa/mt7530.c | ||||
| +++ b/drivers/net/dsa/mt7530.c | ||||
| @@ -144,13 +144,15 @@ err: | ||||
|  static void | ||||
|  mt7530_mutex_lock(struct mt7530_priv *priv) | ||||
|  { | ||||
| -	mutex_lock_nested(&priv->bus->mdio_lock, MDIO_MUTEX_NESTED); | ||||
| +	if (priv->bus) | ||||
| +		mutex_lock_nested(&priv->bus->mdio_lock, MDIO_MUTEX_NESTED); | ||||
|  } | ||||
|   | ||||
|  static void | ||||
|  mt7530_mutex_unlock(struct mt7530_priv *priv) | ||||
|  { | ||||
| -	mutex_unlock(&priv->bus->mdio_lock); | ||||
| +	if (priv->bus) | ||||
| +		mutex_unlock(&priv->bus->mdio_lock); | ||||
|  } | ||||
|   | ||||
|  static void | ||||
| @@ -0,0 +1,421 @@ | ||||
| From 110c18bfed41421edd677935dd33be5e6507ba92 Mon Sep 17 00:00:00 2001 | ||||
| From: Daniel Golle <daniel@makrotopia.org> | ||||
| Date: Mon, 3 Apr 2023 02:19:40 +0100 | ||||
| Subject: [PATCH 16/16] net: dsa: mt7530: introduce driver for MT7988 built-in | ||||
|  switch | ||||
|  | ||||
| Add driver for the built-in Gigabit Ethernet switch which can be found | ||||
| in the MediaTek MT7988 SoC. | ||||
|  | ||||
| The switch shares most of its design with MT7530 and MT7531, but has | ||||
| it's registers mapped into the SoCs register space rather than being | ||||
| connected externally or internally via MDIO. | ||||
|  | ||||
| Introduce a new platform driver to support that. | ||||
|  | ||||
| Signed-off-by: Daniel Golle <daniel@makrotopia.org> | ||||
| Reviewed-by: Andrew Lunn <andrew@lunn.ch> | ||||
| Signed-off-by: David S. Miller <davem@davemloft.net> | ||||
| --- | ||||
|  MAINTAINERS                   |   2 + | ||||
|  drivers/net/dsa/Kconfig       |  12 +++ | ||||
|  drivers/net/dsa/Makefile      |   1 + | ||||
|  drivers/net/dsa/mt7530-mmio.c | 101 +++++++++++++++++++++++++ | ||||
|  drivers/net/dsa/mt7530.c      | 137 +++++++++++++++++++++++++++++++++- | ||||
|  drivers/net/dsa/mt7530.h      |  12 +-- | ||||
|  6 files changed, 255 insertions(+), 10 deletions(-) | ||||
|  create mode 100644 drivers/net/dsa/mt7530-mmio.c | ||||
|  | ||||
| --- a/MAINTAINERS | ||||
| +++ b/MAINTAINERS | ||||
| @@ -11899,9 +11899,11 @@ MEDIATEK SWITCH DRIVER | ||||
|  M:	Sean Wang <sean.wang@mediatek.com> | ||||
|  M:	Landen Chao <Landen.Chao@mediatek.com> | ||||
|  M:	DENG Qingfang <dqfext@gmail.com> | ||||
| +M:	Daniel Golle <daniel@makrotopia.org> | ||||
|  L:	netdev@vger.kernel.org | ||||
|  S:	Maintained | ||||
|  F:	drivers/net/dsa/mt7530-mdio.c | ||||
| +F:	drivers/net/dsa/mt7530-mmio.c | ||||
|  F:	drivers/net/dsa/mt7530.* | ||||
|  F:	net/dsa/tag_mtk.c | ||||
|   | ||||
| --- a/drivers/net/dsa/Kconfig | ||||
| +++ b/drivers/net/dsa/Kconfig | ||||
| @@ -38,6 +38,7 @@ config NET_DSA_MT7530 | ||||
|  	select NET_DSA_TAG_MTK | ||||
|  	select MEDIATEK_GE_PHY | ||||
|  	imply NET_DSA_MT7530_MDIO | ||||
| +	imply NET_DSA_MT7530_MMIO | ||||
|  	help | ||||
|  	  This enables support for the MediaTek MT7530 and MT7531 Ethernet | ||||
|  	  switch chips. Multi-chip module MT7530 in MT7621AT, MT7621DAT, | ||||
| @@ -54,6 +55,17 @@ config NET_DSA_MT7530_MDIO | ||||
|  	  module MT7530 which can be found in the MT7621AT, MT7621DAT, | ||||
|  	  MT7621ST and MT7623AI SoCs. | ||||
|   | ||||
| +config NET_DSA_MT7530_MMIO | ||||
| +	tristate "MediaTek MT7530 MMIO interface driver" | ||||
| +	depends on NET_DSA_MT7530 | ||||
| +	depends on HAS_IOMEM | ||||
| +	help | ||||
| +	  This enables support for the built-in Ethernet switch found | ||||
| +	  in the MediaTek MT7988 SoC. | ||||
| +	  The switch is a similar design as MT7531, but the switch registers | ||||
| +	  are directly mapped into the SoCs register space rather than being | ||||
| +	  accessible via MDIO. | ||||
| + | ||||
|  config NET_DSA_MV88E6060 | ||||
|  	tristate "Marvell 88E6060 ethernet switch chip support" | ||||
|  	select NET_DSA_TAG_TRAILER | ||||
| --- a/drivers/net/dsa/Makefile | ||||
| +++ b/drivers/net/dsa/Makefile | ||||
| @@ -8,6 +8,7 @@ endif | ||||
|  obj-$(CONFIG_NET_DSA_LANTIQ_GSWIP) += lantiq_gswip.o | ||||
|  obj-$(CONFIG_NET_DSA_MT7530)	+= mt7530.o | ||||
|  obj-$(CONFIG_NET_DSA_MT7530_MDIO) += mt7530-mdio.o | ||||
| +obj-$(CONFIG_NET_DSA_MT7530_MMIO) += mt7530-mmio.o | ||||
|  obj-$(CONFIG_NET_DSA_MV88E6060) += mv88e6060.o | ||||
|  obj-$(CONFIG_NET_DSA_REALTEK_SMI) += realtek-smi.o | ||||
|  realtek-smi-objs		:= realtek-smi-core.o rtl8366.o rtl8366rb.o | ||||
| --- /dev/null | ||||
| +++ b/drivers/net/dsa/mt7530-mmio.c | ||||
| @@ -0,0 +1,101 @@ | ||||
| +// SPDX-License-Identifier: GPL-2.0-only | ||||
| + | ||||
| +#include <linux/module.h> | ||||
| +#include <linux/of_platform.h> | ||||
| +#include <linux/regmap.h> | ||||
| +#include <linux/regulator/consumer.h> | ||||
| +#include <linux/reset.h> | ||||
| +#include <net/dsa.h> | ||||
| + | ||||
| +#include "mt7530.h" | ||||
| + | ||||
| +static const struct of_device_id mt7988_of_match[] = { | ||||
| +	{ .compatible = "mediatek,mt7988-switch", .data = &mt753x_table[ID_MT7988], }, | ||||
| +	{ /* sentinel */ }, | ||||
| +}; | ||||
| +MODULE_DEVICE_TABLE(of, mt7988_of_match); | ||||
| + | ||||
| +static int | ||||
| +mt7988_probe(struct platform_device *pdev) | ||||
| +{ | ||||
| +	static struct regmap_config *sw_regmap_config; | ||||
| +	struct mt7530_priv *priv; | ||||
| +	void __iomem *base_addr; | ||||
| +	int ret; | ||||
| + | ||||
| +	priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL); | ||||
| +	if (!priv) | ||||
| +		return -ENOMEM; | ||||
| + | ||||
| +	priv->bus = NULL; | ||||
| +	priv->dev = &pdev->dev; | ||||
| + | ||||
| +	ret = mt7530_probe_common(priv); | ||||
| +	if (ret) | ||||
| +		return ret; | ||||
| + | ||||
| +	priv->rstc = devm_reset_control_get(&pdev->dev, NULL); | ||||
| +	if (IS_ERR(priv->rstc)) { | ||||
| +		dev_err(&pdev->dev, "Couldn't get our reset line\n"); | ||||
| +		return PTR_ERR(priv->rstc); | ||||
| +	} | ||||
| + | ||||
| +	base_addr = devm_platform_ioremap_resource(pdev, 0); | ||||
| +	if (IS_ERR(base_addr)) { | ||||
| +		dev_err(&pdev->dev, "cannot request I/O memory space\n"); | ||||
| +		return -ENXIO; | ||||
| +	} | ||||
| + | ||||
| +	sw_regmap_config = devm_kzalloc(&pdev->dev, sizeof(*sw_regmap_config), GFP_KERNEL); | ||||
| +	if (!sw_regmap_config) | ||||
| +		return -ENOMEM; | ||||
| + | ||||
| +	sw_regmap_config->name = "switch"; | ||||
| +	sw_regmap_config->reg_bits = 16; | ||||
| +	sw_regmap_config->val_bits = 32; | ||||
| +	sw_regmap_config->reg_stride = 4; | ||||
| +	sw_regmap_config->max_register = MT7530_CREV; | ||||
| +	priv->regmap = devm_regmap_init_mmio(&pdev->dev, base_addr, sw_regmap_config); | ||||
| +	if (IS_ERR(priv->regmap)) | ||||
| +		return PTR_ERR(priv->regmap); | ||||
| + | ||||
| +	return dsa_register_switch(priv->ds); | ||||
| +} | ||||
| + | ||||
| +static int | ||||
| +mt7988_remove(struct platform_device *pdev) | ||||
| +{ | ||||
| +	struct mt7530_priv *priv = platform_get_drvdata(pdev); | ||||
| + | ||||
| +	if (priv) | ||||
| +		mt7530_remove_common(priv); | ||||
| + | ||||
| +	return 0; | ||||
| +} | ||||
| + | ||||
| +static void mt7988_shutdown(struct platform_device *pdev) | ||||
| +{ | ||||
| +	struct mt7530_priv *priv = platform_get_drvdata(pdev); | ||||
| + | ||||
| +	if (!priv) | ||||
| +		return; | ||||
| + | ||||
| +	dsa_switch_shutdown(priv->ds); | ||||
| + | ||||
| +	dev_set_drvdata(&pdev->dev, NULL); | ||||
| +} | ||||
| + | ||||
| +static struct platform_driver mt7988_platform_driver = { | ||||
| +	.probe  = mt7988_probe, | ||||
| +	.remove = mt7988_remove, | ||||
| +	.shutdown = mt7988_shutdown, | ||||
| +	.driver = { | ||||
| +		.name = "mt7530-mmio", | ||||
| +		.of_match_table = mt7988_of_match, | ||||
| +	}, | ||||
| +}; | ||||
| +module_platform_driver(mt7988_platform_driver); | ||||
| + | ||||
| +MODULE_AUTHOR("Daniel Golle <daniel@makrotopia.org>"); | ||||
| +MODULE_DESCRIPTION("Driver for Mediatek MT7530 Switch (MMIO)"); | ||||
| +MODULE_LICENSE("GPL"); | ||||
| --- a/drivers/net/dsa/mt7530.c | ||||
| +++ b/drivers/net/dsa/mt7530.c | ||||
| @@ -1984,6 +1984,47 @@ static const struct irq_domain_ops mt753 | ||||
|  }; | ||||
|   | ||||
|  static void | ||||
| +mt7988_irq_mask(struct irq_data *d) | ||||
| +{ | ||||
| +	struct mt7530_priv *priv = irq_data_get_irq_chip_data(d); | ||||
| + | ||||
| +	priv->irq_enable &= ~BIT(d->hwirq); | ||||
| +	mt7530_mii_write(priv, MT7530_SYS_INT_EN, priv->irq_enable); | ||||
| +} | ||||
| + | ||||
| +static void | ||||
| +mt7988_irq_unmask(struct irq_data *d) | ||||
| +{ | ||||
| +	struct mt7530_priv *priv = irq_data_get_irq_chip_data(d); | ||||
| + | ||||
| +	priv->irq_enable |= BIT(d->hwirq); | ||||
| +	mt7530_mii_write(priv, MT7530_SYS_INT_EN, priv->irq_enable); | ||||
| +} | ||||
| + | ||||
| +static struct irq_chip mt7988_irq_chip = { | ||||
| +	.name = KBUILD_MODNAME, | ||||
| +	.irq_mask = mt7988_irq_mask, | ||||
| +	.irq_unmask = mt7988_irq_unmask, | ||||
| +}; | ||||
| + | ||||
| +static int | ||||
| +mt7988_irq_map(struct irq_domain *domain, unsigned int irq, | ||||
| +	       irq_hw_number_t hwirq) | ||||
| +{ | ||||
| +	irq_set_chip_data(irq, domain->host_data); | ||||
| +	irq_set_chip_and_handler(irq, &mt7988_irq_chip, handle_simple_irq); | ||||
| +	irq_set_nested_thread(irq, true); | ||||
| +	irq_set_noprobe(irq); | ||||
| + | ||||
| +	return 0; | ||||
| +} | ||||
| + | ||||
| +static const struct irq_domain_ops mt7988_irq_domain_ops = { | ||||
| +	.map = mt7988_irq_map, | ||||
| +	.xlate = irq_domain_xlate_onecell, | ||||
| +}; | ||||
| + | ||||
| +static void | ||||
|  mt7530_setup_mdio_irq(struct mt7530_priv *priv) | ||||
|  { | ||||
|  	struct dsa_switch *ds = priv->ds; | ||||
| @@ -2017,8 +2058,15 @@ mt7530_setup_irq(struct mt7530_priv *pri | ||||
|  		return priv->irq ? : -EINVAL; | ||||
|  	} | ||||
|   | ||||
| -	priv->irq_domain = irq_domain_add_linear(np, MT7530_NUM_PHYS, | ||||
| -						 &mt7530_irq_domain_ops, priv); | ||||
| +	if (priv->id == ID_MT7988) | ||||
| +		priv->irq_domain = irq_domain_add_linear(np, MT7530_NUM_PHYS, | ||||
| +							 &mt7988_irq_domain_ops, | ||||
| +							 priv); | ||||
| +	else | ||||
| +		priv->irq_domain = irq_domain_add_linear(np, MT7530_NUM_PHYS, | ||||
| +							 &mt7530_irq_domain_ops, | ||||
| +							 priv); | ||||
| + | ||||
|  	if (!priv->irq_domain) { | ||||
|  		dev_err(dev, "failed to create IRQ domain\n"); | ||||
|  		return -ENOMEM; | ||||
| @@ -2507,6 +2555,25 @@ static void mt7531_mac_port_get_caps(str | ||||
|  	} | ||||
|  } | ||||
|   | ||||
| +static void mt7988_mac_port_get_caps(struct dsa_switch *ds, int port, | ||||
| +				     struct phylink_config *config) | ||||
| +{ | ||||
| +	phy_interface_zero(config->supported_interfaces); | ||||
| + | ||||
| +	switch (port) { | ||||
| +	case 0 ... 4: /* Internal phy */ | ||||
| +		__set_bit(PHY_INTERFACE_MODE_INTERNAL, | ||||
| +			  config->supported_interfaces); | ||||
| +		break; | ||||
| + | ||||
| +	case 6: | ||||
| +		__set_bit(PHY_INTERFACE_MODE_INTERNAL, | ||||
| +			  config->supported_interfaces); | ||||
| +		config->mac_capabilities = MAC_ASYM_PAUSE | MAC_SYM_PAUSE | | ||||
| +					   MAC_10000FD; | ||||
| +	} | ||||
| +} | ||||
| + | ||||
|  static int | ||||
|  mt753x_pad_setup(struct dsa_switch *ds, const struct phylink_link_state *state) | ||||
|  { | ||||
| @@ -2583,6 +2650,17 @@ static bool mt753x_is_mac_port(u32 port) | ||||
|  } | ||||
|   | ||||
|  static int | ||||
| +mt7988_mac_config(struct dsa_switch *ds, int port, unsigned int mode, | ||||
| +		  phy_interface_t interface) | ||||
| +{ | ||||
| +	if (dsa_is_cpu_port(ds, port) && | ||||
| +	    interface == PHY_INTERFACE_MODE_INTERNAL) | ||||
| +		return 0; | ||||
| + | ||||
| +	return -EINVAL; | ||||
| +} | ||||
| + | ||||
| +static int | ||||
|  mt7531_mac_config(struct dsa_switch *ds, int port, unsigned int mode, | ||||
|  		  phy_interface_t interface) | ||||
|  { | ||||
| @@ -2652,7 +2730,8 @@ mt753x_phylink_mac_config(struct dsa_swi | ||||
|   | ||||
|  	switch (port) { | ||||
|  	case 0 ... 4: /* Internal phy */ | ||||
| -		if (state->interface != PHY_INTERFACE_MODE_GMII) | ||||
| +		if (state->interface != PHY_INTERFACE_MODE_GMII && | ||||
| +		    state->interface != PHY_INTERFACE_MODE_INTERNAL) | ||||
|  			goto unsupported; | ||||
|  		break; | ||||
|  	case 5: /* 2nd cpu port with phy of port 0 or 4 / external phy */ | ||||
| @@ -2730,7 +2809,8 @@ static void mt753x_phylink_mac_link_up(s | ||||
|  	/* MT753x MAC works in 1G full duplex mode for all up-clocked | ||||
|  	 * variants. | ||||
|  	 */ | ||||
| -	if (interface == PHY_INTERFACE_MODE_TRGMII || | ||||
| +	if (interface == PHY_INTERFACE_MODE_INTERNAL || | ||||
| +	    interface == PHY_INTERFACE_MODE_TRGMII || | ||||
|  	    (phy_interface_mode_is_8023z(interface))) { | ||||
|  		speed = SPEED_1000; | ||||
|  		duplex = DUPLEX_FULL; | ||||
| @@ -2810,6 +2890,21 @@ mt7531_cpu_port_config(struct dsa_switch | ||||
|  	return 0; | ||||
|  } | ||||
|   | ||||
| +static int | ||||
| +mt7988_cpu_port_config(struct dsa_switch *ds, int port) | ||||
| +{ | ||||
| +	struct mt7530_priv *priv = ds->priv; | ||||
| + | ||||
| +	mt7530_write(priv, MT7530_PMCR_P(port), | ||||
| +		     PMCR_CPU_PORT_SETTING(priv->id)); | ||||
| + | ||||
| +	mt753x_phylink_mac_link_up(ds, port, MLO_AN_FIXED, | ||||
| +				   PHY_INTERFACE_MODE_INTERNAL, NULL, | ||||
| +				   SPEED_10000, DUPLEX_FULL, true, true); | ||||
| + | ||||
| +	return 0; | ||||
| +} | ||||
| + | ||||
|  static void mt753x_phylink_get_caps(struct dsa_switch *ds, int port, | ||||
|  				    struct phylink_config *config) | ||||
|  { | ||||
| @@ -2955,6 +3050,27 @@ static int mt753x_set_mac_eee(struct dsa | ||||
|  	return 0; | ||||
|  } | ||||
|   | ||||
| +static int mt7988_pad_setup(struct dsa_switch *ds, phy_interface_t interface) | ||||
| +{ | ||||
| +	return 0; | ||||
| +} | ||||
| + | ||||
| +static int mt7988_setup(struct dsa_switch *ds) | ||||
| +{ | ||||
| +	struct mt7530_priv *priv = ds->priv; | ||||
| + | ||||
| +	/* Reset the switch */ | ||||
| +	reset_control_assert(priv->rstc); | ||||
| +	usleep_range(20, 50); | ||||
| +	reset_control_deassert(priv->rstc); | ||||
| +	usleep_range(20, 50); | ||||
| + | ||||
| +	/* Reset the switch PHYs */ | ||||
| +	mt7530_write(priv, MT7530_SYS_CTRL, SYS_CTRL_PHY_RST); | ||||
| + | ||||
| +	return mt7531_setup_common(ds); | ||||
| +} | ||||
| + | ||||
|  const struct dsa_switch_ops mt7530_switch_ops = { | ||||
|  	.get_tag_protocol	= mtk_get_tag_protocol, | ||||
|  	.setup			= mt753x_setup, | ||||
| @@ -3023,6 +3139,17 @@ const struct mt753x_info mt753x_table[] | ||||
|  		.mac_port_get_caps = mt7531_mac_port_get_caps, | ||||
|  		.mac_port_config = mt7531_mac_config, | ||||
|  	}, | ||||
| +	[ID_MT7988] = { | ||||
| +		.id = ID_MT7988, | ||||
| +		.pcs_ops = &mt7530_pcs_ops, | ||||
| +		.sw_setup = mt7988_setup, | ||||
| +		.phy_read = mt7531_ind_phy_read, | ||||
| +		.phy_write = mt7531_ind_phy_write, | ||||
| +		.pad_setup = mt7988_pad_setup, | ||||
| +		.cpu_port_config = mt7988_cpu_port_config, | ||||
| +		.mac_port_get_caps = mt7988_mac_port_get_caps, | ||||
| +		.mac_port_config = mt7988_mac_config, | ||||
| +	}, | ||||
|  }; | ||||
|  EXPORT_SYMBOL_GPL(mt753x_table); | ||||
|   | ||||
| --- a/drivers/net/dsa/mt7530.h | ||||
| +++ b/drivers/net/dsa/mt7530.h | ||||
| @@ -18,6 +18,7 @@ enum mt753x_id { | ||||
|  	ID_MT7530 = 0, | ||||
|  	ID_MT7621 = 1, | ||||
|  	ID_MT7531 = 2, | ||||
| +	ID_MT7988 = 3, | ||||
|  }; | ||||
|   | ||||
|  #define	NUM_TRGMII_CTRL			5 | ||||
| @@ -54,11 +55,11 @@ enum mt753x_id { | ||||
|  #define  MT7531_MIRROR_PORT_SET(x)	(((x) & MIRROR_MASK) << 16) | ||||
|  #define  MT7531_CPU_PMAP_MASK		GENMASK(7, 0) | ||||
|   | ||||
| -#define MT753X_MIRROR_REG(id)		(((id) == ID_MT7531) ? \ | ||||
| +#define MT753X_MIRROR_REG(id)		((((id) == ID_MT7531) || ((id) == ID_MT7988)) ?	\ | ||||
|  					 MT7531_CFC : MT7530_MFC) | ||||
| -#define MT753X_MIRROR_EN(id)		(((id) == ID_MT7531) ? \ | ||||
| +#define MT753X_MIRROR_EN(id)		((((id) == ID_MT7531) || ((id) == ID_MT7988)) ?	\ | ||||
|  					 MT7531_MIRROR_EN : MIRROR_EN) | ||||
| -#define MT753X_MIRROR_MASK(id)		(((id) == ID_MT7531) ? \ | ||||
| +#define MT753X_MIRROR_MASK(id)		((((id) == ID_MT7531) || ((id) == ID_MT7988)) ?	\ | ||||
|  					 MT7531_MIRROR_MASK : MIRROR_MASK) | ||||
|   | ||||
|  /* Registers for BPDU and PAE frame control*/ | ||||
| @@ -295,9 +296,8 @@ enum mt7530_vlan_port_acc_frm { | ||||
|  					 MT7531_FORCE_DPX | \ | ||||
|  					 MT7531_FORCE_RX_FC | \ | ||||
|  					 MT7531_FORCE_TX_FC) | ||||
| -#define  PMCR_FORCE_MODE_ID(id)		(((id) == ID_MT7531) ? \ | ||||
| -					 MT7531_FORCE_MODE : \ | ||||
| -					 PMCR_FORCE_MODE) | ||||
| +#define  PMCR_FORCE_MODE_ID(id)		((((id) == ID_MT7531) || ((id) == ID_MT7988)) ?	\ | ||||
| +					 MT7531_FORCE_MODE : PMCR_FORCE_MODE) | ||||
|  #define  PMCR_LINK_SETTINGS_MASK	(PMCR_TX_EN | PMCR_FORCE_SPEED_1000 | \ | ||||
|  					 PMCR_RX_EN | PMCR_FORCE_SPEED_100 | \ | ||||
|  					 PMCR_TX_FC_EN | PMCR_RX_FC_EN | \ | ||||
| @@ -0,0 +1,118 @@ | ||||
| From 91daa4f62ce878b6e1ac5908aceb83550332447f Mon Sep 17 00:00:00 2001 | ||||
| From: Daniel Golle <daniel@makrotopia.org> | ||||
| Date: Sun, 16 Apr 2023 13:08:14 +0100 | ||||
| Subject: [PATCH] net: dsa: mt7530: fix support for MT7531BE | ||||
| MIME-Version: 1.0 | ||||
| Content-Type: text/plain; charset=UTF-8 | ||||
| Content-Transfer-Encoding: 8bit | ||||
|  | ||||
| There are two variants of the MT7531 switch IC which got different | ||||
| features (and pins) regarding port 5: | ||||
|  * MT7531AE: SGMII/1000Base-X/2500Base-X SerDes PCS | ||||
|  * MT7531BE: RGMII | ||||
|  | ||||
| Moving the creation of the SerDes PCS from mt753x_setup to mt7530_probe | ||||
| with commit 6de285229773 ("net: dsa: mt7530: move SGMII PCS creation | ||||
| to mt7530_probe function") works fine for MT7531AE which got two | ||||
| instances of mtk-pcs-lynxi, however, MT7531BE requires mt7531_pll_setup | ||||
| to setup clocks before the single PCS on port 6 (usually used as CPU | ||||
| port) starts to work and hence the PCS creation failed on MT7531BE. | ||||
|  | ||||
| Fix this by introducing a pointer to mt7531_create_sgmii function in | ||||
| struct mt7530_priv and call it again at the end of mt753x_setup like it | ||||
| was before commit 6de285229773 ("net: dsa: mt7530: move SGMII PCS | ||||
| creation to mt7530_probe function"). | ||||
|  | ||||
| Fixes: 6de285229773 ("net: dsa: mt7530: move SGMII PCS creation to mt7530_probe function") | ||||
| Signed-off-by: Daniel Golle <daniel@makrotopia.org> | ||||
| Acked-by: Arınç ÜNAL <arinc.unal@arinc9.com> | ||||
| Link: https://lore.kernel.org/r/ZDvlLhhqheobUvOK@makrotopia.org | ||||
| Signed-off-by: Jakub Kicinski <kuba@kernel.org> | ||||
| --- | ||||
|  drivers/net/dsa/mt7530-mdio.c | 16 ++++++++-------- | ||||
|  drivers/net/dsa/mt7530.c      |  6 ++++++ | ||||
|  drivers/net/dsa/mt7530.h      |  4 ++-- | ||||
|  3 files changed, 16 insertions(+), 10 deletions(-) | ||||
|  | ||||
| --- a/drivers/net/dsa/mt7530-mdio.c | ||||
| +++ b/drivers/net/dsa/mt7530-mdio.c | ||||
| @@ -81,14 +81,17 @@ static const struct regmap_bus mt7530_re | ||||
|  }; | ||||
|   | ||||
|  static int | ||||
| -mt7531_create_sgmii(struct mt7530_priv *priv) | ||||
| +mt7531_create_sgmii(struct mt7530_priv *priv, bool dual_sgmii) | ||||
|  { | ||||
| -	struct regmap_config *mt7531_pcs_config[2]; | ||||
| +	struct regmap_config *mt7531_pcs_config[2] = {}; | ||||
|  	struct phylink_pcs *pcs; | ||||
|  	struct regmap *regmap; | ||||
|  	int i, ret = 0; | ||||
|   | ||||
| -	for (i = 0; i < 2; i++) { | ||||
| +	/* MT7531AE has two SGMII units for port 5 and port 6 | ||||
| +	 * MT7531BE has only one SGMII unit for port 6 | ||||
| +	 */ | ||||
| +	for (i = dual_sgmii ? 0 : 1; i < 2; i++) { | ||||
|  		mt7531_pcs_config[i] = devm_kzalloc(priv->dev, | ||||
|  						    sizeof(struct regmap_config), | ||||
|  						    GFP_KERNEL); | ||||
| @@ -208,11 +211,8 @@ mt7530_probe(struct mdio_device *mdiodev | ||||
|  	if (IS_ERR(priv->regmap)) | ||||
|  		return PTR_ERR(priv->regmap); | ||||
|   | ||||
| -	if (priv->id == ID_MT7531) { | ||||
| -		ret = mt7531_create_sgmii(priv); | ||||
| -		if (ret) | ||||
| -			return ret; | ||||
| -	} | ||||
| +	if (priv->id == ID_MT7531) | ||||
| +		priv->create_sgmii = mt7531_create_sgmii; | ||||
|   | ||||
|  	return dsa_register_switch(priv->ds); | ||||
|  } | ||||
| --- a/drivers/net/dsa/mt7530.c | ||||
| +++ b/drivers/net/dsa/mt7530.c | ||||
| @@ -3017,6 +3017,12 @@ mt753x_setup(struct dsa_switch *ds) | ||||
|  	if (ret && priv->irq) | ||||
|  		mt7530_free_irq_common(priv); | ||||
|   | ||||
| +	if (priv->create_sgmii) { | ||||
| +		ret = priv->create_sgmii(priv, mt7531_dual_sgmii_supported(priv)); | ||||
| +		if (ret && priv->irq) | ||||
| +			mt7530_free_irq(priv); | ||||
| +	} | ||||
| + | ||||
|  	return ret; | ||||
|  } | ||||
|   | ||||
| --- a/drivers/net/dsa/mt7530.h | ||||
| +++ b/drivers/net/dsa/mt7530.h | ||||
| @@ -741,10 +741,10 @@ struct mt753x_info { | ||||
|   *			registers | ||||
|   * @p6_interface	Holding the current port 6 interface | ||||
|   * @p5_intf_sel:	Holding the current port 5 interface select | ||||
| - * | ||||
|   * @irq:		IRQ number of the switch | ||||
|   * @irq_domain:		IRQ domain of the switch irq_chip | ||||
|   * @irq_enable:		IRQ enable bits, synced to SYS_INT_EN | ||||
| + * @create_sgmii:	Pointer to function creating SGMII PCS instance(s) | ||||
|   */ | ||||
|  struct mt7530_priv { | ||||
|  	struct device		*dev; | ||||
| @@ -763,7 +763,6 @@ struct mt7530_priv { | ||||
|  	unsigned int		p5_intf_sel; | ||||
|  	u8			mirror_rx; | ||||
|  	u8			mirror_tx; | ||||
| - | ||||
|  	struct mt7530_port	ports[MT7530_NUM_PORTS]; | ||||
|  	struct mt753x_pcs	pcs[MT7530_NUM_PORTS]; | ||||
|  	/* protect among processes for registers access*/ | ||||
| @@ -771,6 +770,7 @@ struct mt7530_priv { | ||||
|  	int irq; | ||||
|  	struct irq_domain *irq_domain; | ||||
|  	u32 irq_enable; | ||||
| +	int (*create_sgmii)(struct mt7530_priv *priv, bool dual_sgmii); | ||||
|  }; | ||||
|   | ||||
|  struct mt7530_hw_vlan_entry { | ||||
| @@ -21,7 +21,7 @@ Signed-off-by: David S. Miller <davem@davemloft.net> | ||||
|  | ||||
| --- a/MAINTAINERS | ||||
| +++ b/MAINTAINERS | ||||
| @@ -12697,6 +12697,7 @@ F:	include/uapi/linux/meye.h | ||||
| @@ -12700,6 +12700,7 @@ F:	include/uapi/linux/meye.h | ||||
|   | ||||
|  MOTORCOMM PHY DRIVER | ||||
|  M:	Peter Geis <pgwipeout@gmail.com> | ||||
|   | ||||
| @@ -19,7 +19,7 @@ Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> | ||||
|  | ||||
| --- a/MAINTAINERS | ||||
| +++ b/MAINTAINERS | ||||
| @@ -17962,6 +17962,11 @@ L:	netdev@vger.kernel.org | ||||
| @@ -17965,6 +17965,11 @@ L:	netdev@vger.kernel.org | ||||
|  S:	Maintained | ||||
|  F:	drivers/net/ethernet/dlink/sundance.c | ||||
|   | ||||
|   | ||||
| @@ -57,7 +57,7 @@ Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> | ||||
|  | ||||
| --- a/MAINTAINERS | ||||
| +++ b/MAINTAINERS | ||||
| @@ -12361,6 +12361,14 @@ S:	Supported | ||||
| @@ -12364,6 +12364,14 @@ S:	Supported | ||||
|  F:	Documentation/devicetree/bindings/mtd/atmel-nand.txt | ||||
|  F:	drivers/mtd/nand/raw/atmel/* | ||||
|   | ||||
|   | ||||
| @@ -15,7 +15,7 @@ Signed-off-by: Alexander Couzens <lynxis@fe80.eu> | ||||
|  | ||||
| --- a/drivers/net/dsa/mt7530.c | ||||
| +++ b/drivers/net/dsa/mt7530.c | ||||
| @@ -2347,6 +2347,10 @@ mt7531_setup(struct dsa_switch *ds) | ||||
| @@ -2440,6 +2440,10 @@ mt7531_setup(struct dsa_switch *ds) | ||||
|  		return -ENODEV; | ||||
|  	} | ||||
|   | ||||
|   | ||||
| @@ -16,7 +16,7 @@ Signed-off-by: David Bauer <mail@david-bauer.net> | ||||
|  | ||||
| --- a/drivers/net/dsa/mt7530.c | ||||
| +++ b/drivers/net/dsa/mt7530.c | ||||
| @@ -2081,10 +2081,13 @@ mt7530_setup_mdio(struct mt7530_priv *pr | ||||
| @@ -2121,10 +2121,13 @@ mt7530_setup_mdio(struct mt7530_priv *pr | ||||
|  { | ||||
|  	struct dsa_switch *ds = priv->ds; | ||||
|  	struct device *dev = priv->dev; | ||||
| @@ -30,7 +30,7 @@ Signed-off-by: David Bauer <mail@david-bauer.net> | ||||
|  	bus = devm_mdiobus_alloc(dev); | ||||
|  	if (!bus) | ||||
|  		return -ENOMEM; | ||||
| @@ -2101,7 +2104,9 @@ mt7530_setup_mdio(struct mt7530_priv *pr | ||||
| @@ -2141,7 +2144,9 @@ mt7530_setup_mdio(struct mt7530_priv *pr | ||||
|  	if (priv->irq) | ||||
|  		mt7530_setup_mdio_irq(priv); | ||||
|   | ||||
|   | ||||
| @@ -250,6 +250,8 @@ CONFIG_NEED_SG_DMA_LENGTH=y | ||||
| CONFIG_NET_DEVLINK=y | ||||
| CONFIG_NET_DSA=y | ||||
| CONFIG_NET_DSA_MT7530=y | ||||
| CONFIG_NET_DSA_MT7530_MDIO=y | ||||
| CONFIG_NET_DSA_MT7530_MMIO=y | ||||
| CONFIG_NET_DSA_TAG_MTK=y | ||||
| CONFIG_NET_FLOW_LIMIT=y | ||||
| CONFIG_NET_MEDIATEK_SOC=y | ||||
|   | ||||
| @@ -272,6 +272,8 @@ CONFIG_NEED_SG_DMA_LENGTH=y | ||||
| CONFIG_NET_DEVLINK=y | ||||
| CONFIG_NET_DSA=y | ||||
| CONFIG_NET_DSA_MT7530=y | ||||
| CONFIG_NET_DSA_MT7530_MDIO=y | ||||
| # CONFIG_NET_DSA_MT7530_MMIO is not set | ||||
| CONFIG_NET_DSA_TAG_MTK=y | ||||
| CONFIG_NET_FLOW_LIMIT=y | ||||
| CONFIG_NET_MEDIATEK_SOC=y | ||||
|   | ||||
| @@ -372,6 +372,8 @@ CONFIG_NEON=y | ||||
| CONFIG_NET_DEVLINK=y | ||||
| CONFIG_NET_DSA=y | ||||
| CONFIG_NET_DSA_MT7530=y | ||||
| CONFIG_NET_DSA_MT7530_MDIO=y | ||||
| # CONFIG_NET_DSA_MT7530_MMIO is not set | ||||
| CONFIG_NET_DSA_TAG_MTK=y | ||||
| CONFIG_NET_FLOW_LIMIT=y | ||||
| CONFIG_NET_MEDIATEK_SOC=y | ||||
|   | ||||
| @@ -197,6 +197,8 @@ CONFIG_NETFILTER=y | ||||
| CONFIG_NET_DEVLINK=y | ||||
| CONFIG_NET_DSA=y | ||||
| CONFIG_NET_DSA_MT7530=y | ||||
| CONFIG_NET_DSA_MT7530_MDIO=y | ||||
| # CONFIG_NET_DSA_MT7530_MMIO is not set | ||||
| CONFIG_NET_DSA_TAG_MTK=y | ||||
| CONFIG_NET_FLOW_LIMIT=y | ||||
| CONFIG_NET_MEDIATEK_SOC=y | ||||
|   | ||||
| @@ -184,6 +184,8 @@ CONFIG_NEED_DMA_MAP_STATE=y | ||||
| CONFIG_NET_DEVLINK=y | ||||
| CONFIG_NET_DSA=y | ||||
| CONFIG_NET_DSA_MT7530=y | ||||
| CONFIG_NET_DSA_MT7530_MDIO=y | ||||
| # CONFIG_NET_DSA_MT7530_MMIO is not set | ||||
| CONFIG_NET_DSA_TAG_MTK=y | ||||
| CONFIG_NET_FLOW_LIMIT=y | ||||
| CONFIG_NET_MEDIATEK_SOC=y | ||||
|   | ||||
| @@ -32,7 +32,7 @@ Signed-off-by: Guenter Roeck <linux@roeck-us.net> | ||||
|  | ||||
| --- a/MAINTAINERS | ||||
| +++ b/MAINTAINERS | ||||
| @@ -15899,6 +15899,13 @@ S:	Maintained | ||||
| @@ -15902,6 +15902,13 @@ S:	Maintained | ||||
|  F:	include/sound/rt*.h | ||||
|  F:	sound/soc/codecs/rt* | ||||
|   | ||||
|   | ||||
| @@ -22,7 +22,7 @@ Submitted-by: John Crispin <john@phrozen.org> | ||||
|  | ||||
| --- a/drivers/net/dsa/Kconfig | ||||
| +++ b/drivers/net/dsa/Kconfig | ||||
| @@ -61,6 +61,8 @@ source "drivers/net/dsa/sja1105/Kconfig" | ||||
| @@ -85,6 +85,8 @@ source "drivers/net/dsa/sja1105/Kconfig" | ||||
|   | ||||
|  source "drivers/net/dsa/xrs700x/Kconfig" | ||||
|   | ||||
| @@ -33,7 +33,7 @@ Submitted-by: John Crispin <john@phrozen.org> | ||||
|  	select NET_DSA_TAG_RTL4_A | ||||
| --- a/drivers/net/dsa/Makefile | ||||
| +++ b/drivers/net/dsa/Makefile | ||||
| @@ -22,5 +22,6 @@ obj-y				+= microchip/ | ||||
| @@ -24,5 +24,6 @@ obj-y				+= microchip/ | ||||
|  obj-y				+= mv88e6xxx/ | ||||
|  obj-y				+= ocelot/ | ||||
|  obj-y				+= qca/ | ||||
|   | ||||
		Reference in New Issue
	
	Block a user
	 Daniel Golle
					Daniel Golle