kernel: mtk_ppe: use MTK_FOE_STATE_INVALID instead of *_UNBIND
Instead of dropping *fix-typo-in-__mtk_foe_entry.patch which effectively means keeping the (also wrong) assignment of MTK_FOE_STATE_BIND, rather use MTK_FOE_STATE_INVALID as that works well on both older (NETSYS_V1) and newer (NETSYS_V2) MediaTek SoCs. Suggested-by: Felix Fietkau <nbd@nbd.name> Signed-off-by: Daniel Golle <daniel@makrotopia.org>
This commit is contained in:
		| @@ -0,0 +1,27 @@ | |||||||
|  | From 12ff69304c83c679ca01ef3db963ab0db9de19fb Mon Sep 17 00:00:00 2001 | ||||||
|  | Message-Id: <12ff69304c83c679ca01ef3db963ab0db9de19fb.1662332102.git.lorenzo@kernel.org> | ||||||
|  | In-Reply-To: <2a60545635c2705312299384f4e9fec2f2a3acd6.1662332102.git.lorenzo@kernel.org> | ||||||
|  | References: <2a60545635c2705312299384f4e9fec2f2a3acd6.1662332102.git.lorenzo@kernel.org> | ||||||
|  | From: Lorenzo Bianconi <lorenzo@kernel.org> | ||||||
|  | Date: Mon, 5 Sep 2022 00:43:43 +0200 | ||||||
|  | Subject: [PATCH net-next 2/6] net: ethernet: mtk_eth_soc: fix typo in | ||||||
|  |  __mtk_foe_entry_clear | ||||||
|  |  | ||||||
|  | Set ib1 state to MTK_FOE_STATE_UNBIND in __mtk_foe_entry_clear routine. | ||||||
|  |  | ||||||
|  | Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org> | ||||||
|  | --- | ||||||
|  |  drivers/net/ethernet/mediatek/mtk_ppe.c | 2 +- | ||||||
|  |  1 file changed, 1 insertion(+), 1 deletion(-) | ||||||
|  |  | ||||||
|  | --- a/drivers/net/ethernet/mediatek/mtk_ppe.c | ||||||
|  | +++ b/drivers/net/ethernet/mediatek/mtk_ppe.c | ||||||
|  | @@ -413,7 +413,7 @@ __mtk_foe_entry_clear(struct mtk_ppe *pp | ||||||
|  |  		struct mtk_foe_entry *hwe = mtk_foe_get_entry(ppe, entry->hash); | ||||||
|  |   | ||||||
|  |  		hwe->ib1 &= ~MTK_FOE_IB1_STATE; | ||||||
|  | -		hwe->ib1 |= FIELD_PREP(MTK_FOE_IB1_STATE, MTK_FOE_STATE_BIND); | ||||||
|  | +		hwe->ib1 |= FIELD_PREP(MTK_FOE_IB1_STATE, MTK_FOE_STATE_UNBIND); | ||||||
|  |  		dma_wmb(); | ||||||
|  |  	} | ||||||
|  |  	entry->hash = 0xffff; | ||||||
| @@ -0,0 +1,51 @@ | |||||||
|  | From cd8e1f340c3e571b78952d4ca2c128d183a47cc2 Mon Sep 17 00:00:00 2001 | ||||||
|  | From: Daniel Golle <daniel@makrotopia.org> | ||||||
|  | Date: Wed, 28 Sep 2022 02:17:02 +0100 | ||||||
|  | Subject: [PATCH] net: ethernet: mtk_eth_soc: fix state in | ||||||
|  |  __mtk_foe_entry_clear | ||||||
|  | To: linux-mediatek@lists.infradead.org, | ||||||
|  |     netdev@vger.kernel.org, | ||||||
|  |     Lorenzo Bianconi <lorenzo@kernel.org> | ||||||
|  | Cc: Sujuan Chen <sujuan.chen@mediatek.com>, | ||||||
|  |     Bo Jiao <Bo.Jiao@mediatek.com>, | ||||||
|  |     Felix Fietkau <nbd@nbd.name>, | ||||||
|  |     John Crispin <john@phrozen.org>, | ||||||
|  |     Sean Wang <sean.wang@mediatek.com>, | ||||||
|  |     Mark Lee <Mark-MC.Lee@mediatek.com>, | ||||||
|  |     David S. Miller <davem@davemloft.net>, | ||||||
|  |     Eric Dumazet <edumazet@google.com>, | ||||||
|  |     Jakub Kicinski <kuba@kernel.org>, | ||||||
|  |     Paolo Abeni <pabeni@redhat.com>, | ||||||
|  |     Matthias Brugger <matthias.bgg@gmail.com>, | ||||||
|  |     Chen Minqiang <ptpt52@gmail.com>, | ||||||
|  |     Thomas Hühn <thomas.huehn@hs-nordhausen.de> | ||||||
|  |  | ||||||
|  | Setting ib1 state to MTK_FOE_STATE_UNBIND in __mtk_foe_entry_clear | ||||||
|  | routine as done by commit 0e80707d94e4c8 ("net: ethernet: mtk_eth_soc: | ||||||
|  | fix typo in __mtk_foe_entry_clear") breaks flow offloading, at least | ||||||
|  | on older MTK_NETSYS_V1 SoCs, OpenWrt users have confirmed the bug on | ||||||
|  | MT7622 and MT7621 systems. | ||||||
|  | Felix Fietkau suggested to use MTK_FOE_STATE_INVALID instead which | ||||||
|  | works well on both, MTK_NETSYS_V1 and MTK_NETSYS_V2. | ||||||
|  |  | ||||||
|  | Tested on MT7622 (Linksys E8450) and MT7986 (BananaPi BPI-R3). | ||||||
|  |  | ||||||
|  | Suggested-by: Felix Fietkau <nbd@nbd.name> | ||||||
|  | Fixes: 0e80707d94e4c8 ("net: ethernet: mtk_eth_soc: fix typo in __mtk_foe_entry_clear") | ||||||
|  | Fixes: 33fc42de33278 ("net: ethernet: mtk_eth_soc: support creating mac address based offload entries") | ||||||
|  | Signed-off-by: Daniel Golle <daniel@makrotopia.org> | ||||||
|  | --- | ||||||
|  |  drivers/net/ethernet/mediatek/mtk_ppe.c | 2 +- | ||||||
|  |  1 file changed, 1 insertion(+), 1 deletion(-) | ||||||
|  |  | ||||||
|  | --- a/drivers/net/ethernet/mediatek/mtk_ppe.c | ||||||
|  | +++ b/drivers/net/ethernet/mediatek/mtk_ppe.c | ||||||
|  | @@ -442,7 +442,7 @@ __mtk_foe_entry_clear(struct mtk_ppe *pp | ||||||
|  |  		struct mtk_foe_entry *hwe = mtk_foe_get_entry(ppe, entry->hash); | ||||||
|  |   | ||||||
|  |  		hwe->ib1 &= ~MTK_FOE_IB1_STATE; | ||||||
|  | -		hwe->ib1 |= FIELD_PREP(MTK_FOE_IB1_STATE, MTK_FOE_STATE_UNBIND); | ||||||
|  | +		hwe->ib1 |= FIELD_PREP(MTK_FOE_IB1_STATE, MTK_FOE_STATE_INVALID); | ||||||
|  |  		dma_wmb(); | ||||||
|  |  	} | ||||||
|  |  	entry->hash = 0xffff; | ||||||
		Reference in New Issue
	
	Block a user
	 Daniel Golle
					Daniel Golle