domenico/openwrt_NSS_ACW
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ar71xx/ath79: ag71xx: init rings with GFP_KERNEL

Browse Source 
Upstream commit	246902bdf562d45ea3475fac64c93048a7a39f01

Which contains following explanation:

--
There is no need to use GFP_ATOMIC here, GFP_KERNEL should be enough.
The 'kcalloc()' just a few lines above, already uses GFP_KERNEL.
--

Looking at the code, all other descriptors also use plain GFP_KERNEL

Signed-off-by: Koen Vandeputte <koen.vandeputte@ncentric.com>
This commit is contained in:
Koen Vandeputte
2019-08-09 09:51:29 +02:00
parent 6ced31c320
commit b417a0c48d
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
target/linux/ath79/files/drivers/net/ethernet/atheros/ag71xx/ag71xx_main.c
View File

@@ -277,7 +277,7 @@ static int ag71xx_rings_init(struct ag71xx *ag)
return -ENOMEM; return -ENOMEM;
tx->descs_cpu = dma_alloc_coherent(&ag->pdev->dev, ring_size * AG71XX_DESC_SIZE, tx->descs_cpu = dma_alloc_coherent(&ag->pdev->dev, ring_size * AG71XX_DESC_SIZE,
&tx->descs_dma, GFP_ATOMIC); &tx->descs_dma, GFP_KERNEL);
if (!tx->descs_cpu) { if (!tx->descs_cpu) {
kfree(tx->buf); kfree(tx->buf);
tx->buf = NULL; tx->buf = NULL;