busybox: Fix snprintf arguments in lock
The first argument for snprintf is the buffer and the 2. one is the size. Fix the order. This broke the lock application. Fixes:9d2b26d5a7("busybox: fix busybox lock applet pidstr buffer overflow") Reported-by: Hartmut Birr <e9hack@gmail.com> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de> (cherry picked from commitd80336e1a9)
This commit is contained in:
		@@ -109,7 +109,7 @@
 | 
				
			|||||||
+		if (!waitonly) {
 | 
					+		if (!waitonly) {
 | 
				
			||||||
+			lseek(fd, 0, SEEK_SET);
 | 
					+			lseek(fd, 0, SEEK_SET);
 | 
				
			||||||
+			ftruncate(fd, 0);
 | 
					+			ftruncate(fd, 0);
 | 
				
			||||||
+			snprintf(sizeof(pidstr), pidstr, "%d\n", pid);
 | 
					+			snprintf(pidstr, sizeof(pidstr), "%d\n", pid);
 | 
				
			||||||
+			write(fd, pidstr, strlen(pidstr));
 | 
					+			write(fd, pidstr, strlen(pidstr));
 | 
				
			||||||
+			close(fd);
 | 
					+			close(fd);
 | 
				
			||||||
+		}
 | 
					+		}
 | 
				
			||||||
 
 | 
				
			|||||||
		Reference in New Issue
	
	Block a user