612e1c6801
Backport Aardvark PCIe controller driver changes that will appear in 5.17 kernel. They are currently accessible on LKML [1], in linux-next repository [2], or in Bjorn Helgaas' repository [3]. These changes mainly enhance driver removal method. [1] https://lore.kernel.org/linux-pci/20211130172913.9727-1-kabel@kernel.org/ [2] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/log/drivers/pci?h=next-20220107 [3] https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git/log/?h=next Signed-off-by: Marek Behún <kabel@kernel.org>
39 lines
1.5 KiB
Diff
39 lines
1.5 KiB
Diff
From 1f54391be8ce0c981d312cb93acdc5608def576a Mon Sep 17 00:00:00 2001
|
|
From: =?UTF-8?q?Pali=20Roh=C3=A1r?= <pali@kernel.org>
|
|
Date: Tue, 30 Nov 2021 18:29:11 +0100
|
|
Subject: [PATCH] PCI: aardvark: Assert PERST# when unbinding driver
|
|
MIME-Version: 1.0
|
|
Content-Type: text/plain; charset=UTF-8
|
|
Content-Transfer-Encoding: 8bit
|
|
|
|
Put the PCIe card into reset by asserting PERST# signal when unbinding
|
|
driver. It doesn't make sense to leave the card working if it can't
|
|
communicate with the host. This should also save some power.
|
|
|
|
Link: https://lore.kernel.org/r/20211130172913.9727-10-kabel@kernel.org
|
|
Signed-off-by: Pali Rohár <pali@kernel.org>
|
|
Signed-off-by: Marek Behún <kabel@kernel.org>
|
|
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
|
|
---
|
|
drivers/pci/controller/pci-aardvark.c | 4 ++++
|
|
1 file changed, 4 insertions(+)
|
|
|
|
diff --git a/drivers/pci/controller/pci-aardvark.c b/drivers/pci/controller/pci-aardvark.c
|
|
index b3d89cb449b6..271ebecee965 100644
|
|
--- a/drivers/pci/controller/pci-aardvark.c
|
|
+++ b/drivers/pci/controller/pci-aardvark.c
|
|
@@ -1737,6 +1737,10 @@ static int advk_pcie_remove(struct platform_device *pdev)
|
|
/* Free config space for emulated root bridge */
|
|
pci_bridge_emul_cleanup(&pcie->bridge);
|
|
|
|
+ /* Assert PERST# signal which prepares PCIe card for power down */
|
|
+ if (pcie->reset_gpio)
|
|
+ gpiod_set_value_cansleep(pcie->reset_gpio, 1);
|
|
+
|
|
/* Disable outbound address windows mapping */
|
|
for (i = 0; i < OB_WIN_COUNT; i++)
|
|
advk_pcie_disable_ob_win(pcie, i);
|
|
--
|
|
2.34.1
|
|
|