29 lines
		
	
	
		
			1.0 KiB
		
	
	
	
		
			Diff
		
	
	
	
	
	
			
		
		
	
	
			29 lines
		
	
	
		
			1.0 KiB
		
	
	
	
		
			Diff
		
	
	
	
	
	
From b9f63ae7ba2de2ba19137c5757c0607ce40f3ed5 Mon Sep 17 00:00:00 2001
 | 
						|
From: =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= <rafal@milecki.pl>
 | 
						|
Date: Wed, 17 Aug 2016 15:37:14 +0200
 | 
						|
Subject: [PATCH] net: bgmac: fix reversed check for MII registration error
 | 
						|
MIME-Version: 1.0
 | 
						|
Content-Type: text/plain; charset=UTF-8
 | 
						|
Content-Transfer-Encoding: 8bit
 | 
						|
 | 
						|
It was failing on successful registration returning meaningless errors.
 | 
						|
 | 
						|
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
 | 
						|
Fixes: 55954f3bfdac ("net: ethernet: bgmac: move BCMA MDIO Phy code into a separate file")
 | 
						|
Signed-off-by: David S. Miller <davem@davemloft.net>
 | 
						|
---
 | 
						|
 drivers/net/ethernet/broadcom/bgmac-bcma.c | 2 +-
 | 
						|
 1 file changed, 1 insertion(+), 1 deletion(-)
 | 
						|
 | 
						|
--- a/drivers/net/ethernet/broadcom/bgmac-bcma.c
 | 
						|
+++ b/drivers/net/ethernet/broadcom/bgmac-bcma.c
 | 
						|
@@ -159,7 +159,7 @@ static int bgmac_probe(struct bcma_devic
 | 
						|
 
 | 
						|
 	if (!bgmac_is_bcm4707_family(core)) {
 | 
						|
 		mii_bus = bcma_mdio_mii_register(core, bgmac->phyaddr);
 | 
						|
-		if (!IS_ERR(mii_bus)) {
 | 
						|
+		if (IS_ERR(mii_bus)) {
 | 
						|
 			err = PTR_ERR(mii_bus);
 | 
						|
 			goto err;
 | 
						|
 		}
 |