 8231f67218
			
		
	
	8231f67218
	
	
	
		
			
			This fixes: 1) Crash during USB disconnect 2) Crash in brcmf_txfinalize() on rmmod with packets queued 3) Some errors in exit path Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
		
			
				
	
	
		
			30 lines
		
	
	
		
			1.1 KiB
		
	
	
	
		
			Diff
		
	
	
	
	
	
			
		
		
	
	
			30 lines
		
	
	
		
			1.1 KiB
		
	
	
	
		
			Diff
		
	
	
	
	
	
| From 1be747d977014fea13dbac0de885c0c358eb393c Mon Sep 17 00:00:00 2001
 | |
| From: Arend van Spriel <arend.vanspriel@broadcom.com>
 | |
| Date: Thu, 11 Jul 2019 11:05:08 +0200
 | |
| Subject: [PATCH 3/7] brcmfmac: avoid firmware command in brcmf_netdev_open()
 | |
|  when bus is down
 | |
| 
 | |
| No point in sending a firmware command when bus is down so make it
 | |
| conditional checking the state.
 | |
| 
 | |
| Reviewed-by: Hante Meuleman <hante.meuleman@broadcom.com>
 | |
| Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesberts@broadcom.com>
 | |
| Reviewed-by: Franky Lin <franky.lin@broadcom.com>
 | |
| Signed-off-by: Arend van Spriel <arend.vanspriel@broadcom.com>
 | |
| ---
 | |
|  drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c | 3 ++-
 | |
|  1 file changed, 2 insertions(+), 1 deletion(-)
 | |
| 
 | |
| --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c
 | |
| +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c
 | |
| @@ -589,7 +589,8 @@ static int brcmf_netdev_stop(struct net_
 | |
|  
 | |
|  	brcmf_cfg80211_down(ndev);
 | |
|  
 | |
| -	brcmf_fil_iovar_data_set(ifp, "arp_hostip_clear", NULL, 0);
 | |
| +	if (ifp->drvr->bus_if->state == BRCMF_BUS_UP)
 | |
| +		brcmf_fil_iovar_data_set(ifp, "arp_hostip_clear", NULL, 0);
 | |
|  
 | |
|  	brcmf_net_setcarrier(ifp, false);
 | |
|  
 |