Use a new implementation by using a devfreq driver to scale the shared cache of the krait cpu cores. Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
		
			
				
	
	
		
			243 lines
		
	
	
		
			6.8 KiB
		
	
	
	
		
			Diff
		
	
	
	
	
	
			
		
		
	
	
			243 lines
		
	
	
		
			6.8 KiB
		
	
	
	
		
			Diff
		
	
	
	
	
	
From b044ae89862132a86fb511648e9c52ea3cdf8c30 Mon Sep 17 00:00:00 2001
 | 
						|
From: Christian Marangi <ansuelsmth@gmail.com>
 | 
						|
Date: Wed, 5 Aug 2020 14:19:23 +0200
 | 
						|
Subject: [PATCH 1/4] devfreq: qcom: Add L2 Krait Cache devfreq scaling driver
 | 
						|
 | 
						|
Qcom L2 Krait CPUs use the generic cpufreq-dt driver and doesn't actually
 | 
						|
scale the Cache frequency when the CPU frequency is changed. This
 | 
						|
devfreq driver register with the cpu notifier and scale the Cache
 | 
						|
based on the max Freq across all core as the CPU cache is shared across
 | 
						|
all of them. If provided this also scale the voltage of the regulator
 | 
						|
attached to the CPU cache. The scaling logic is based on the CPU freq
 | 
						|
and the 3 scaling interval are set by the device dts.
 | 
						|
 | 
						|
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
 | 
						|
---
 | 
						|
 drivers/devfreq/Kconfig               |  11 ++
 | 
						|
 drivers/devfreq/Makefile              |   1 +
 | 
						|
 drivers/devfreq/krait-cache-devfreq.c | 188 ++++++++++++++++++++++++++
 | 
						|
 3 files changed, 200 insertions(+)
 | 
						|
 create mode 100644 drivers/devfreq/krait-cache-devfreq.c
 | 
						|
 | 
						|
--- a/drivers/devfreq/Kconfig
 | 
						|
+++ b/drivers/devfreq/Kconfig
 | 
						|
@@ -132,6 +132,17 @@ config ARM_RK3399_DMC_DEVFREQ
 | 
						|
 	  It sets the frequency for the memory controller and reads the usage counts
 | 
						|
 	  from hardware.
 | 
						|
 
 | 
						|
+config ARM_KRAIT_CACHE_DEVFREQ
 | 
						|
+	tristate "Scaling support for Krait CPU Cache Devfreq"
 | 
						|
+	depends on ARCH_QCOM || COMPILE_TEST
 | 
						|
+	select DEVFREQ_GOV_PASSIVE
 | 
						|
+	help
 | 
						|
+	  This adds the DEVFREQ driver for the Krait CPU L2 Cache shared by all cores.
 | 
						|
+
 | 
						|
+	  The driver register with the cpufreq notifier and find the right frequency
 | 
						|
+	  based on the max frequency across all core and the range set in the device
 | 
						|
+	  dts. If provided this scale also the regulator attached to the l2 cache.
 | 
						|
+
 | 
						|
 source "drivers/devfreq/event/Kconfig"
 | 
						|
 
 | 
						|
 endif # PM_DEVFREQ
 | 
						|
--- a/drivers/devfreq/Makefile
 | 
						|
+++ b/drivers/devfreq/Makefile
 | 
						|
@@ -13,6 +13,7 @@ obj-$(CONFIG_ARM_IMX_BUS_DEVFREQ)	+= imx
 | 
						|
 obj-$(CONFIG_ARM_IMX8M_DDRC_DEVFREQ)	+= imx8m-ddrc.o
 | 
						|
 obj-$(CONFIG_ARM_RK3399_DMC_DEVFREQ)	+= rk3399_dmc.o
 | 
						|
 obj-$(CONFIG_ARM_TEGRA_DEVFREQ)		+= tegra30-devfreq.o
 | 
						|
+obj-$(CONFIG_ARM_KRAIT_CACHE_DEVFREQ)	+= krait-cache-devfreq.o
 | 
						|
 
 | 
						|
 # DEVFREQ Event Drivers
 | 
						|
 obj-$(CONFIG_PM_DEVFREQ_EVENT)		+= event/
 | 
						|
--- /dev/null
 | 
						|
+++ b/drivers/devfreq/krait-cache-devfreq.c
 | 
						|
@@ -0,0 +1,188 @@
 | 
						|
+// SPDX-License-Identifier: GPL-2.0
 | 
						|
+
 | 
						|
+#include <linux/kernel.h>
 | 
						|
+#include <linux/init.h>
 | 
						|
+#include <linux/module.h>
 | 
						|
+#include <linux/cpufreq.h>
 | 
						|
+#include <linux/devfreq.h>
 | 
						|
+#include <linux/of.h>
 | 
						|
+#include <linux/platform_device.h>
 | 
						|
+#include <linux/clk.h>
 | 
						|
+#include <linux/slab.h>
 | 
						|
+#include <linux/regulator/consumer.h>
 | 
						|
+#include <linux/pm_opp.h>
 | 
						|
+
 | 
						|
+#include "governor.h"
 | 
						|
+
 | 
						|
+struct krait_cache_data {
 | 
						|
+	struct clk *clk;
 | 
						|
+	unsigned long idle_freq;
 | 
						|
+};
 | 
						|
+
 | 
						|
+static int krait_cache_set_opp(struct dev_pm_set_opp_data *data)
 | 
						|
+{
 | 
						|
+	unsigned long old_freq = data->old_opp.rate, freq = data->new_opp.rate;
 | 
						|
+	struct dev_pm_opp_supply *supply = &data->new_opp.supplies[0];
 | 
						|
+	struct regulator *reg = data->regulators[0];
 | 
						|
+	struct krait_cache_data *kdata;
 | 
						|
+	struct clk *clk = data->clk;
 | 
						|
+	unsigned long idle_freq;
 | 
						|
+	int ret;
 | 
						|
+
 | 
						|
+	kdata = dev_get_drvdata(data->dev);
 | 
						|
+	idle_freq = kdata->idle_freq;
 | 
						|
+
 | 
						|
+	if (reg) {
 | 
						|
+		ret = regulator_set_voltage_triplet(reg, supply->u_volt_min,
 | 
						|
+						    supply->u_volt,
 | 
						|
+						    supply->u_volt_max);
 | 
						|
+		if (ret)
 | 
						|
+			goto exit;
 | 
						|
+	}
 | 
						|
+
 | 
						|
+	/*
 | 
						|
+	 * Set to idle bin if switching from normal to high bin
 | 
						|
+	 * or vice versa. It has been notice that a bug is triggered
 | 
						|
+	 * in cache scaling when more than one bin is scaled, to fix
 | 
						|
+	 * this we first need to transition to the base rate and then
 | 
						|
+	 * to target rate
 | 
						|
+	 */
 | 
						|
+	if (likely(freq != idle_freq && old_freq != idle_freq)) {
 | 
						|
+		ret = clk_set_rate(clk, idle_freq);
 | 
						|
+		if (ret)
 | 
						|
+			goto exit;
 | 
						|
+	}
 | 
						|
+
 | 
						|
+	ret = clk_set_rate(clk, freq);
 | 
						|
+	if (ret)
 | 
						|
+		goto exit;
 | 
						|
+
 | 
						|
+exit:
 | 
						|
+	return ret;
 | 
						|
+};
 | 
						|
+
 | 
						|
+static int krait_cache_get_cur_freq(struct device *dev, unsigned long *freq)
 | 
						|
+{
 | 
						|
+	struct krait_cache_data *data = dev_get_drvdata(dev);
 | 
						|
+
 | 
						|
+	*freq = clk_get_rate(data->clk);
 | 
						|
+
 | 
						|
+	return 0;
 | 
						|
+};
 | 
						|
+
 | 
						|
+static int krait_cache_target(struct device *dev, unsigned long *freq,
 | 
						|
+			      u32 flags)
 | 
						|
+{
 | 
						|
+	struct dev_pm_opp *opp;
 | 
						|
+
 | 
						|
+	opp = dev_pm_opp_find_freq_ceil(dev, freq);
 | 
						|
+	if (unlikely(IS_ERR(opp)))
 | 
						|
+		return PTR_ERR(opp);
 | 
						|
+
 | 
						|
+	dev_pm_opp_put(opp);
 | 
						|
+
 | 
						|
+	return dev_pm_opp_set_rate(dev, *freq);
 | 
						|
+};
 | 
						|
+
 | 
						|
+static int krait_cache_get_dev_status(struct device *dev,
 | 
						|
+				      struct devfreq_dev_status *stat)
 | 
						|
+{
 | 
						|
+	struct krait_cache_data *data = dev_get_drvdata(dev);
 | 
						|
+
 | 
						|
+	stat->busy_time = 0;
 | 
						|
+	stat->total_time = 0;
 | 
						|
+	stat->current_frequency = clk_get_rate(data->clk);
 | 
						|
+
 | 
						|
+	return 0;
 | 
						|
+};
 | 
						|
+
 | 
						|
+static struct devfreq_dev_profile krait_cache_devfreq_profile = {
 | 
						|
+	.target = krait_cache_target,
 | 
						|
+	.get_dev_status = krait_cache_get_dev_status,
 | 
						|
+	.get_cur_freq = krait_cache_get_cur_freq
 | 
						|
+};
 | 
						|
+
 | 
						|
+static struct devfreq_passive_data devfreq_gov_data = {
 | 
						|
+	.parent_type = CPUFREQ_PARENT_DEV,
 | 
						|
+};
 | 
						|
+
 | 
						|
+static int krait_cache_probe(struct platform_device *pdev)
 | 
						|
+{
 | 
						|
+	struct device *dev = &pdev->dev;
 | 
						|
+	struct krait_cache_data *data;
 | 
						|
+	struct opp_table *table;
 | 
						|
+	struct devfreq *devfreq;
 | 
						|
+	struct dev_pm_opp *opp;
 | 
						|
+	struct clk *clk;
 | 
						|
+	int ret;
 | 
						|
+
 | 
						|
+	krait_cache_devfreq_profile.freq_table = NULL;
 | 
						|
+
 | 
						|
+	data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL);
 | 
						|
+	if (!data)
 | 
						|
+		return -ENOMEM;
 | 
						|
+
 | 
						|
+	clk = devm_clk_get(dev, "l2");
 | 
						|
+	if (IS_ERR(clk))
 | 
						|
+		return PTR_ERR(clk);
 | 
						|
+
 | 
						|
+	table = dev_pm_opp_set_regulators(dev, (const char *[]){ "l2" }, 1);
 | 
						|
+	if (IS_ERR(table)) {
 | 
						|
+		ret = PTR_ERR(table);
 | 
						|
+		dev_err_probe(dev, -EPROBE_DEFER, "failed to set regulators %d\n", ret);
 | 
						|
+		return ret;
 | 
						|
+	}
 | 
						|
+
 | 
						|
+	ret = PTR_ERR_OR_ZERO(
 | 
						|
+		dev_pm_opp_register_set_opp_helper(dev, krait_cache_set_opp));
 | 
						|
+	if (ret)
 | 
						|
+		return ret;
 | 
						|
+
 | 
						|
+	ret = dev_pm_opp_of_add_table(dev);
 | 
						|
+	if (ret) {
 | 
						|
+		dev_err(dev, "failed to parse L2 freq thresholds\n");
 | 
						|
+		return ret;
 | 
						|
+	}
 | 
						|
+
 | 
						|
+	data->clk = clk;
 | 
						|
+	opp = dev_pm_opp_find_freq_ceil(dev, &data->idle_freq);
 | 
						|
+	dev_pm_opp_put(opp);
 | 
						|
+
 | 
						|
+	dev_set_drvdata(dev, data);
 | 
						|
+
 | 
						|
+	devfreq = devm_devfreq_add_device(&pdev->dev, &krait_cache_devfreq_profile,
 | 
						|
+					  DEVFREQ_GOV_PASSIVE, &devfreq_gov_data);
 | 
						|
+	if (IS_ERR(devfreq)) {
 | 
						|
+		dev_pm_opp_remove_table(dev);
 | 
						|
+		dev_pm_opp_put_regulators(table);
 | 
						|
+		dev_pm_opp_unregister_set_opp_helper(table);
 | 
						|
+	}
 | 
						|
+
 | 
						|
+	return PTR_ERR_OR_ZERO(devfreq);
 | 
						|
+};
 | 
						|
+
 | 
						|
+static int krait_cache_remove(struct platform_device *pdev)
 | 
						|
+{
 | 
						|
+	dev_pm_opp_remove_table(&pdev->dev);
 | 
						|
+
 | 
						|
+	return 0;
 | 
						|
+};
 | 
						|
+
 | 
						|
+static const struct of_device_id krait_cache_match_table[] = {
 | 
						|
+	{ .compatible = "qcom,krait-cache" },
 | 
						|
+	{}
 | 
						|
+};
 | 
						|
+
 | 
						|
+static struct platform_driver krait_cache_driver = {
 | 
						|
+	.probe		= krait_cache_probe,
 | 
						|
+	.remove		= krait_cache_remove,
 | 
						|
+	.driver		= {
 | 
						|
+		.name   = "krait-cache-scaling",
 | 
						|
+		.of_match_table = krait_cache_match_table,
 | 
						|
+	},
 | 
						|
+};
 | 
						|
+module_platform_driver(krait_cache_driver);
 | 
						|
+
 | 
						|
+MODULE_DESCRIPTION("Krait CPU Cache Scaling driver");
 | 
						|
+MODULE_AUTHOR("Christian 'Ansuel' Marangi <ansuelsmth@gmail.com>");
 | 
						|
+MODULE_LICENSE("GPL v2");
 |