41 lines
		
	
	
		
			1.7 KiB
		
	
	
	
		
			Diff
		
	
	
	
	
	
			
		
		
	
	
			41 lines
		
	
	
		
			1.7 KiB
		
	
	
	
		
			Diff
		
	
	
	
	
	
From: =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= <zajec5@gmail.com>
 | 
						|
Date: Fri, 17 Jun 2016 12:48:44 +0200
 | 
						|
Subject: [PATCH] brcmfmac: use const char * for interface name in
 | 
						|
 brcmf_add_if
 | 
						|
MIME-Version: 1.0
 | 
						|
Content-Type: text/plain; charset=UTF-8
 | 
						|
Content-Transfer-Encoding: 8bit
 | 
						|
 | 
						|
This function can work just fine with const pointer, it only calls
 | 
						|
alloc_netdev which take const as well. Moreover it makes this function
 | 
						|
more flexible as some cfg80211 callback may provide const char * as
 | 
						|
well, e.g. add_virtual_intf. This will be needed for more advanced
 | 
						|
interface management.
 | 
						|
 | 
						|
Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
 | 
						|
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
 | 
						|
---
 | 
						|
 | 
						|
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c
 | 
						|
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c
 | 
						|
@@ -638,7 +638,7 @@ fail:
 | 
						|
 }
 | 
						|
 
 | 
						|
 struct brcmf_if *brcmf_add_if(struct brcmf_pub *drvr, s32 bsscfgidx, s32 ifidx,
 | 
						|
-			      bool is_p2pdev, char *name, u8 *mac_addr)
 | 
						|
+			      bool is_p2pdev, const char *name, u8 *mac_addr)
 | 
						|
 {
 | 
						|
 	struct brcmf_if *ifp;
 | 
						|
 	struct net_device *ndev;
 | 
						|
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.h
 | 
						|
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.h
 | 
						|
@@ -215,7 +215,7 @@ char *brcmf_ifname(struct brcmf_if *ifp)
 | 
						|
 struct brcmf_if *brcmf_get_ifp(struct brcmf_pub *drvr, int ifidx);
 | 
						|
 int brcmf_net_attach(struct brcmf_if *ifp, bool rtnl_locked);
 | 
						|
 struct brcmf_if *brcmf_add_if(struct brcmf_pub *drvr, s32 bsscfgidx, s32 ifidx,
 | 
						|
-			      bool is_p2pdev, char *name, u8 *mac_addr);
 | 
						|
+			      bool is_p2pdev, const char *name, u8 *mac_addr);
 | 
						|
 void brcmf_remove_interface(struct brcmf_if *ifp, bool rtnl_locked);
 | 
						|
 void brcmf_txflowblock_if(struct brcmf_if *ifp,
 | 
						|
 			  enum brcmf_netif_stop_reason reason, bool state);
 |