34 lines
		
	
	
		
			1.3 KiB
		
	
	
	
		
			Diff
		
	
	
	
	
	
			
		
		
	
	
			34 lines
		
	
	
		
			1.3 KiB
		
	
	
	
		
			Diff
		
	
	
	
	
	
From 1a8a8989b779e51e4652a30e9f22c36a1b6ffc4b Mon Sep 17 00:00:00 2001
 | 
						|
From: Stanislaw Gruszka <sgruszka@redhat.com>
 | 
						|
Date: Thu, 20 Dec 2018 16:16:11 +0100
 | 
						|
X-Patchwork-Submitter: Stanislaw Gruszka <sgruszka@redhat.com>
 | 
						|
X-Patchwork-Id: 10739037
 | 
						|
X-Patchwork-Delegate: kvalo@adurom.com
 | 
						|
Subject: [PATCH 20/28] rt2x00: do not print error when queue is full
 | 
						|
 | 
						|
For unknown reasons printk() on some context can cause CPU hung on
 | 
						|
embedded MT7620 AP/router MIPS platforms. What can result on wifi
 | 
						|
disconnects.
 | 
						|
 | 
						|
This patch move queue full messages to debug level what is consistent
 | 
						|
with other mac80211 drivers which drop packet silently if tx queue is
 | 
						|
full. This make MT7620 OpenWRT routers more stable, what was reported
 | 
						|
by various users.
 | 
						|
 | 
						|
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
 | 
						|
---
 | 
						|
 drivers/net/wireless/ralink/rt2x00/rt2x00queue.c | 2 +-
 | 
						|
 1 file changed, 1 insertion(+), 1 deletion(-)
 | 
						|
 | 
						|
--- a/drivers/net/wireless/ralink/rt2x00/rt2x00queue.c
 | 
						|
+++ b/drivers/net/wireless/ralink/rt2x00/rt2x00queue.c
 | 
						|
@@ -671,7 +671,7 @@ int rt2x00queue_write_tx_frame(struct da
 | 
						|
 	spin_lock(&queue->tx_lock);
 | 
						|
 
 | 
						|
 	if (unlikely(rt2x00queue_full(queue))) {
 | 
						|
-		rt2x00_err(queue->rt2x00dev, "Dropping frame due to full tx queue %d\n",
 | 
						|
+		rt2x00_dbg(queue->rt2x00dev, "Dropping frame due to full tx queue %d\n",
 | 
						|
 			   queue->qid);
 | 
						|
 		ret = -ENOBUFS;
 | 
						|
 		goto out;
 |